Your message dated Thu, 14 Mar 2024 10:21:56 +0000
with message-id <e1rkidk-00bw6d...@fasolo.debian.org>
and subject line Bug#1066839: fixed in pipewire 1.0.4-2
has caused the Debian Bug report #1066839,
regarding pipewire: ftbfs with 64-bit time_t
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1066839: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066839
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pipewire
Version: 1.0.3-1.1
Severity: serious
Tags: patch
Justification: ftbfs
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch

Dear maintainers,

pipewire fails to build from source on 32-bit architectures under 64-bit
time_t, because it has a module that legitimately un-sets _FILE_OFFSET_BITS
for building but this is not allowed without also unsetting _TIME_BITS.

Since this is a legitimate un-setting of _FILE_OFFSET_BITS in order to get
access to the necessary libc6 prototypes and macros, and since the functions
being intercepted are not sensitive to time_t, the simplest solution is to
also unset _TIME_BITS.

Please see the attached patch, which has been uploaded to Ubuntu to fix this
build failure.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru pipewire-1.0.3/debian/control pipewire-1.0.3/debian/control
--- pipewire-1.0.3/debian/control       2024-03-04 08:54:55.000000000 -0800
+++ pipewire-1.0.3/debian/control       2024-03-13 23:11:56.000000000 -0700
@@ -1,8 +1,7 @@
 Source: pipewire
 Section: libs
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
-XSBC-Original-Maintainer: Utopia Maintenance Team 
<pkg-utopia-maintain...@alioth-lists.debian.net>
+Maintainer: Utopia Maintenance Team 
<pkg-utopia-maintain...@alioth-lists.debian.net>
 Uploaders: Jeremy Bicha <jbi...@debian.org>,
            Dylan Aïssi <dai...@debian.org>
 Build-Depends: dpkg-dev (>= 1.22.5), debhelper-compat (= 13),
diff -Nru pipewire-1.0.3/debian/patches/64-bit-time-t-compat.patch 
pipewire-1.0.3/debian/patches/64-bit-time-t-compat.patch
--- pipewire-1.0.3/debian/patches/64-bit-time-t-compat.patch    1969-12-31 
16:00:00.000000000 -0800
+++ pipewire-1.0.3/debian/patches/64-bit-time-t-compat.patch    2024-03-13 
23:11:47.000000000 -0700
@@ -0,0 +1,21 @@
+Description: 64-bit time_t compatibility for v4l2 module
+ The v4l2 build unsets _FILE_OFFSET_BITS, which is not allowed when setting
+ _TIME_BITS=64.  Having verified that nothing in this module is sensitive to
+ 64-bit time_t (none of the functions it intercepts handle time), we also
+ unset _TIME_BITS to allow this to build as before.
+Author: Steve Langasek <steve.langa...@canonical.com>
+Forwarded: no
+Last-Update: 2024-03-13
+
+Index: pipewire-1.0.3/pipewire-v4l2/src/meson.build
+===================================================================
+--- pipewire-1.0.3.orig/pipewire-v4l2/src/meson.build
++++ pipewire-1.0.3/pipewire-v4l2/src/meson.build
+@@ -12,6 +12,7 @@
+   '-U_FILE_OFFSET_BITS',
+   '-D_FILE_OFFSET_BITS=32',
+   '-D_LARGEFILE64_SOURCE',
++  '-U_TIME_BITS',
+   '-fvisibility=hidden',
+ ]
+ 
diff -Nru pipewire-1.0.3/debian/patches/series 
pipewire-1.0.3/debian/patches/series
--- pipewire-1.0.3/debian/patches/series        2024-03-04 08:54:55.000000000 
-0800
+++ pipewire-1.0.3/debian/patches/series        2024-03-13 23:09:06.000000000 
-0700
@@ -19,3 +19,4 @@
 snap/snap-policy-Manage-ENOPROTOOPT-error-in-aa_getpeercon.patch
 snap/snap-policy-ensure-audio-works-with-.deb-snapd.patch
 snap/snap-policy-fix-memory-leak.patch
+64-bit-time-t-compat.patch

--- End Message ---
--- Begin Message ---
Source: pipewire
Source-Version: 1.0.4-2
Done: Dylan Aïssi <dai...@debian.org>

We believe that the bug you reported is fixed in the latest version of
pipewire, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <dai...@debian.org> (supplier of updated pipewire package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 14 Mar 2024 10:12:07 +0100
Source: pipewire
Architecture: source
Version: 1.0.4-2
Distribution: unstable
Urgency: medium
Maintainer: Utopia Maintenance Team 
<pkg-utopia-maintain...@alioth-lists.debian.net>
Changed-By: Dylan Aïssi <dai...@debian.org>
Closes: 1066839
Changes:
 pipewire (1.0.4-2) unstable; urgency=medium
 .
   [ Jeremy Bícha ]
   * Use dh_installman to install manpages
 .
   [ Steve Langasek ]
   * Add patch for 64-bit time_t compatibility (Closes: #1066839)
Checksums-Sha1:
 5dd1f593d1c085d4f84025115b9ca93deea5884d 4588 pipewire_1.0.4-2.dsc
 cf4c015cd3221c424ef5354297f779e71236419f 35944 pipewire_1.0.4-2.debian.tar.xz
 28a511ca53ac2f5737695bc48bc8c4e24463f270 28848 pipewire_1.0.4-2_amd64.buildinfo
Checksums-Sha256:
 f41827f447dfeb49e57f8134427bdd72da0f74339bc085d7c723a2d0421d7f35 4588 
pipewire_1.0.4-2.dsc
 2a163f6a3fd2bad7adbe2c4bd6469b1012ae5ecdc192ded4066c8a32395325be 35944 
pipewire_1.0.4-2.debian.tar.xz
 94cb0fb006483094071688fba9d2a88e41488584b32b34969f86d1850819a3d8 28848 
pipewire_1.0.4-2_amd64.buildinfo
Files:
 40ab0a11d1efc7af5096dccf83009a8c 4588 libs optional pipewire_1.0.4-2.dsc
 5eb3c9805f3de0b237ad5ea19fe44ca4 35944 libs optional 
pipewire_1.0.4-2.debian.tar.xz
 2b00c040ca94d8a442298b105fe13b98 28848 libs optional 
pipewire_1.0.4-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmXywdwACgkQYS7xYT4F
D1SlfQ//YuZvPWIgGL3Czav7fNJgW9T38VvTzb7Kh4JT4HCWMBjHj18ZN1yfWUO4
xelxztFVcnsgeGMIUZDcT8E4o920On1wnuv4DMG11TqtmszMrS3JZIkGNC9Ulwy2
7B6v5PlldQawyYTY+CUdB3s44WIqD8TnHBJBopj/CpKWJNu0R+D1z1+pxbeaGYfF
ha2Z7oN9LMXWp2CypZB8i0GeqBQWiA1kQHxmhORvnxgJdLDTfVI3+7TqllIDD5mH
R5cZbkS8eovIbm1VdtFatkJgCAgDA/0DlboA+MtAeQfUz9OM67007vVEsAd+LmRb
yFAf8kw57AXPo3xH8YnPsrePgAKwvXzl7WURMVxcMu6yRMfyHOdehMKQ43dlw927
jRtE2vRgL1s7NoTdKc7gIBEi7jrVLxvjLbXNVOgppxhvb2cTSz+1VFdrTOXfOoNv
WMYiOi6NYv1Hiv82gHnFwb/SIEI+fbjABNKmWDpdmEl/xVox7jHgGCyF6HjCJil7
GHWtRzRREgrNhFFEl9ahgXYEyA81sydItSmqWFw9FYgVgvLVIKUeCeesR+0SXPAW
qgxECd1hB1S0rW0uYo6rKda1x8M2IHhPdnD998zZQHQs0YTQrRcJboXi71zdXky6
sCJPZIJIbFbOEDtvQ11y10nVHAeHTmmqonVqOvFpXT1KJcEt35g=
=7mOq
-----END PGP SIGNATURE-----

Attachment: pgpjZqbuZspgw.pgp
Description: PGP signature


--- End Message ---

Reply via email to