On 2024-01-23 14:39, Maytham Alsudany wrote:
Hi Drew,
On Tue, 2024-01-23 at 11:24 +0100, Drew Parsons wrote:
> > Hi Maytham, I can upload it. But note how pkcs11 is failing on 32 bit
> > arches. That needs to be sorted out. I had been waiting for that
> > before uploading enterprise-certificate-proxy.
>
>
https://salsa.debian.org/go-team/packages/golang-github-google-go-pkcs11/-/merge_requests/2
>
> go-pkcs11 builds successfully and passes autopkgtest, lintian, and
> piuparts on
> both amd64 and i386.
The problem is on debci. See the failing tests at
https://ci.debian.net/packages/g/golang-github-google-go-pkcs11/
summarised also at
https://tracker.debian.org/pkg/golang-github-google-go-pkcs11
I'm aware, and the PR I've linked is a fix, please have a look.
You can look at the patch file itself at [1] (have a look at the
description to
understand what the PR/patch does).
Thanks Maytham. The patch handling it via malloc_arg makes sense.
I left a review commenting about supporting other 32 bit architectures,
not just 386 and arm.
I can see how to adapt your patch to control it at build time. Let me
know if you're happy
with that idea or if you can see another way to do it.
(an alternative could be checking bits, along the lines of
"const PtrSize = 32 << uintptr(^uintptr(0)>>63)"
But I wouldn't necessarily trust that to always give the right
indication.
Your idea of handling two separate definitions should work fine)
Drew
