Your message dated Tue, 16 Jan 2024 16:34:35 +0000
with message-id <e1rpmoz-00bpu7...@fasolo.debian.org>
and subject line Bug#1060661: fixed in netplan.io 0.107.1-2
has caused the Debian Bug report #1060661,
regarding netplan-generator: ineffective Replaces for
/usr/lib/systemd/system-generators/netplan due to /usr-move
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1060661: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060661
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: netplan-generator
Version: 0.107.1-1
Severity: serious
Justification: file loss in package upgrade
User: helm...@debian.org
Usertags: dep17p1
Control: affects -1 + netplan.io
Hi Lukas,
netplan was on my radar for /usr-merge for a while, but unfortunately I
didn't get down to it before bad things happened.
I think this is your first upload since we changed systemd.pc to point
to /usr. Earlier, netplan-generator would install
/lib/systemd/system-generators/netplan and since this upload it installs
to the same location below /usr. This wouldn't be a problem if that file
weren't installed in netplan.io in bookworm. Now upgrading from bookworm
to unstable would both move this file from / to /usr and from netplan.io
to netplan-generator. Normally, the Replaces that you declare are
sufficient, but the aliasing added by /usr-merge changes this and makes
the file subject to loss in an upgrade. For more information refer to
DEP17 P1.
You have two possible mitigations for this. The simple mitigation (DEP17
M7) is upgrading those Breaks+Replaces for netplan.io to Conflicts. This
still can cause file loss if netplan.io is being removed in an upgrade
where netplan-generator is being installed and the upgrade is being
performed with dpkg. I'd consider that relatively unlikely.
If you want to handle this case correctly, the recommended way is using
"protective diversions" (DEP17 M8). You keep Breaks+Replaces as is and
extend maintainer scripts.
netplan-generator.preinst:
dpkg-divert --no-rename --divert
/lib/systemd/system-generators/netplan.usr-is-merged --add
/lib/systemd/system-generators/netplan
netplan-generator.postinst:
dpkg-divert --no-rename --divert
/lib/systemd/system-generators/netplan.usr-is-merged --remove
/lib/systemd/system-generators/netplan
This diversion redirects the deletion of the file being replaced to a
location that does not exist and hence prevents the loss.
Beyond this, there also is an issue with /usr/lib/netplan. It is an
empty directory and since netplan.io formerly installed files to
/lib/netplan, removing netplan.io can make dpkg think that /lib/netplan
can be deleted. When it does so, it actually deletes /usr/lib/netplan
(DEP17 P6). Your options are:
* Do not install /usr/lib/netplan and make the generator work in the
absence of that directory.
* Ship a placeholder file inside.
* Have a postinst script that recreates it after loss. For this to
work, you have to install a trigger interest in /lib/netplan to make
dpkg rerun your postinst after the loss.
On top of this, none of the moves nor mitigations are applicable to
bookworm. If you plan to support backports for bookworm, you need to
ensure that such backports do not move files to /usr. It also means that
your possible M8 mitigation has to add protective diversions on every
upgrade without a version check as it could be upgrading from
bookworm-backports. Can you handle these issues?
In case you want a stop-gap measure, for now, I suggest temporarily
moving back the generator to /lib/systemd in unstable. Doing so unbreaks
the upgrade from bookworm and makes this bug non-rc, but is not a
long-term solution.
I'm happy to review a patch. Let me know if you cannot handle this and
I'll look in to preparing a NMU. If you have questions, don't hesitate
to ask.
Helmut
DEP1: https://subdivi.de/~helmut/dep17.html
--- End Message ---
--- Begin Message ---
Source: netplan.io
Source-Version: 0.107.1-2
Done: Lukas Märdian <sl...@debian.org>
We believe that the bug you reported is fixed in the latest version of
netplan.io, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1060...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lukas Märdian <sl...@debian.org> (supplier of updated netplan.io package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 16 Jan 2024 17:09:13 +0100
Source: netplan.io
Built-For-Profiles: noudeb
Architecture: source
Version: 0.107.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Netplan Maintainers <team+netp...@tracker.debian.org>
Changed-By: Lukas Märdian <sl...@debian.org>
Closes: 1058524 1060571 1060661
Launchpad-Bugs-Fixed: 1809994 1959570 2029876 2038811 2046158 2047827
Changes:
netplan.io (0.107.1-2) unstable; urgency=medium
.
* Fix my email address in d/changelog
* d/control: Add B-D to systemd-dev for systemd.pc (Closes: #1060571)
* d/patches, d/control: Avoid FTBFS on 32bit architectures, by skipping
certain unit-tests that depend on OpenVSwitch on such architectures.
* Add protective diversions for netplan-generator usrmerge (Closes: #1060661)
thanks to Helmut Grohne
* Install usr/lib/netplan/PLACEHOLDER to avoid removal of an empty
[/usr]/lib/netplan/ directory during package upgrade involving the
usrmerge transition. (See #1060661)
.
netplan.io (0.107.1-1) unstable; urgency=medium
.
[ Danilo Egea Gondolfo ]
* New upstream release: 0.107.1
- wifi: add support for WPA3-Enterprise (LP: #2029876) (!402)
- wifi: support WPA2 and WPA3 Personal simultaneously (!404)
- added mii-monitor-interval example (!411)
- docs: Add "Contribute Documentation" how-to
- auth: add support for LEAP and EAP-PWD (!415)
- tests: Add autopkgtest for (LP: #1959570) (!419)
- wifi: make it possible to have a psk and an eap password simultaneously
(!416)
- doc: Set-up some basic Doxygen project (!423)
- doc: Make Sphinx to handle autodoxygen project, using breathe (!423)
- doc: create libnetplan apidoc structure (!423)
- inc: Start documenting public API (!423)
- doc: Update 'Netplan everywhere' for 23.10 (!418)
Bug fixes:
- test:ovs: Avoid NetworkManager taking contol, breaking a test
- parse: allow COMMON_LINK_HANDLERS for VRFs (!401)
- util: don't return a placeholder netdef in the iterator (!406)
- tunnels/validation: do not error out if "local" is not defined (!407)
- tests: add some integration tests without the local address (!407)
- wireguard: ignore empty endpoints (LP: #2038811) (!414)
- parse: improve the parsing of access-points (LP: #1809994) (!413)
- wifi: replace the previously defined AP with the new one (!413)
- doc: spelling check improvements (!417)
- Fix permissions on folder '/run/NetworkManager/' (!422)
- cli:try: avoid linting error for type hints (Closes: #1058524) (!422)
- nm-parse: always read the PSK into the new psk variable (!416)
- networkd: fix formatting (!424)
- networkd: replace deprecated CriticalConnection= by KeepConfiguration=
(!424)
- networkd: move KeepConfiguration= into [Network] section
- apply: bring "lo" back up if it's managed by NM (!408)
- apply: don't assume the NM loopback connection is called "lo" (!408)
* Drop patches applied upstream
* parse-nm/wg: append the correct prefix to IPv6 addresses (LP: #2046158)
d/p/0001-parse-nm-wg-append-the-correct-prefix-to-IPv6-addres.patch
* ovs: disable StartLimitBurst in the ovs-cleanup service (LP: #2047827)
d/p/0002-ovs-disable-StartLimitBurst-in-the-ovs-cleanup-servi.patch
* d/netplan-generator.install: Update the generator installation path
due to usr-merge
.
[ Lukas Märdian ]
* debian/netplan-generator.dirs: Don't install non-usrmerge directory
* debian/rules: Clean up usrmerge quirks
Checksums-Sha1:
6bcf7789c3d38f77228e99eca087a2e9b3b6cae7 2997 netplan.io_0.107.1-2.dsc
9611967fdc384040e79aaf950646810b707cc36e 18340
netplan.io_0.107.1-2.debian.tar.xz
6e906f2a177c9dd37d5bb21b5c6ddb2a4d6d1c23 12327
netplan.io_0.107.1-2_source.buildinfo
Checksums-Sha256:
9cb0bfb5717b5190fccb98355167558ca2665a1b9678e8892044d074d968f3d0 2997
netplan.io_0.107.1-2.dsc
88b8465ec987e9685ff1a407b831656e62d194a3dba8ead1237dde754bfc0861 18340
netplan.io_0.107.1-2.debian.tar.xz
0b199f455f7f83825fcdaafe7e014bd807ff5cdee7a9fd7a24d8d7a8ce3994c9 12327
netplan.io_0.107.1-2_source.buildinfo
Files:
2f97226b2ad4bf03d49c865f8d345bfe 2997 net optional netplan.io_0.107.1-2.dsc
65a50b8a64cc1424a07100d7c6084875 18340 net optional
netplan.io_0.107.1-2.debian.tar.xz
f4f611652f819418538c62c2f4743154 12327 net optional
netplan.io_0.107.1-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE496GmCL5m2y8NfJ5v322IrMDrIsFAmWmqr8ACgkQv322IrMD
rItfZg//YtydZT8Khe8sWlfg6hqYqwP2xeDZo0vObQnENbKBdLQhcOGHFizYy+kv
ZiLm5rzqdXnVs+llKSHS8ubueedfsLhz7QMkX6amBJ2hkIALPLDwd6DgGQOsPNCT
dQkP+034mpZ/GlM5/8V7W6KkGvGRplyGlS6a3LZw2TDEYkpekmgmX/bVDWuzlCGm
smnXyOgLL/LhU/D2RhflDcnS96Hax35l5DiCb5PtoDEbxjitY/LFbOV5i+UxmV67
tkP4Lsi1vJ0pKvlF1jHSVRdMVt4PkBCeuGPDCHHlEX9QIkCi2+6wTUEnP5UXqW/x
FMNtsS+LiuGgWI1b5zWzA7qUX/8g24U1kXuOKd7tqcyk64NyDBZTMKDF2TTkLR+i
22LzpkqQ+wwigP4JNH9MjCZyA0LHwgg4Q1JW9HBqCr1HpEJmzbsz/X9OB2c6rbBX
9ZNWD9Bp81cyQjJGEBEke2dQ+c7bV7feDA4/foWuRw5mpB3rrK2q//EmLc6lCUK3
LFBO8oMCeBHkGE6M1GUUelUt4XYu/NTYuRo8TaiWQr0565oWUnwQBla6pFXrTua+
7rXyfs4HjbmO6vQjl03Z33d/v1xKs+qsfcrSVvP3qq6yhalS1wK6N32OJuyaLwvW
Pd9v2gbBIdjfmmpjmLJhDVMNVn+4evSy6+BEmKOkKTW1le590MI=
=A8En
-----END PGP SIGNATURE-----
--- End Message ---
