This one time, at band camp, Peter Eisentraut said: > A lot of packages currently code their init scripts like this: > > log_daemon_msg "Starting foo" > start-stop-daemon foo > log_end_msg $?
I would argue that this is a bug in itself. If s-s-d exits non-zero, then the script (being set -e, right? Policy and all) will exit right there and you'll never get to log_end_msg. If those scripts are set -e, then making log_end_msg return non-zero means it's just one more thing that has to be trapped for no gain. > Since log_end_msg now returns 0 always, numerous init scripts no longer > return meaningful exit codes. I think they were already broken. > I think this change needs to be reverted. You can make up a new function > if you want a different semantic. I see that the maintainer has reverted the change, but I just wanted to say why I disagree with it. Take care, -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : [EMAIL PROTECTED] | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
signature.asc
Description: Digital signature
