Hi Faidon!

On Mon, Nov 13, 2023 at 10:52:58AM +0200, Faidon Liambotis wrote:
> Upstream commit 6f8de39ยน, the only commit since 0.9.2, replaces
> sphinx.util.SphinxParallelError by sphinx.util.DownloadFiles. 
>
> I've verified that backporting this commit makes the package build
> successfully in unstable, with Sphinx 7.2.6-2.
>
> However, the very same commit changes requirements.txt from
> "Sphinx>=3.2.1" to "Sphinx<7".
>
> I'm not sure why. I'm not using, nor am I familiar with this plugin, so
> I was hoping someone else that is could perhaps validate whether besides
> being able to be built, the package actually works.
>
> 1: 
> https://github.com/mgaitan/sphinxcontrib-mermaid/commit/6f8de39a84fddc398542e9d4dc74ba55101e7d5e

The SphinxParallelError class is defined in sphinx.errors module. It was
available in sphinx.util because that module happened to import it from
sphinx.errors, but that is no longer the case since Sphinx 6.1.

Probably the author of the linked commit was testing with Sphinx 6.1 (or 6.2),
but had different problems with early Sphinx 7 versions (only Sphinx 7.0.1 was
available at that moment), so changed the dependency to <7.

The change in README.rst looks trivial, so if it helps, I would go ahead and
cherry-pick it to our packaging without the requirements.txt change.

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature

Reply via email to