Your message dated Tue, 07 Nov 2023 13:34:54 +0000 with message-id <e1r0mei-00gmvc...@fasolo.debian.org> and subject line Bug#1053265: fixed in dipy 1.7.0-4 has caused the Debian Bug report #1053265, regarding dipy: test_icm_square test fails since exact equality used with floating point numbers to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1053265: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053265 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: dipy Version: 1.7.0-2 Severity: serious Justification: debci h5py 3.9.0 is triggering an error in dipy debci tests, https://ci.debian.net/data/autopkgtest/testing/amd64/d/dipy/38279462/log.gz However from the error log, it's not clear that the problem is directly related to h5py. An exact [in]equality test is failing between floating point numbers. The error log is: 1967s _______________________________ test_icm_square ________________________________ 1967s 1967s def test_icm_square(): 1967s 1967s com = ConstantObservationModel() 1967s icm = IteratedConditionalModes() 1967s 1967s initial_segmentation = square 1967s 1967s mu, sigma = com.seg_stats(square_1, initial_segmentation, 1967s nclasses) 1967s sigmasq = sigma ** 2 1967s npt.assert_(mu[0] >= 0.0) 1967s npt.assert_(mu[1] >= 0.0) 1967s npt.assert_(mu[2] >= 0.0) 1967s npt.assert_(mu[3] >= 0.0) 1967s npt.assert_(sigmasq[0] >= 0.0) 1967s npt.assert_(sigmasq[1] >= 0.0) 1967s npt.assert_(sigmasq[2] >= 0.0) 1967s npt.assert_(sigmasq[3] >= 0.0) 1967s 1967s negll = com.negloglikelihood(square_1, mu, sigmasq, nclasses) 1967s 1967s final_segmentation_1 = np.empty_like(square_1) 1967s final_segmentation_2 = np.empty_like(square_1) 1967s 1967s beta = 0.0 1967s 1967s for i in range(max_iter): 1967s 1967s print('\n') 1967s print('>> Iteration: ' + str(i)) 1967s print('\n') 1967s 1967s final_segmentation_1, energy_1 = icm.icm_ising(negll, beta, 1967s initial_segmentation) 1967s initial_segmentation = final_segmentation_1 1967s 1967s beta = 2 1967s initial_segmentation = square 1967s 1967s for j in range(max_iter): 1967s 1967s print('\n') 1967s print('>> Iteration: ' + str(j)) 1967s print('\n') 1967s 1967s final_segmentation_2, energy_2 = icm.icm_ising(negll, beta, 1967s initial_segmentation) 1967s initial_segmentation = final_segmentation_2 1967s 1967s difference_map = np.abs(final_segmentation_1 - final_segmentation_2) 1967s > npt.assert_(np.abs(np.sum(difference_map)) != 0) 1967s E AssertionError 1967s 1967s dipy/segment/tests/test_mrf.py:370: AssertionError I'm assumung final_segmentation is floating point, not integer. Correct me if that's wrong. In general exact equality of floating point numbers should always be expected to fail. The test should be something like npt.assert_( not np.isclose( np.abs(np.sum(difference_map)), 0 ) ) If final_segmentation is an integer then of course it's a different problem.
--- End Message ---
--- Begin Message ---Source: dipy Source-Version: 1.7.0-4 Done: Andreas Tille <ti...@debian.org> We believe that the bug you reported is fixed in the latest version of dipy, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1053...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Andreas Tille <ti...@debian.org> (supplier of updated dipy package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 07 Nov 2023 14:10:28 +0100 Source: dipy Architecture: source Version: 1.7.0-4 Distribution: unstable Urgency: medium Maintainer: Debian Med Packaging Team <debian-med-packag...@lists.alioth.debian.org> Changed-By: Andreas Tille <ti...@debian.org> Closes: 1053265 Changes: dipy (1.7.0-4) unstable; urgency=medium . * Team upload. * Take over the suggested solution by Drew Parsons to avoid comparison of floating point numbers Closes: #1053265 Checksums-Sha1: a1d6b5583863ee4d1c96413dfe81003b9aff3b06 2772 dipy_1.7.0-4.dsc 9dc4fa6c1a0827d7476fe74f092bd718597582f2 17980 dipy_1.7.0-4.debian.tar.xz 4a617938d2afcc6af97bba41638f0752e62e9a8f 19968 dipy_1.7.0-4_source.buildinfo Checksums-Sha256: e5ae94ac0c330985a8a96a38660bce1ed9b2de909a6f05d1b71c7bb9d6f014d0 2772 dipy_1.7.0-4.dsc 7efae5b30a6b6394ff5177a843d114dcb2173036216f0a1f58e48ff36c4cb5e3 17980 dipy_1.7.0-4.debian.tar.xz 3adce1aded1676f4381a6e1c5e59f1d12384f45488f2226d1592fa844bf7c081 19968 dipy_1.7.0-4_source.buildinfo Files: 988c068add833fbc21ea12ce4848bb13 2772 python optional dipy_1.7.0-4.dsc 98b750c9936e7e2745dabebeb3c06dd9 17980 python optional dipy_1.7.0-4.debian.tar.xz d3cbaee5e381ed95a1d8f7bf8a95b17e 19968 python optional dipy_1.7.0-4_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAsFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmVKN4kOHHRpbGxlYUBy a2kuZGUACgkQV4oElNHGRtG5Fw//Slf0rXzkXvWyLp32TKanTnmpT2TMHwWLByB5 jvfRWanV3Pq06NnYyCEiStQJQpXIs2F9piO+VpsmbXCMXkX+qijwEtfoguftV1k1 g52ckQhF/nDGr3nMDtvQSSdCqTjRnsvGiAkYrT2ZcnwIF7B+lmhRUKd9MQPPcVeB mb3EHX2bNZO4Up9kiZ/CyPGt0BdTQXM0nAa6Kwo4Y7qPF+b/Fn2yoDi86aJjed9R Si9tywLVhbIFmoTOF5ORDDCwBRHdBDdRl8NNjONpkMcklzlrBSHlJbDD+YtH0pyE pWiZSnK93aMRP26LAIBuBkMHwU3yzSYc1xTM42Y+Yxh2+FBrJp7+RsaGkBiHikpX /pg5NcBV78UcYqTUi30GwdVfBmQi7Z13WX/aDiVT3pIzcANjPUPac6GFr9lDVcBK dsh+u7xewXuH8iDjCReLfEF0xJkKIVUwzJVV5DrAin/yFogjTD3xexbPvmxqHHxx vTqUgqh39aNXYWUIYUztylaBWuofei62fdLeaO6bgj66D8dTl/LKqtfTIHxmqvgb 9dDqZFjOhvujbdf8lI5jKfY0xYttuskbfd1hKGyJNTVyPlPTHZdJuZ+EVPrC41i5 vNzYu2FfVBZXI70bce7JU/3d/65sTKSuWXAVT0434Ky47JprJdTMPbkUvM43jkfJ NTfWEug= =HN/z -----END PGP SIGNATURE-----
--- End Message ---
