Your message dated Mon, 25 Sep 2023 22:27:33 +0000 with message-id <e1qku3b-005ppn...@fasolo.debian.org> and subject line Bug#1052548: fixed in smcroute 2.5.6-2 has caused the Debian Bug report #1052548, regarding smcroute: 'is-system-running' check in autopkgtest breaks on unrelated system changes to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1052548: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052548 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: smcroute Version: 2.5.6-1 Severity: serious Justification: stops other packages from migrating to testing Tags: patch pending X-Debbugs-Cc: pkg-systemd-maintain...@lists.alioth.debian.org Dear Maintainer(s), The autopkgtest does not actually use the systemd service, it calls the legacy script by hand. Also checking 'is-system-running' is incorrect, as that might be influenced by random unrelated fluctuations from other services, that have nothing to do with smcroute. The immediate solution is to drop the check from the test. Given this is blocking systemd from migrating to testing, high severity is set, and I have already uploaded an NMU to DELAYED/3. I have opened an MR against Salsa with the changes. Debdiff also attached. MR: https://salsa.debian.org/debian/smcroute/-/merge_requests/3 Failing log: https://ci.debian.net/data/autopkgtest/testing/amd64/s/smcroute/38108679/log.gz If you think there is a better solution please let me know and I'll cancel the deferred NMU, but we'd appreciate a swift resolution given it blocks migration. Thanks! -- Kind regards, Luca Boccassidiff -Nru smcroute-2.5.6/debian/changelog smcroute-2.5.6/debian/changelog --- smcroute-2.5.6/debian/changelog 2023-01-08 13:02:40.000000000 +0000 +++ smcroute-2.5.6/debian/changelog 2023-09-24 13:34:21.000000000 +0100 @@ -1,3 +1,10 @@ +smcroute (2.5.6-1.1) unstable; urgency=medium + + * Non-maintainer upload. + * autopkgtest: drop is-system-running check (Closes: #) + + -- Luca Boccassi <bl...@debian.org> Sun, 24 Sep 2023 13:34:21 +0100 + smcroute (2.5.6-1) unstable; urgency=medium * New upstream version 2.5.6. diff -Nru smcroute-2.5.6/debian/tests/daemon-init-scripts smcroute-2.5.6/debian/tests/daemon-init-scripts --- smcroute-2.5.6/debian/tests/daemon-init-scripts 2021-09-25 13:28:23.000000000 +0100 +++ smcroute-2.5.6/debian/tests/daemon-init-scripts 2023-09-24 13:34:21.000000000 +0100 @@ -28,7 +28,7 @@ return $smcroute_pid; } -plan tests => 13; +plan tests => 11; # Work around test harness, start smcrouted if not already running my $startup = capture EXIT_ANY, INIT_SCRIPT, 'start'; @@ -43,11 +43,6 @@ is $EXITVAL, 0, "stopping smcroute"; my $smcroute_pid = get_smcrouted_pid 'stopped'; is $EXITVAL, 1, "smcroute is really stopped".( $EXITVAL ? '' : " (pid $smcroute_pid)" ); -SKIP: { - skip "System not managed by systemd", 1 unless -e '/run/systemd/system'; - my $wait_output = capture EXIT_ANY, 'systemctl', 'is-system-running', '--wait'; chomp $wait_output; - is $wait_output, "running", "Stopping smcroute completed"; -} my $double_stop_output = capture EXIT_ANY, INIT_SCRIPT, 'stop'; is $EXITVAL, 0, "stopping smcroute twice in a row"; @@ -57,11 +52,6 @@ # Try to start the daemon again my $start_output = capture EXIT_ANY, INIT_SCRIPT, 'start'; is $EXITVAL, 0, "starting smcroute"; -SKIP: { - skip "System not managed by systemd", 1 unless -e '/run/systemd/system'; - my $wait_output = capture EXIT_ANY, 'systemctl', 'is-system-running', '--wait'; chomp $wait_output; - is $wait_output, "running", "Starting smcroute completed"; -} my $new_smcroute_pid = get_smcrouted_pid 'running'; is $EXITVAL, 0, "smcroute is really running".( $EXITVAL ? '' : " (pid $new_smcroute_pid)" ); isnt $new_smcroute_pid, $initial_smcroute_pid, "smcroute pid changed ($new_smcroute_pid != $initial_smcroute_pid)";
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---Source: smcroute Source-Version: 2.5.6-2 Done: Micha Lenk <mi...@debian.org> We believe that the bug you reported is fixed in the latest version of smcroute, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1052...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Micha Lenk <mi...@debian.org> (supplier of updated smcroute package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 25 Sep 2023 23:58:00 +0200 Source: smcroute Architecture: source Version: 2.5.6-2 Distribution: unstable Urgency: medium Maintainer: Micha Lenk <mi...@debian.org> Changed-By: Micha Lenk <mi...@debian.org> Closes: 1052548 Changes: smcroute (2.5.6-2) unstable; urgency=medium . [ Micha Lenk ] * Drop dependency on lsb-base (>= 3.0-6). Thanks to Lintian for flagging this as obsolete. . [ Luca Boccassi ] * Non-maintainer upload. * autopkgtest: drop is-system-running check (Closes: #1052548) Checksums-Sha1: b5dafe56151d8710b504ee93608ae017bcff9379 2042 smcroute_2.5.6-2.dsc 72162424c38cced336a1776bd3f8f227f8ff971d 10136 smcroute_2.5.6-2.debian.tar.xz 2f7c917ee493d0fb88f7c54cae185a81f7bf85a4 6749 smcroute_2.5.6-2_source.buildinfo Checksums-Sha256: 38215292112d582163edef337b19fcdefb169749f7d65db2f2eba50af8d88b97 2042 smcroute_2.5.6-2.dsc edfb92d986220bd83f8822d2f3cad96e8ee249c8f4631823ede7898d856e1b96 10136 smcroute_2.5.6-2.debian.tar.xz b1634c4c8919946ab7892153b1d98071e98d735ac70ca8caf2b01a17a89b68c0 6749 smcroute_2.5.6-2_source.buildinfo Files: 5a1ea685e1e087daf5c6eaf674c53821 2042 net optional smcroute_2.5.6-2.dsc 0ba9d0339ae1ae3ee0babe4819a22f4f 10136 net optional smcroute_2.5.6-2.debian.tar.xz 6d58a34536ce18d962d83973e7e80f5b 6749 net optional smcroute_2.5.6-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEo+u0H8Wr1nXO5BxF6mymuVG4UTkFAmUSAvwACgkQ6mymuVG4 UTmx5hAArw8a8pRTUC2Vm9uZDjpslDgBLtatx+VnI1jbEcmelHhG4ttBNf2piQg7 993xUcU/RM3w9DtderR2sUYd6sof0F/7dARsYH76a487lwIk46YGuC5fS93SkOVR KAR48pY5GbIlD5E8qz6h9HHN0c4ftlAmqO4OcqqECN354eAwj81nFJFjt6mwRXph T+u7HA8ork2i6xV69JHskFS0jTPP8Fj3XAv/C2NA6R+/zD8JT5i987IPNBnfrgL5 UtT9mLpr5zYiV9jEIY72tZ9kpm2fX5ZlUdduI6mfhcAhBMFeFoWDZHKu0p/Ot6nT q150UZ9auiQaGCZ4CnAUzZ3B63jUtLDL1JVBxwD0A/mQfm0yse6FOVT/9lNK+Rl5 IrB9b2zNLzl85xozf9Pm5DhbsuWtxV7im3S2iDJuUaC957tddksZ04glq7FkKT2n LSss59JhIfK2Rzh1+3dG7VmzdXFjPBZfYM6bHmHog0X3c4JzOOZVZFQiR9uQdURg 6IVJeInKF0EPuKbRuJFi3q6V6c8boHmN2QvmXSkFyDfRIYgMf30O5kGJxrFM0Qxm 61I4HGL76fiQH3NXr2+WLdxwRoxr7aQLLxmQ6uC64mRDFUZVFShT59TZh3Zsr0OH MIO+miFnCNjrPVWwg/7QQCHL/dHRDpwQ8XIF7jLl0erYeFsaR2E= =QfTM -----END PGP SIGNATURE-----
--- End Message ---
