Your message dated Mon, 24 Jul 2023 20:40:33 +0000 with message-id <e1qo2m5-00dcud...@fasolo.debian.org> and subject line Bug#1041808: fixed in cura-engine 1:5.0.0-4 has caused the Debian Bug report #1041808, regarding cura-engine: Several unit test failures on i686 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1041808: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041808 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: cura-engine Version: 5.0.0-1 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) Usertags: i686 Forwarded: https://github.com/Ultimaker/CuraEngine/issues/1192 X-Debbugs-Cc: onit...@gmail.com On i686, CuraEngine 5.x fails to build due to failing unit tests. This is a longstanding issue, going back to 4.4, where it was fixed by adding a larger tolerance to test values. However, the issue was not investigated thoroughly and returns in 5.0 with more failing unit tests. The root cause of these failures are rounding errors on i686, where the x87 FPU produces different results than floating point units in other processors. These differences are tiny, and usually not more than a few ULPs. CuraEngine uses integer math in most places, but resorts to double-precision floating-point calculations in certain cases. Afterwards, the results are truncated to 64-bit integers (C type long long), and subsequent calculation is done on the integer values. Truncation (aka round-toward-zero) is often ok and works fine on amd64 (SSE2 floating-point math) and other CPUs, but produces different results on the x87 FPU. When truncating, these produce off-by-one errors in many cases, and the these errors can accumulate and lead to huge differences in the unit tests. By strategically adding explicit rounding (round-to-nearest) in the right places, these errors can be eliminated. While this will produce subtly different results in some cases, it is arguably more correct than always truncating. And at least on amd64, there is no performance difference between truncation and rounding: The SSE2 CVTTSD2SI and CVTSD2SI instructions have the same performance. -- System Information: Debian Release: trixie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (300, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.3.0-2-amd64 (SMP w/4 CPU threads; PREEMPT) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled -- no debconf information
--- End Message ---
--- Begin Message ---Source: cura-engine Source-Version: 1:5.0.0-4 Done: Gregor Riepl <onit...@gmail.com> We believe that the bug you reported is fixed in the latest version of cura-engine, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1041...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Gregor Riepl <onit...@gmail.com> (supplier of updated cura-engine package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 24 Jul 2023 22:09:39 +0200 Source: cura-engine Architecture: source Version: 1:5.0.0-4 Distribution: unstable Urgency: medium Maintainer: Debian 3-D Printing Packages <3dprinter-gene...@lists.alioth.debian.org> Changed-By: Gregor Riepl <onit...@gmail.com> Closes: 1037614 1040252 1040806 1041808 Changes: cura-engine (1:5.0.0-4) unstable; urgency=medium . * Fix failing unit test. Closes: #1040252 * Fix gcc-13 compatibility. Closes: #1037614 * Fix errors with obsolete adhesion_extruder_nr parameter. Thanks to Dan Bungert (Canonical) for reporting this. Closes: #1040806 * Fix rounding errors on i686. Closes: #1041808 * Drop previous patch for rounding errors. It's covered by the round error fix. Checksums-Sha1: 466bf7c7a944b02c7373af4afd2fab004e56305c 2202 cura-engine_5.0.0-4.dsc 1315c9fb0c2bda3ccbb8f8801a75a4b3cb2e3a08 67960 cura-engine_5.0.0-4.debian.tar.xz Checksums-Sha256: c7d26645d858ecb59241911c5e4e9818530bdac88e3825e837c51da5236637c7 2202 cura-engine_5.0.0-4.dsc def98284108caf71f50403cd9c8c9aedee22012f859c0c35bda5d771a003e5e8 67960 cura-engine_5.0.0-4.debian.tar.xz Files: 7440b8e4397b19b37a18d98dacdf3b88 2202 utils optional cura-engine_5.0.0-4.dsc 443631b854047125c2ed074e24980a9a 67960 utils optional cura-engine_5.0.0-4.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEXEj+YVf0kXlZcIfGTFprqxLSp64FAmS+2+YACgkQTFprqxLS p64kLxAApgPNHf4TkeVxxS2XpURBv8q4XqFMzh4hpOFsplreZ7nq71HUAnfjR0Sj PTq1gl+KakTud+4t+1OjRzMl8GTeqWGKP4hOxYzmMyK3iEdzFuA7f3Js0pwNpFIu 0OQduU63kG2W1WjXpPNEWsog+sTWVdpALvXx77S2P4VXFZ++nYBgqROjQA2vpzIt wXiDXAHXYPfFRCHT3kGjOYZQwlaENQt5TR0mb2Y4Ht2Vl/iQJtSO6gF9m+dehSd7 yzam//urohzdNM824yxWZxa6KKEiwCX/ybGOD1dx2DcfG7wcxijcIK3kgiQeZfoH oTsm3d/5NgRvilCyHxgWquC8bgmwtYS5VuRAilJ1m+d36x8TbJLEsJaCdt8MBMZD 3e33jcYZctcXtdxBDF8klGLZ9UfEfJnsWTlRZJCpUSWz4D6go126TFQxhdr25/af Xd1kHr9PfJHjMbuVFlqBIWtdRsABrd41VdHH+A5XDEpgNzP/ICUGVm4s58mTwFfG e6qFfY/XhjSLMPmIBH0buqvRNymT1JzsopZcZ6j4spR1/vlALWRJWaKVOpIZmW5r SO+E3n6HhKeYFpFLXtn9vyZVgVyCZTcDiIRbjECXxdyPqLRxJ0s9VzG8zEB5FXZp bwfo223J3Xm155eWi9R+Zm1PytSbNqMy+SLfXFvJoOPv9H7JQIo= =IRhX -----END PGP SIGNATURE-----
--- End Message ---
