Your message dated Fri, 12 May 2023 11:49:07 +0000
with message-id <e1pxrgl-00dw7h...@fasolo.debian.org>
and subject line Bug#1035961: fixed in cinder 2:21.1.0-3
has caused the Debian Bug report #1035961,
regarding CVE-2023-2088 / OSSA-2023-003: Unauthorized volume access through
deleted volume attachments
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1035961: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035961
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: python-os-brick
Version: 6.2.0-1
Severity: grave
============================================================================
OSSA-2023-003: Unauthorized volume access through deleted volume attachments
============================================================================
:Date: May 10, 2023
:CVE: CVE-2023-2088
Affects
~~~~~~~
- Cinder: <20.2.1, >=21.0.0 <21.2.1, ==22.0.0
- Glance_store: <3.0.1, >=4.0.0 <4.1.1, >=4.2.0 <4.3.1
- Nova: <25.1.2, >=26.0.0 <26.1.2, ==27.0.0
- Os-brick: <5.2.3, >=6.0.0 <6.1.1, >=6.2.0 <6.2.2
Description
~~~~~~~~~~~
An unauthorized access to a volume could occur when an iSCSI or FC
connection from a host is severed due to a volume being unmapped on
the storage system and the device is later reused for another volume
on the same host.
**Scope:** Only deployments with iSCSI or FC volumes are affected.
However, the fix for this issue includes a configuration change in
Nova and Cinder that may impact you on your next upgrade regardless
of what backend storage technology you use. See the *Configuration
change* section below, and item 4(B) in the *Patches and Associated
Deployment Changes* for details.
This data leak can be triggered by two different situations.
**Accidental case:** If there is a problem with network connectivity
during a normal detach operation, OpenStack may fail to clean the
situation up properly. Instead of force-detaching the compute node
device, Nova ignores the error, assuming the instance has already
been deleted. Due to this incomplete operation OpenStack may end up
selecting the wrong multipath device when connecting another volume
to an instance.
**Intentional case:** A regular user can create an instance with a
volume, and then delete the volume attachment directly in Cinder,
which neglects to notify Nova. The compute node SCSI plumbing (over
iSCSI/FC) will continue trying to connect to the original
host/port/LUN, not knowing the attachment has been deleted. If a
subsequent volume attachment re-uses the host/port/LUN for a
different instance and volume, the original instance will gain
access to it once the SCSI plumbing reconnects.
Configuration Change
--------------------
To prevent the intentional case, the Block Storage API provided by
Cinder must only accept attachment delete requests from Nova for
instance-attached volumes. A complicating factor is that Nova
deletes an attachment by making a call to the Block Storage API on
behalf of the user (that is, by passing the user's token), which
makes the request indistinguishable from the user making this
request directly. The solution is to have Nova include a service
token along with the user's token so that Cinder can determine that
the detach request is coming from Nova. The ability for Nova to pass
a service token has been supported since Ocata, but has not been
required until now. Thus, deployments that are not currently sending
service user credentials from Nova will need to apply the relevant
code changes and also make configuration changes to solve the
problem.
Patches and Associated Deployment Changes
-----------------------------------------
Given the above analysis, a thorough fix must include the following
elements:
1. The os-brick library must implement the ``force`` option for
fibre channel, which which has only been available for iSCSI
until now (covered by the linked patches).
2. Nova must call os-brick with the ``force`` option when
disconnecting volumes from deleted instances (covered by the
linked patches).
3. In deployments where Glance uses the cinder glance_store driver,
glance must call os-brick with the ``force`` option when
disconnecting volumes (covered by the linked patches).
4. Cinder must distinguish between safe and unsafe attachment delete
requests and reject the unsafe ones. This part of the fix has two
components:
a. The Block Storage API will return a 409 (Conflict) for a
request to delete an attachment if there is an instance
currently using the attachment, **unless** the request is
being made by a service (for example, Nova) on behalf of a
user (covered by the linked patches).
b. In order to recognize that a request is being made by a
service on behalf of a user, Nova must be configured to send a
service token along with the user token. If this configuration
change is not made, the cinder change will reject **any**
request to delete an attachment associated with a volume that
is attached to an instance. Nova must be configured to send a
service token to Cinder, and Cinder must be configured to
accept service tokens. This is described in the following
document and **IS NOT AUTOMATICALLY APPLIED BY THE LINKED
PATCHES:** (Using service tokens to prevent long-running job
failures)
https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html
The Nova patch mentioned in step 2 includes a similar document
more focused on Nova:
doc/source/admin/configuration/service-user-token.rst
5. The cinder glance_store driver does not attach volumes to
instances; instead, it attaches volumes directly to the Glance
node. Thus, the Cinder change in step 4 will recognize an
attachment-delete request coming from Glance as safe and allow
it. (Of course, we expect that you will have applied the patches
in steps 1 and 3 to your Glance nodes.)
Errata
~~~~~~
An additional nova patch is required to fix a minor regression in periodic
tasks and some nova-manage actions (errata 1). Also a patch to tempest is
needed to account for behavior changes with fixes in place (errata 2).
Patches
~~~~~~~
- https://review.opendev.org/882836 (2023.1/antelope cinder)
- https://review.opendev.org/882851 (2023.1/antelope glance_store)
- https://review.opendev.org/882858 (2023.1/antelope nova)
- https://review.opendev.org/882859 (2023.1/antelope nova errata 1)
- https://review.opendev.org/882843 (2023.1/antelope os-brick)
- https://review.opendev.org/882835 (2023.2/bobcat cinder)
- https://review.opendev.org/882834 (2023.2/bobcat glance_store)
- https://review.opendev.org/882847 (2023.2/bobcat nova)
- https://review.opendev.org/882852 (2023.2/bobcat nova errata 1)
- https://review.opendev.org/882840 (2023.2/bobcat os-brick)
- https://review.opendev.org/882876 (2023.2/bobcat tempest errata 2)
- https://review.opendev.org/882869 (Wallaby nova)
- https://review.opendev.org/882870 (Wallaby nova errata 1)
- https://review.opendev.org/882839 (Xena cinder)
- https://review.opendev.org/882855 (Xena glance_store)
- https://review.opendev.org/882867 (Xena nova)
- https://review.opendev.org/882868 (Xena nova errata 1)
- https://review.opendev.org/882848 (Xena os-brick)
- https://review.opendev.org/882838 (Yoga cinder)
- https://review.opendev.org/882854 (Yoga glance_store)
- https://review.opendev.org/882863 (Yoga nova)
- https://review.opendev.org/882864 (Yoga nova errata 1)
- https://review.opendev.org/882846 (Yoga os-brick)
- https://review.opendev.org/882837 (Zed cinder)
- https://review.opendev.org/882853 (Zed glance_store)
- https://review.opendev.org/882860 (Zed nova)
- https://review.opendev.org/882861 (Zed nova errata 1)
- https://review.opendev.org/882844 (Zed os-brick)
Credits
~~~~~~~
- Jan Wasilewski from Atman (CVE-2023-2088)
- Gorka Eguileor from Red Hat (CVE-2023-2088)
References
~~~~~~~~~~
- https://launchpad.net/bugs/2004555
- http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-2088
Notes
~~~~~
- Limited Protection Against Accidents... If you are only concerned with
protecting against the accidental case described earlier in this document,
steps 1-3 above should be sufficient. Note, however, that only applying steps
1-3 leaves your cloud wide open to the intentional exploitation of this
vulnerability. Therefore, we recommend that the full fix be applied to all
deployments.
- Using Configuration as a Short-Term Mitigation... An alternative approach to
mitigation can be found in OSSN-0092
https://wiki.openstack.org/wiki/OSSN/OSSN-0092
- The stable/xena and stable/wallaby branches are under extended maintenance
and will receive no new point releases, but patches for them are provided as
a courtesy where available.
OSSA History
~~~~~~~~~~~~
- 2023-05-10 - Errata 2
- 2023-05-10 - Errata 1
- 2023-05-10 - Original Version
--
Jeremy Stanley
OpenStack Vulnerability Management Team
--- End Message ---
--- Begin Message ---
Source: cinder
Source-Version: 2:21.1.0-3
Done: Thomas Goirand <z...@debian.org>
We believe that the bug you reported is fixed in the latest version of
cinder, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1035...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Goirand <z...@debian.org> (supplier of updated cinder package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 12 May 2023 12:38:22 +0200
Source: cinder
Architecture: source
Version: 2:21.1.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <team+openst...@tracker.debian.org>
Changed-By: Thomas Goirand <z...@debian.org>
Closes: 1035961
Changes:
cinder (2:21.1.0-3) unstable; urgency=medium
.
* CVE-2023-2088: Unauthorized volume access through deleted volume
attachments. Applied upstream patch: Reject unsafe delete attachment calls
(Closes: #1035961).
Checksums-Sha1:
70168d1a0d62824e320df977445b7d27c05a1da1 4406 cinder_21.1.0-3.dsc
aaceb96f16209ce9e3908a41e8aa5e014f4bc800 56932 cinder_21.1.0-3.debian.tar.xz
12fde557bdab4b50aaf0afff7105073b4eaddc9f 19838 cinder_21.1.0-3_amd64.buildinfo
Checksums-Sha256:
0c5f84139b18b268f873b0b2f622638d891630865484e93d353ef1f925b7af5c 4406
cinder_21.1.0-3.dsc
d748a158519f2e030dc415b1642694790afb79cc02edbf213ffdf3c06358998c 56932
cinder_21.1.0-3.debian.tar.xz
e5b35dbc8ac52bde1290c5087c726106d01c36383d344d848dae547b1bb33f6c 19838
cinder_21.1.0-3_amd64.buildinfo
Files:
c1617c2250d1e7d85bb1f75b6cf26934 4406 net optional cinder_21.1.0-3.dsc
65dfc1f17bca810864cd6daedc288553 56932 net optional
cinder_21.1.0-3.debian.tar.xz
7e4878c4023fdee81d6c631e81c31604 19838 net optional
cinder_21.1.0-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmReItoACgkQ1BatFaxr
Q/4YKhAAnxx8/Jrp2wVyIJ4UAzl3IpECizRk7to2AAFBHG5RMXQYu7h77LCZ5kBg
cFCvXsqfUywhqsjB13eAtteOwjO0tN6qnSlEjNXOH+NX1LOXpUkl4yf88UR546IT
oiQtf5yzX/EieTSR1+83iez5K+BymNEAo4LKnKeBO4JxD6ZiaFB31ogN/YIW5xNa
rpgAwHSjFpX/LRuQrmXy6GA/EEa4gh6kITDV40HtX2BPXOzn7HJrH2FGIX9BPbZc
9AWOUiny1DtnF0LeAnABAjRLetYZnYQsE78cEIKA5iD10vXI0h55ZxubvEJiG1Bb
x9wLaMMvZ4sZI0M5oTPyYVf+XKUhFnesOr/fqdISZkgL/C4IC2leQajnzSv3wDfa
pP+bqgOhlbTA0/VCBSjoGCN/eIu8mRmucIXvXOCoWPmBLYJM4ZbnqbpeOAUlMBwK
shPDCvqPQVdU+nZyO+EW1M0L3DvpkCxyN252kZUZLr4NAjEykIaPEpcAQjz/4Vnw
8Va3fTeWg5GPmgRPhv25vLnviBlLf1MucM/EIfAnqnC5S4dXAaDwiUGMWTgeG5aT
Tr93ZlAGzY31B58zKrZkUL93bamFxDXiNdo4iIrN7DW7Tt0jwSreUylq/paDoHrW
hanhY9taJlah/lV7ceRNKKOV371R9BBs9xx54hQlol7zCQ2IVCM=
=4o2I
-----END PGP SIGNATURE-----
--- End Message ---
