Michael Prokop <m...@debian.org> writes: > * Arto Jantunen [Wed Apr 19, 2023 at 07:49:33PM +0300]: > >> The package fails to import under Python 3.11 with the following traceback: >> Traceback (most recent call last): > [...] >> File "/usr/lib/python3/dist-packages/sqlacodegen/main.py", line 10, in >> <module> >> from sqlacodegen.codegen import CodeGenerator >> File "/usr/lib/python3/dist-packages/sqlacodegen/codegen.py", line 4, in >> <module> >> from inspect import ArgSpec >> ImportError: cannot import name 'ArgSpec' from 'inspect' >> (/usr/lib/python3.11/inspect.py) >> >> The issue seems to have been fixed in the latest release candidate, but that >> isn't really suitable for bookworm during the freeze, so the intent of this >> bug is to cause the package to be dropped from the release. > > If you don't want to maintain this package or its 1.1.6 version > within bookworm then nevermind my comment :) - but looking at > https://github.com/agronholm/sqlacodegen/issues/239#issuecomment-1457728533 > the fix for this *might* be as simple as replacing: > > from inspect import ArgSpec > > with: > > from inspect import FullArgSpec > > Also see https://docs.python.org/3/whatsnew/changelog.html + > https://docs.python.org/3/library/inspect.html#inspect.getfullargspec > > But given that v1.1.6 was released on 2015-05-15 and not updated > within Debian since then, while upstream relased multiple stable > versions like e.g. v2.3.0 on 2020-07-13, I'd understand your > reasoning to drop this package at least for bookworm. :)
Even after patching those and a few smaller issues the upstream testsuite still doesn't pass (seems like a difference in how it expects sqlalchemy to behave, so probably related to the version bookworm has of that). I could skip the test or patch it to pass, but.. I think it's simply too late now, and would just let the package get autoremoved. I plan to upload the latest upstream RC (which I think should work with Python 3.11) to unstable after that has happened. -- Arto Jantunen
