Hi Thomas, Thank you very much for the patch! It makes the snack package build just fine. I'll do some testing and upload the fixed package shortly! As far as I can tell, there's still time for it to make bookworm (Debian 12).
On Sun, Feb 19, 2023 at 12:12 AM Thomas Uhle <thomas.u...@mailbox.tu-dresden.de> wrote: > > Dear maintainers, > > I would very much appreciate if this package would be kept in Debian. > That is why I've had a look into the source code and have seen that there > is yet another implementation for a downsampler in jkGetF0.c that is not > proprietary code. And so I was thinking what is good enough to be used > for the estimation of the first formant F0, cannot be bad for doing the > computation to estimate all the others. However, in contrast to the code > from downsample.c, this other downsampler is not using 16-bit integer > values but it is a floating-point implementation. So it is not a drop-in > replacement and I had to rewrite large portions of the two functions > Fdownsample() and highpass(). I also had to make the function do_ffir() > public to be used by the highpass filter implementation and to uncomment > and fix some code in it that was headlined by /* never used */ but is > needed to make the highpass filter implementation working again. > > Long story short, there is a patch attached to this e-mail that I grant > under the license of either GPL2+ (like it is used for the whole project > snack) or BSD (like it is said to be in the headers of jkFormant.c and > jkGetF0.c), whatever suits you, in the hope to save this package from > being dropped. > I have attached two versions of it because I don't know whether the 170 > lines of conflicting proprietary code have to be removed before or can be > replaced by the patch. So applying remove_downsample.c.diff removes the > conflicting lines from jkFormant.c, formant.patch is the actual fix to > make the implementation work again, and formant2.patch is a combination > of both. > > I hope it is not too late. > > Best regards, > > Thomas Uhle -- Sergei Golovan
