Your message dated Thu, 16 Feb 2023 20:42:52 +0000
with message-id <e1psl5g-00gnja...@fasolo.debian.org>
and subject line Bug#1031394: fixed in snappy 1.1.9-3
has caused the Debian Bug report #1031394,
regarding Please re-enable RTTI support in Sid/Bookworm, needed by at least Ceph
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1031394: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031394
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libsnappy1v5
Version: 1.1.8-1
Severity: grave
Tags: patch
Dear Laszlo,
During my tests with Ceph, I noticed a grave regression: Ceph OSD (the process
that does the actual storage for Ceph) cannot use Snappy anymore, because it
can't find one symbole related to RTTI.
The consequence is that it cannot load and use Snappy. This may be ok for newer
clusters, but when upgrading from a cluster let's say in Bullseye, this may be
desastrous: data wont be able to be unpacked, which means data loss.
Please find attached a very small patch to re-enable RTTI support in Ceph.
Note related upstream bug in Ceph:
https://tracker.ceph.com/issues/53060
Moving forward, what I propose is probably the easiest way forward, at least
for Ceph. Doing extra patching of the Ceph would be a way more hazardous.
Your thoughts?
Cheers,
Thomas Goirand (zigo)
diff -Nru snappy-1.1.9/debian/changelog snappy-1.1.9/debian/changelog
--- snappy-1.1.9/debian/changelog 2022-05-08 18:26:22.000000000 +0000
+++ snappy-1.1.9/debian/changelog 2023-02-16 12:37:39.000000000 +0000
@@ -1,3 +1,10 @@
+snappy (1.1.9-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Re-enable RTTI support.
+
+ -- Thomas Goirand <z...@debian.org> Thu, 16 Feb 2023 12:37:39 +0000
+
snappy (1.1.9-2) unstable; urgency=medium
* Upload to Sid.
diff -Nru snappy-1.1.9/debian/patches/re-enable-rtti-support.patch
snappy-1.1.9/debian/patches/re-enable-rtti-support.patch
--- snappy-1.1.9/debian/patches/re-enable-rtti-support.patch 1970-01-01
00:00:00.000000000 +0000
+++ snappy-1.1.9/debian/patches/re-enable-rtti-support.patch 2023-02-16
12:37:39.000000000 +0000
@@ -0,0 +1,29 @@
+Description: Re-enable RTTI support
+Author: Thomas Goirand <z...@debian.org>
+Forwarded: no
+Last-Update: 2023-02-16
+
+--- snappy-1.1.9.orig/CMakeLists.txt
++++ snappy-1.1.9/CMakeLists.txt
+@@ -51,10 +51,6 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC"
+ string(REGEX REPLACE "/EH[a-z]+" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHs-c-")
+ add_definitions(-D_HAS_EXCEPTIONS=0)
+-
+- # Disable RTTI.
+- string(REGEX REPLACE "/GR" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /GR-")
+ else(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+ # Use -Wall for clang and gcc.
+ if(NOT CMAKE_CXX_FLAGS MATCHES "-Wall")
+@@ -76,10 +72,6 @@ else(CMAKE_CXX_COMPILER_ID STREQUAL "MSV
+ # Disable C++ exceptions.
+ string(REGEX REPLACE "-fexceptions" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")
+-
+- # Disable RTTI.
+- string(REGEX REPLACE "-frtti" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")
+ endif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+
+ # BUILD_SHARED_LIBS is a standard CMake variable, but we declare it here to
make
diff -Nru snappy-1.1.9/debian/patches/series snappy-1.1.9/debian/patches/series
--- snappy-1.1.9/debian/patches/series 2021-12-04 18:21:57.000000000 +0000
+++ snappy-1.1.9/debian/patches/series 2023-02-16 12:37:39.000000000 +0000
@@ -4,3 +4,4 @@
0001-Add-inline-with-SNAPPY_ATTRIBUTE_ALWAYS_INLINE.patch
use_packaged_testing.patch
correct_testing_link.patch
+re-enable-rtti-support.patch
--- End Message ---
--- Begin Message ---
Source: snappy
Source-Version: 1.1.9-3
Done: Laszlo Boszormenyi (GCS) <g...@debian.org>
We believe that the bug you reported is fixed in the latest version of
snappy, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1031...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <g...@debian.org> (supplier of updated snappy package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 16 Feb 2023 20:31:32 +0100
Source: snappy
Architecture: source
Version: 1.1.9-3
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
Changed-By: Laszlo Boszormenyi (GCS) <g...@debian.org>
Closes: 1031394
Changes:
snappy (1.1.9-3) unstable; urgency=medium
.
* Add option to enable rtti, set default to current behavior.
* Enable rtti support (closes: 1031394).
* Update Standards-Version to 4.6.2 .
Checksums-Sha1:
940dc0ebcd66152717bdae22e0b9a64016be25e3 1842 snappy_1.1.9-3.dsc
aa0f631f599416babb5305215dda3d6d89d2a410 16852 snappy_1.1.9-3.debian.tar.xz
Checksums-Sha256:
7651f9ca32704e95b17e3d288858c374dad88a0d4f95fc6a04a96bc7b83c8e7e 1842
snappy_1.1.9-3.dsc
78d8c910467ab2b8c7434a200167ba9cae7b7ade6f931bf7c8ea3f2fcc50e4af 16852
snappy_1.1.9-3.debian.tar.xz
Files:
a9a9feb4602a23083aeac026c17480e3 1842 libs optional snappy_1.1.9-3.dsc
45eea1ef8b6544b0f1cc85de3832dea0 16852 libs optional
snappy_1.1.9-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAmPujAcACgkQ3OMQ54ZM
yL/a0w/9H+TOr1ZtRp13MwLvEZkQMgpSi6GyW4zYEV1xppga3FW6BBufrxZU3gbI
vLyGsLM5WIvH286BYoNwzuKaS0/RsJlnWFhmQ65mztVZkLU8jJaANz4ywa6ybPkX
zGLvk1yN6rBot+uSpGB1sBwYpnIZY4GZMu0/RL48AYFz8qiJdHeEX4uBWI7sonKR
IPYBPC9iWz2JxyY4yRSuMxlTfErIDBzXvd/poUV5aMlRy4VpwGXp0rX0juxTy1od
a9muu5cFSMBKA2XOqAClBEhMpZKwwy20XoemVoyyGwrEgOH1wr72DGfViKlZ80wf
Cj3Y4Mk219KUwZAmBzWlbAdNGodmlLL9LA/YkLqbXBlsGcS4MQHKq86zaBnR8Htk
M4ILjQJF+42Pi5k4GW3TcgYIqUNgDjJusId4amwAUxY+2PoRcUpaaRyZdGK0a/iD
NasDxNaY8fzG/gPfIsdYjSHHssKsxMDf3r+YgMAilAntymEBQqTnKEG2M/fwbnAm
DBQatzhyund6N0U6FvPihq6G9QFY6bMPqk5oBKoOpeHcF/YcBRkQAh5pHiQC1iiA
gj8g6sqhGr1KJsEZBTXO1bOW6PDqCt+98FYXrufWuBUXUp/2YfCgOdZK0S9CGaz4
ZYOzdY+cjgz7d/DZpFQDcU2ee9TYO5bylwhune13RhIe09xe1vQ=
=gc1A
-----END PGP SIGNATURE-----
--- End Message ---
