On Sun, 12 Feb 2023 14:18:53 +0100, Roland Rosenfeld wrote: > > > If I remove the new *DEPRECAT* macros from the generated > > > curlopt-constants.c > > > after `perl Makefile.PL' and before `make', we get a bit further > > I'm not fully sure how to do this (seems it should be possible to > > realize this by patching Makefile.PL). > I found a way to do so by patching Makefile.PL now (there were former > debian patches doing the same for other macros, as far as I see).
Nice! > > > In file included from /usr/include/x86_64-linux-gnu/curl/curl.h:3195: > > > Curl.xs:692:25: error: void value not ignored as it ought to be > > > 692 | curl_easy_setopt(clone->curl, 10000 + i, > > > clone->strings[i]); > > This one can be worked around using > > WWW-Curl-4.17-Work-around-a-macro-bug-in-curl-7.87.0.patch from > > https://rt.cpan.org/Public/Bug/Display.html?id=145992 Ah, right. > I pushed two commits with these two patches to salsa now. > Since I'm not very familiar with this, someone else should have a look > at this before a new upload, but the package builds now and > autopkgtest also runs okay on the result... I had a brief look now, and while I can't claim to be an expert with this package, this all looks reasonable to me. I also ran the tests that we usually skip (because they need internet access), and they pass (with one change of a URL); this might give us additional confidence … Maybe give it another day or two to see if someone else can take a look, and then I guess you can go ahead and upload. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `-
signature.asc
Description: Digital Signature
