Your message dated Mon, 23 Jan 2023 20:55:19 +0000 with message-id <e1pk3qz-0053ty...@fasolo.debian.org> and subject line Bug#1001653: fixed in aribas 1.65-1 has caused the Debian Bug report #1001653, regarding aribas: autopkgtest fails with glibc >= 2.33: stack smashing detected to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1001653: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001653 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: aribas Version: 1.64-6 Severity: serious Tags: patch upstream Dear maintainer, The aribas autopkgtests fails when run on an i386 system with glibc 2.33 installed. Here is the relevant part of the tests: | Preparing to unpack .../aribas_1.64-6_i386.deb ... | Unpacking aribas (1.64-6) ... | Setting up aribas (1.64-6) ... | Setting up autopkgtest-satdep (0) ... | (Reading database ... 13148 files and directories currently installed.) | Removing autopkgtest-satdep (0) ... | autopkgtest [21:14:39]: test upstream: [----------------------- | *** stack smashing detected ***: terminated | Aborted | autopkgtest [21:14:40]: test upstream: -----------------------] | autopkgtest [21:14:40]: test upstream: - - - - - - - - - - results - - | - - - - - - - - | upstream FAIL non-zero exit status 1 | autopkgtest [21:14:40]: test upstream: - - - - - - - - - - stderr - - - | - - - - - - - | *** stack smashing detected ***: terminated | Aborted | autopkgtest [21:14:40]: @@@@@@@@@@@@@@@@@@@@ summary | upstream FAIL non-zero exit status 1 The full autopkgtest log is available there: https://ci.debian.net/data/autopkgtest/testing/i386/a/aribas/17524130/log.gz After investigation it appears that aribas contains i386 assembly code which doesn't follow the calling convention with regard to the direction flag. The divarr and modarr function modifies it to the "backward" direction with the STD instruction, but fails to modify it back to the "forward" direction upon exit as required in the System V ABI [1]: | EFLAGS | | The flags register contains the system flags, such as the direction | flag and the carry flag. The direction flag must be set to the | "forward" (that is, zero) direction before entry and upon exit from | a function. Other user flags have no specified role in the standard | calling sequence and are not preserved. The patch below fixes that, and is enough to get the autopkgtest working. Regards, Aurelien [1] http://www.sco.com/developers/devspecs/abi386-4.pdf --- aribas-1.64.orig/src/LINUX/arito386.S +++ aribas-1.64/src/LINUX/arito386.S @@ -211,6 +211,7 @@ divarr: popl %edi popl %ebx popl %ebp + cld ret /*---------------------------------------------------------*/ @@ -266,5 +267,6 @@ mod4arr: popl %esi popl %ebx popl %ebp + cld ret /*---------------------------------------------------------*/
--- End Message ---
--- Begin Message ---Source: aribas Source-Version: 1.65-1 Done: Ralf Treinen <trei...@debian.org> We believe that the bug you reported is fixed in the latest version of aribas, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1001...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ralf Treinen <trei...@debian.org> (supplier of updated aribas package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 23 Jan 2023 20:12:10 +0100 Source: aribas Architecture: source Version: 1.65-1 Distribution: unstable Urgency: medium Maintainer: Ralf Treinen <trei...@debian.org> Changed-By: Ralf Treinen <trei...@debian.org> Closes: 991782 1001653 Changes: aribas (1.65-1) unstable; urgency=medium . [ Ralf Treinen ] * update debian/watch file * add src/aribas to the filter in gbp.conf since upstream distributes a pre-compiled binary with the sources. * new upstream version, - drop patch no_strip as it is not useful - drop patch casting_pointers which has been integrated upstream - add patch fix-make-clean to make "make clean" idempotent - add patch compile-with-debug-symbols to use the -g flag to gcc * upstream has dropped the i386 assembly code (closes: #1001653), remove the special case for i386 in debian/rules (closes:#991782). * debian/aribas.install: upstream has moved src/EL to EL * debian/control: - Standards-Version 4.6.2 (no change) - declare Rules-Requires-Root: no * debian/aribas.docs: upstream has renamed doc files. Also modify accordingly debian/aribas-doc-base. . [ Debian Janitor ] * Trim trailing whitespace. * Use secure copyright file specification URI. * Use secure URI in Homepage field. * Bump debhelper from old 10 to 13. * Set debhelper-compat version in Build-Depends. * Update Vcs-* headers from URL redirect. * Use canonical URL in Vcs-Git. Checksums-Sha1: ae4c6281ebf764ac71314d0fa5c6615ac920de8a 1855 aribas_1.65-1.dsc 1b041c177171303cbe26d4f9aac66d037e47c55f 320164 aribas_1.65.orig.tar.gz 5744800fc6f02e9146a4904c9e7acc0aa5576164 8992 aribas_1.65-1.debian.tar.xz c5455c02006cd13a7c04d4ead68660826387d223 5908 aribas_1.65-1_source.buildinfo Checksums-Sha256: 9a0e5ad64a4d5f696fe40a1fd7c1e63ea7bfa6910e038345b555831e1122bd89 1855 aribas_1.65-1.dsc 2ea6864a3098760fc000ddd1d228d36294668d81ded4955f0e60822ec9e3bc65 320164 aribas_1.65.orig.tar.gz 37698ceb8c9ffd4b4bf764d2cc453991e2275c00bbbe81650cfb130536c918a1 8992 aribas_1.65-1.debian.tar.xz d7b3ce09dccb69bda9d6e281fbe0e4e6aa879bd1612ca38d29f5d869bd66fc17 5908 aribas_1.65-1_source.buildinfo Files: 67287966d73a0363062d66b06972322a 1855 math optional aribas_1.65-1.dsc aec83fe609a2adb6b90b58b3c6f21bfd 320164 math optional aribas_1.65.orig.tar.gz 3d1ad2ab3eda1a286a1add47084ee789 8992 math optional aribas_1.65-1.debian.tar.xz 4ba952f4d216b1541fd577c5398c63bc 5908 math optional aribas_1.65-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEAgVIKeEtDyqOZI5idFxHZtTKzf8FAmPO7jAACgkQdFxHZtTK zf+UOw/+LGGw3tP8s70o1Ts0/QBmQ3R0DMMVdgQxHbgOE56UuhKR3He4Y+AxFCM/ Cts8I/fmN/uMr9RBaNsjLiamOjgyYyqAaSRjguBijVBScXZY+PEYuRU0hUp+CV8P M4RIAaFtg6xu2Qa79MnOJgWp5ErJYZcxRCG8uAe8ZiEm7ud07/Ip6HpV3UVoxxrI BihwMC6vp8d/eml4bqWa9EYg/T/2tZtVfumTys7bg3C1YBBTKrXAB0fzCRzsQXyr pC71nwimKzdqnxRJmLUncx9X6H9/7etv4/9AglpkN4qEmRo5uDaKDQ5GZjVirWbm 3PVpu0mrK9WlBu0aLIvoJue+JY94NHvR2OctT9mBqxt1uGwiz9tQ+PmdB1mtnkTv /YVyRxb9jt8Uj5Ep//B8pGW/OSG5vstchsumEvNvAH+WKGg5GmnB0LVEg1YPT9Dp 2M0+Yu6gqX310tFgHiapJBjv0KYOqa5BGhYwQfDHIJjw8nNKmGhBVAvRhUNcFWnN LlbbVX9xysWLbbDV1kjQn0/IW5vvu6/x46F0ObblOnv+3tZAr/isoqp0tp7uM/dY 7HspKu8ldPh89RqGcqqf2GZLVYco9ZGl6ZRfjajKieLeQ967k4oz23ZxS3q+wdZW RrGhdTKPQrBCmHubAHzP9JrhLR7HwVrxQUETFj1QNN0qpOesal8= =vz4G -----END PGP SIGNATURE-----
--- End Message ---
