Bug#1026068: efibootguard: build fails if tests are disabled

[Gianfranco Costamagna]

Source: efibootguard
Version: 0.12-1
Severity: serious
tags: patch

Hello, it looks like you are using dh_auto_test to create manpages used during 
dh_auto_install target.
This is a bad thing to do, because if the user overrides the testsuite the 
build will fail.

The correct approach is to probably override dh auto build to create manpages 
(or even dh_auto_install)

and keep auto_test disabled, if you intend to do so.


The proposed patch is:
diff -Nru efibootguard-0.12/debian/changelog efibootguard-0.12/debian/changelog
--- efibootguard-0.12/debian/changelog  2022-09-01 08:50:34.000000000 +0000
+++ efibootguard-0.12/debian/changelog  2022-12-14 08:23:29.000000000 +0000
@@ -1,3 +1,10 @@
+efibootguard (0.12-1.1) unstable; urgency=medium
+
+  * Don't create manpages on test target, otherwise build
+    fails if nocheck=true (Closes: #-1)
+
+ -- Gianfranco Costamagna <locutusofb...@debian.org>  Wed, 14 Dec 2022 
09:23:29 +0100
+
 efibootguard (0.12-1) unstable; urgency=medium

diff -Nru efibootguard-0.12/debian/rules efibootguard-0.12/debian/rules
--- efibootguard-0.12/debian/rules      2022-09-01 08:50:34.000000000 +0000
+++ efibootguard-0.12/debian/rules      2022-12-14 08:23:27.000000000 +0000
@@ -9,6 +9,9 @@

 override_dh_auto_test:
+
+override_dh_auto_build:
+       dh_auto_build
        help2man -N -o bg_setenv.1   -n bg_setenv   ./bg_setenv
        help2man -N -o bg_printenv.1 -n bg_printenv ./bg_printenv
        help2man -N -o bg_gen_unified_kernel.1 
--version-string=v$(DEB_VERSION_UPSTREAM) tools/bg_gen_unified_kernel

* Initial release (Closes: #1001214) # do not run the tests until fff is available in Debian

OpenPGP_signature
Description: OpenPGP digital signature