Bug#1012226: unattended-upgrades: flaky autopkgtest: kernel-patterns seems to regularly get confused

[Paul Gevers]

Control: tag -1 patch

On Wed, 01 Jun 2022 21:50:33 +0200 Paul Gevers <elb...@debian.org> wrote:

unattended-upgrades showed up in the stable-proposed queue viewer [1]
because it appears to regress with the new xz-utils. However,
inspecing other failures in other suites, I think the test doesn't
behave well in archives where there are more than one version of
src:linux available. This happens regularly in pure unstable, in
unstable-to-testing and in stable-proposed-to-stable testing.

Can you please have a look? Because the unstable-to-testing migration
software now blocks on regressions in testing, flaky tests, i.e. tests
that flip between passing and failing without changes to the list of
installed packages, are causing people unrelated to your package to
spend time on these tests.

Don't hesitate to reach out if you need help and some more information
from our infrastructure.

Paul

From 6301dc299b6167db00881f9d1cb3b80adf28ad13 Mon Sep 17 00:00:00 2001
From: Paul Gevers <elb...@debian.org>
Date: Sun, 13 Nov 2022 20:19:12 +0100
Subject: [PATCH] test: don't confuse -dbg and -unsigned with current running
 kernel

Closes: #983363, #1012226
---
 test/autopkgtest_kernel_patterns.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/autopkgtest_kernel_patterns.py b/test/autopkgtest_kernel_patterns.py
index 111c72d..f0ce3c5 100755
--- a/test/autopkgtest_kernel_patterns.py
+++ b/test/autopkgtest_kernel_patterns.py
@@ -18,7 +18,7 @@ class TestKernelPatterns(unittest.TestCase):
         running_regexp = running_kernel_pkgs_regexp()
         running_kernel_version = subprocess.check_output(
             ["uname", "-r"], universal_newlines=True).rstrip()
-        running_escaped_regexp = ".*" + re.escape(running_kernel_version)
+        running_escaped_regexp = ".*" + re.escape(running_kernel_version) + '$'
         try:
             running_noflavor_regexp = "linux.*-" + re.escape(
                 re.match("[1-9][0-9]*\\.[0-9]+\\.[0-9]+-[0-9]+",
-- 
2.35.1

Looking at the error messages I think this is due to bug 983363 which isn't related to qemu, but the fact that the regexp for the running kernel in the test isn't closed, so it also matches the -dbg and -unsigned package with the same name. Attached is a patch that fixes that part of the issue. I must confess that I don't fully grasp why this isn't always a problem (e.g. now on arm64/stable), but on my current bookworm amd64 system the test fails without this patch and passes with the patch.

OpenPGP_signature
Description: OpenPGP digital signature