Your message dated Thu, 10 Nov 2022 22:26:57 +0000
with message-id <e1otg0f-008lgb...@fasolo.debian.org>
and subject line Bug#1023826: fixed in libnvme 1.2-2
has caused the Debian Bug report #1023826,
regarding libnvme: Fails to build on big endian systems (e.g. s390x)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1023826: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023826
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libnvme
Version: 1.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu lunar ubuntu-patch
X-Debbugs-Cc: bdr...@debian.org
Dear Maintainer,
libnvme fails to build on big endian systems (e.g. s390x). I forwarded
the bug upstream and they fixed. Please apply the fix (see attachement).
Thanks for considering the patch.
--
Benjamin Drung
Debian & Ubuntu Developer
diff -Nru libnvme-1.2/debian/patches/mi-endian-fixes.patch
libnvme-1.2/debian/patches/mi-endian-fixes.patch
--- libnvme-1.2/debian/patches/mi-endian-fixes.patch 1970-01-01
01:00:00.000000000 +0100
+++ libnvme-1.2/debian/patches/mi-endian-fixes.patch 2022-11-10
16:24:08.000000000 +0100
@@ -0,0 +1,61 @@
+From ac657355bc86b71e1d2d8dd6079d5d69332dedaa Mon Sep 17 00:00:00 2001
+From: Jeremy Kerr <j...@codeconstruct.com.au>
+Date: Thu, 10 Nov 2022 12:20:37 +0800
+Subject: [PATCH] mi: endian fixes
+
+We have a couple of endian issues in the mi code: one where we're not
+converting cdw0 for MI commands, and one where we're using the wrong
+byte length for an existing conversion. There is also an error in the
+test suite, where we should be converting the nsze field of a
+nvme_id_ns.
+
+This change fixes those, so that the test suite passes on a BE platform
+(ppc64 in my case).
+
+Fixes: https://github.com/linux-nvme/libnvme/issues/524
+Signed-off-by: Jeremy Kerr <j...@codeconstruct.com.au>
+Bug-Ubuntu: https://launchpad.net/bugs/1995935
+Origin: https://github.com/linux-nvme/libnvme/pull/529
+---
+ src/nvme/mi.c | 4 ++--
+ test/mi.c | 2 +-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/nvme/mi.c b/src/nvme/mi.c
+index cd86e41..1a34208 100644
+--- a/src/nvme/mi.c
++++ b/src/nvme/mi.c
+@@ -139,7 +139,7 @@ int nvme_mi_scan_ep(nvme_mi_ep_t ep, bool force_rescan)
+ struct nvme_mi_ctrl *ctrl;
+ __u16 id;
+
+- id = le32_to_cpu(list.identifier[i]);
++ id = le16_to_cpu(list.identifier[i]);
+ if (!id)
+ continue;
+
+@@ -985,7 +985,7 @@ static int nvme_mi_read_data(nvme_mi_ep_t ep, __u32 cdw0,
+ req_hdr.hdr.nmp = (NVME_MI_ROR_REQ << 7) |
+ (NVME_MI_MT_MI << 3); /* we always use command slot 0 */
+ req_hdr.opcode = nvme_mi_mi_opcode_mi_data_read;
+- req_hdr.cdw0 = cdw0;
++ req_hdr.cdw0 = cpu_to_le32(cdw0);
+
+ memset(&req, 0, sizeof(req));
+ req.hdr = &req_hdr.hdr;
+diff --git a/test/mi.c b/test/mi.c
+index 102cea9..4c7f1f2 100644
+--- a/test/mi.c
++++ b/test/mi.c
+@@ -1287,7 +1287,7 @@ static void test_admin_ns_mgmt_create(struct nvme_mi_ep
*ep)
+ assert(!rc);
+ assert(ns == 0x01020304);
+
+- nsid.nsze = 42;
++ nsid.nsze = cpu_to_le64(42);
+ rc = nvme_mi_admin_ns_mgmt_create(ctrl, &nsid, 0, &ns);
+ assert(rc);
+ }
+--
+2.37.2
+
diff -Nru libnvme-1.2/debian/patches/series libnvme-1.2/debian/patches/series
--- libnvme-1.2/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ libnvme-1.2/debian/patches/series 2022-11-10 16:20:16.000000000 +0100
@@ -0,0 +1 @@
+mi-endian-fixes.patch
--- End Message ---
--- Begin Message ---
Source: libnvme
Source-Version: 1.2-2
Done: Daniel Baumann <daniel.baum...@progress-linux.org>
We believe that the bug you reported is fixed in the latest version of
libnvme, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1023...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <daniel.baum...@progress-linux.org> (supplier of updated libnvme
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 10 Nov 2022 23:06:24 +0100
Source: libnvme
Architecture: source
Version: 1.2-2
Distribution: sid
Urgency: medium
Maintainer: Daniel Baumann <daniel.baum...@progress-linux.org>
Changed-By: Daniel Baumann <daniel.baum...@progress-linux.org>
Closes: 1023589 1023826
Changes:
libnvme (1.2-2) sid; urgency=medium
.
* Uploading to sid.
* Applying patch from Chris Lamb <la...@debian.org> to make build
reproducible (Closes: #1023589).
* Adding patch from upstream to fix FTBFS on big endian, thanks to
Benjamin Drung <bdr...@debian.org> (Closes: #1023826).
Checksums-Sha1:
c79fe5b45f2d8f327b12263728f4b5e46680b92f 2083 libnvme_1.2-2.dsc
80e127c25d0662a9bce7f42d7b5df832316d0895 7048 libnvme_1.2-2.debian.tar.xz
f464214d73daa974821ac2231b49c319770f7a14 9047 libnvme_1.2-2_amd64.buildinfo
Checksums-Sha256:
a58175ef85f195d4ff7ff35b47ae72e5d77f8b8e88599104a3191f5391589e89 2083
libnvme_1.2-2.dsc
fd8e08fdb3407337102a31c1c5c4ca1090d3398bc95d5cd05fbcf78d526db0dd 7048
libnvme_1.2-2.debian.tar.xz
13568cc47f2f2c36cb19a436132b659e3ffa347d35485d99ec496438909bbc04 9047
libnvme_1.2-2_amd64.buildinfo
Files:
b303ffc377302654960be80e3b9d0247 2083 libs optional libnvme_1.2-2.dsc
f29526267fac809e98ee447bdcba64ef 7048 libs optional libnvme_1.2-2.debian.tar.xz
53a8bbc2c49a3119118d8929e9453ea1 9047 libs optional
libnvme_1.2-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEgTbtJcfWfpLHSkKSVc8b+YaruccFAmNtdpQACgkQVc8b+Yar
ucd6Fg//cKAGvUONxp34wxHb1PQQw1b59UGuD6ZRuxxkKO5cBtMzuGTcYWDTJq8b
k3O0saF3QaADEo7XZOk3z+f+tYnwVXdBY5aG/oZ1k0kVzDD23SEQFmW7HdOeL+FX
H9Bdq5ktyEvt0IobiwabRGo2E5ne5yST3aZBaRUn2dDwg5247wrLVXiUilOp4wT4
fllzlsnz6AUBcHm2yvSGV07tKJXqC+cbgK5SMOmBBEYnz47+Ky9O8CMRWGU7gETb
qTF31ZAG+RXDSzWm0t4KJ9DByIrKAZn0HSVfn6RvEXqqWS5GEjtXSUfgHepg34Rg
HOSMcPSq5Qp1eBHz3oBQdAaJPMoX7SIlYni+rDeJp4rlDFIAReEzQ2eR4jmBodZk
THe1jRpqCHNZxibDvMw4svy43Q9Jw4v6zzRMEn6TA9r1VA95IgMmIDyRTpAOKUW+
YGSrAA5fsGlGr+7S+VsGn/3aHW7S0dVwkuhDLluD/hI1FHlkfRUkO/SgN29gUPZH
O1JXtOlExOBcdcbkMgcXB5uP6rm/p0bVrEyToH63jbThJhFxslkJgZOHZf92NPoN
bBU8VBpV+fmRasbfFjVnlF7RCvzC0jiFE3VdL95OT0xbrCVfQHQq4dBK0I6HdJYc
/GqPEU4NbNazN44nmFZ8pR1GgNj4/KIDfQLpylGDwziQW4IUnp8=
=h9gl
-----END PGP SIGNATURE-----
--- End Message ---
