Hi Fukui-san, Thank you for looking into the build failure.
Daichi Fukui <when.a.cat.sits.beside....@gmail.com> writes: > Hi, > > I have created a patch to address this issue. > Kindly find my github repository below for details: > https://github.com/daichifukui/libhugetlbfs > > Note that this patch is based on an upstream pull request, which has not been reviewed yet: > https://github.com/libhugetlbfs/libhugetlbfs/pull/63 The upstream patch gave some error when building the package. Some changes were needed to account for the use of "dash" for /bin/sh in Debian. I've pushed a branch with the patch[0]. I've not uploaded the package yet as the fix leads to a backward incompatible change - dropping hugepage-backed malloc from the package. At the minimum, it'll be useful to add a "NEWS" entry to inform the users when they upgrade. > Perhaps we need to review the original patch as well. I'll forward my findings (dash related changes) to the upstream issue. [0] https://github.com/punitagrawal/libhugetlbfs/tree/fix-build On Mon, Sep 5, 2022 at 3:27 PM Daichi Fukui < when.a.cat.sits.beside....@gmail.com> wrote: > Hi, > > I have created a patch to address this issue. > Kindly find my github repository below for details: > https://github.com/daichifukui/libhugetlbfs > > Note that this patch is based on an upstream pull request, which has not > been reviewed yet: > https://github.com/libhugetlbfs/libhugetlbfs/pull/63 > > Perhaps we need to review the original patch as well. > > Best, > Fukui > > On Sun, 14 Aug 2022 10:44:55 +0200 Lucas Nussbaum <lu...@debian.org> > wrote: > > Source: libhugetlbfs > > Version: 2.23-4 > > Severity: serious > > Justification: FTBFS > > Tags: bookworm sid ftbfs > > User: lu...@debian.org > > Usertags: ftbfs-20220813 ftbfs-bookworm > > > > Hi, > > > > During a rebuild of all packages in sid, your package failed to build > > on amd64. > > > > > > Relevant part (hopefully): > > > cc -m64 -Wdate-time -D_FORTIFY_SOURCE=2 -D__LIBHUGETLBFS__ -g -O2 > -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat > -Werror=format-security -Wall -fPIC -o obj64/kernel-features.o -c > kernel-features.c > > > morecore.c: In function ‘__lh_hugetlbfs_setup_morecore’: > > > morecore.c:368:17: error: ‘__morecore’ undeclared (first use in this > function); did you mean ‘thp_morecore’? > > > 368 | __morecore = &thp_morecore; > > > | ^~~~~~~~~~ > > > | thp_morecore > > > morecore.c:368:17: note: each undeclared identifier is reported only > once for each function it appears in > > > make[1]: *** [Makefile:298: obj64/morecore.o] Error 1 > > > > > > The full build log is available from: > > http://qa-logs.debian.net/2022/08/13/libhugetlbfs_2.23-4_unstable.log > > > > All bugs filed during this archive rebuild are listed at: > > > https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220813;users=lu...@debian.org > > or: > > > https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220813&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results > > > > A list of current common problems and possible solutions is available at > > http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to > contribute! > > > > If you reassign this bug to another package, please marking it as > 'affects'-ing > > this package. See https://www.debian.org/Bugs/server-control#affects > > > > If you fail to reproduce this, please provide a build log and diff it > with mine > > so that we can identify if something relevant changed in the meantime. > > > > >
