Hi Alexandre,

On Mon, 25 Jul 2022 10:03:04 +0200 Gianfranco Costamagna <locutusofb...@debian.org> wrote:
Hello, looks like Ubuntu already has a patch for this:
http://launchpadlibrarian.net/594282639/gpgme1.0_1.16.0-1.2ubuntu3_1.16.0-1.2ubuntu4.diff.gz

I was about to upload an NMU gpgme with your patch applied, but it looks wrong to me. If I understand the patch correctly (make isn't my strongest point), it will just run the test with the last PYTHON in PYTHONS. Why was the test not put inside the do-done block?

--- a/lang/python/tests/Makefile.am
+++ b/lang/python/tests/Makefile.am
@@ -70,7 +70,8 @@ check: xcheck
 .PHONY: xcheck

 xcheck:        all
-       $(TESTS_ENVIRONMENT) $(PYTHON) $(srcdir)/run-tests.py \
+       for PYTHON in $(PYTHONS); do true; done; \
+       $(TESTS_ENVIRONMENT) $$PYTHON $(srcdir)/run-tests.py \
          --interpreters="$(PYTHONS)" --srcdir=$(srcdir) $(TESTFLAGS) \
          $(XTESTS)

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to