Your message dated Sun, 28 Aug 2022 10:47:30 +0000
with message-id <e1osfpc-00fjte...@fasolo.debian.org>
and subject line Bug#990123: fixed in iptables-netflow 2.3-5+deb10u1
has caused the Debian Bug report #990123,
regarding [buster regression] iptables-netflow-dkms: No more compiles since
linux-*-4.19.0-17-*: "implicit declaration of function ‘ref_module’" (Upstream
kernel API regression in 4.19.191?)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
990123: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990123
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package:
iptables-netflow-dkms,linux-headers-4.19.0-17-amd64,linux-headers-4.19.0-17-i686-pae
Severity: serious
Version: iptables-netflow/2.3-5
Version: iptables-netflow/2.5.1-2
Version: linux/4.19.194-1
Tags: buster
Forwarded: https://github.com/aabc/ipt-netflow/issues/177
Since kernel packages linux-{image,headers}-4.19.0-17-*, at least with
-amd64 and -i686-pae, iptables-netflow-dkms no more compiles its kernel
module upon kernel installation:
In file included from /var/lib/dkms/ipt-netflow/2.3/build/ipt_NETFLOW.c:75:
/var/lib/dkms/ipt-netflow/2.3/build/ipt_NETFLOW.c: In function
‘register_ct_events’:
/var/lib/dkms/ipt-netflow/2.3/build/compat.h:173:21: error: implicit
declaration of function ‘ref_module’; did you mean ‘use_module’?
[-Werror=implicit-function-declaration]
# define use_module ref_module
^~~~~~~~~~
/var/lib/dkms/ipt-netflow/2.3/build/ipt_NETFLOW.c:5399:3: note: in expansion of
macro ‘use_module’
use_module(THIS_MODULE, netlink_m);
^~~~~~~~~~
Reading the kernel changelog, there are a few very suspicious entries
listed under upstream version 4.19.191:
- modules: mark ref_module static
- modules: mark find_symbol static
- modules: mark each_symbol_section static
One of the commits above (8745aa4e resp. 7ef5264d) states:
ref_module isn't used anywhere outside of module.c.
Which is only seems true if you ignore any third-party kernel modules
out there.
So why is the kernel API suddenly removing API-code used by third-party
modules inmidst a stable update? This looks like a regression to me. I
thought that stable updates only change the ABI, but not the API. (Well,
at least upstream and in Debian. :-)
I also tried the iptables-netflow-dkms 2.5.1-2 from Bullseye on Buster,
but it fails to build the kernel module for 4.19.0-17-* when as well.
2.5.1-2 though still works fine on Sid/Bullseye, hence marked as found
in the version in Sid, but tagged buster. In case this causes issues in
the BTS or the release team scripts, please rather remove 2.5.1-2 from
the "found" versions instead of removing the buster tag — unless the
same regression gets introduced into Sid and Bullseye as well.
Debian kernel maintainers: If this 3rd-party-module-breaking regression
was really intended and won't be fixed, please reassign the bug to
iptables-netflow-dkms only.
I also reported this issue to iptables-netflow upstream at
https://github.com/aabc/ipt-netflow/issues/177 as I think it at least
should update the version based ifdef checks in something which looks
like a similar issue in kernel 5.13, see
https://github.com/aabc/ipt-netflow/commit/5aae3791922bd3df878605b15e83ea48a4bd096c
which is part of iptables-netflow upstream's 2.6 release, not yet
packaged due to the freeze for bullseye.
I'll try and see if I can get that fix backported to the package in
buster (and if needed, later to the one in bullseye as well) and will
see if it actually helps in this case, too.
JFTR: dkms from buster-backports (as reported below) is only installed
as I needed it for the iptables-netflow-dkms package from bullseye. It
happened with dkms from buster before as well.
-- System Information:
Debian Release: 10.10
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable'),
(400, 'proposed-updates-debug'), (400, 'proposed-updates')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-12-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
Versions of packages iptables-netflow-dkms depends on:
ii dkms 2.8.4-3~bpo10+1
ii libc6 2.28-10
ii libc6-dev 2.28-10
ii libxtables-dev 1.8.2-4
ii pkg-config 0.29-6
Versions of packages iptables-netflow-dkms recommends:
ii iptables 1.8.2-4
Versions of packages iptables-netflow-dkms suggests:
ii irqtop 2.3-5
ii nfdump 1.6.17-1
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: iptables-netflow
Source-Version: 2.3-5+deb10u1
Done: Axel Beckert <a...@debian.org>
We believe that the bug you reported is fixed in the latest version of
iptables-netflow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 990...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Axel Beckert <a...@debian.org> (supplier of updated iptables-netflow package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 22 Jun 2021 18:00:10 +0200
Source: iptables-netflow
Architecture: source
Version: 2.3-5+deb10u1
Distribution: buster
Urgency: high
Maintainer: Axel Beckert <a...@debian.org>
Changed-By: Axel Beckert <a...@debian.org>
Closes: 990123
Changes:
iptables-netflow (2.3-5+deb10u1) buster; urgency=high
.
* Fix DKMS build failure regression caused by Linux upstream changes in
the 4.19.191 kernel by cherry-picking ipt_NETFLOW upstream commits
adfc6318 (initial fix for kernel 5.9) and 352cdb28 (removing the
special casing for older kernels). (Closes: #990123)
Checksums-Sha1:
3d6427cb99b9aa756ad98e2d46b6e31adcb7d3ae 2031
iptables-netflow_2.3-5+deb10u1.dsc
947f0d248cfc535db8d17b19a39bd2d0e396e392 8452
iptables-netflow_2.3-5+deb10u1.debian.tar.xz
Checksums-Sha256:
385c6b8f6d54f6068ece87329cb16ec91847680a871fe480e6d3e5acca9ecfcb 2031
iptables-netflow_2.3-5+deb10u1.dsc
946d9f7748da996c4ee261b75c7147467a57cfb4e9d90c788aa4a608401c8949 8452
iptables-netflow_2.3-5+deb10u1.debian.tar.xz
Files:
5551911b7e4202a16208688cd5756e3a 2031 kernel optional
iptables-netflow_2.3-5+deb10u1.dsc
6478020d8ae1a3f0a2560d1931f06a35 8452 kernel optional
iptables-netflow_2.3-5+deb10u1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAmMKLo0ACgkQiNJCh6LY
mLEmGBAAjXiTWK+rjwBoHBNGJPzVxfwZpFYRaEklv/2iNqLmoK8A9Wz5d+FtX87z
/S5IsTbbRqsCcOlUdtWGPA/PAG6viwQWN73sUrGcK+LeOz3vydv7hPBUSuJr7s/b
h4ph2yJakbdtV4KtqQ9dHAsqEH2lE+pbsLjpvwouUWL6g8RFT4UG0HGE2Bt3EjN2
nGHDKYBB0LZwD8w3XAH5Bih6F1Y8lExnCnnGq+CiXgr45jX97J6dCpsSwY/KMRNp
XcBdX1o8w+pCk/+XpPnkEQeccqQoDp2kKhGm+C5GJGXGUNF9eNNdQ2t3turPbcSm
pGOmynIlnOMPkNVzSSwgPVepYSBtK3MjiBk5MAKZcYBOnMPI1KbHKdIwclA7iDGL
VdC/4pRYi0z1w4RNBQnePiB1rVght7Z2e4Zalm8i3JL+4IzOchyXL3UCEFJlpGDi
soPknYeVxKzxsi9yh26+SeOIEDISp4Yi1UIo+zsVTSGJ0lk7H4WB5SGwSo/XxdKi
ShX36RyB+hbmefHNqeg6PGcy5UUPjkyN6+aDBPizpgktxFtbCWa+JQ96Q1ZzshQF
Tsn6eBUk/NLIoQtf8f3J/7k/deAxudjdm1jvzOwdpSJZ+oA0PNn8726SUyhM+5rw
rgNjcbRYJ2D1ck5DgqjzIXZvNiX/PM9tkjRs803uACElBhNhjQ8=
=/fCZ
-----END PGP SIGNATURE-----
pgp8b6b7Pi1bE.pgp
Description: PGP signature
--- End Message ---
