Your message dated Thu, 25 Aug 2022 09:38:21 -0700
with message-id <ywelfqntlzvp2...@homer.dodds.net>
and subject line Re: Bug#1017997: hdf5 ftbfs on s390x
has caused the Debian Bug report #1017997,
regarding hdf5 ftbfs on s390x
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1017997: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017997
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: hdf5
Version: 1.10.8+repack-1
Severity: serious
Tags: patch
Justification: ftbfs
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch

Hi Gilles,

hdf5 has been failing to build from source on s390x.  In Ubuntu we have a
patch to fix this build failure.  Please consider including it in Debian as
well.

I notice that the newer upstream version of hdf5 that's in experimental does
not fail to build anymore on s390x, so perhaps another solution would be to
upload that version to unstable.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru hdf5-1.10.8+repack/debian/patches/fix-signed_headers_dest.patch 
hdf5-1.10.8+repack/debian/patches/fix-signed_headers_dest.patch
--- hdf5-1.10.8+repack/debian/patches/fix-signed_headers_dest.patch     
1969-12-31 16:00:00.000000000 -0800
+++ hdf5-1.10.8+repack/debian/patches/fix-signed_headers_dest.patch     
2021-11-07 18:21:41.000000000 -0800
@@ -0,0 +1,15 @@
+--- a/src/H5FDs3comms.c
++++ b/src/H5FDs3comms.c
+@@ -1717,8 +1717,10 @@
+         node = node->next;
+     } /* end while node is not NULL */
+ 
+-    /* remove trailing ';' from signed headers sequence */
+-    signed_headers_dest[HDstrlen(signed_headers_dest) - 1] = '\0';
++    if (*signed_headers_dest != '\0') {
++        /* remove trailing ';' from signed headers sequence */
++        signed_headers_dest[HDstrlen(signed_headers_dest) - 1] = '\0';
++    }
+ 
+     /* append signed headers and payload hash
+      * NOTE: at present, no HTTP body is handled, per the nature of
diff -Nru hdf5-1.10.8+repack/debian/patches/series 
hdf5-1.10.8+repack/debian/patches/series
--- hdf5-1.10.8+repack/debian/patches/series    2022-04-29 08:47:00.000000000 
-0700
+++ hdf5-1.10.8+repack/debian/patches/series    2022-08-22 20:47:47.000000000 
-0700
@@ -4,3 +4,4 @@
 relax-version-check.patch
 fix-unaligned-accesses.patch
 reproducibility.patch
+fix-signed_headers_dest.patch

--- End Message ---
--- Begin Message ---
On Wed, Aug 24, 2022 at 12:43:51AM +0200, Gilles Filippini wrote:
> Hi Steve,

> Steve Langasek a écrit le 23/08/2022 à 22:40 :
> > Package: hdf5
> > Version: 1.10.8+repack-1
> > Severity: serious
> > Tags: patch
> > Justification: ftbfs
> > User: ubuntu-de...@lists.ubuntu.com
> > Usertags: origin-ubuntu kinetic ubuntu-patch
> > 
> > Hi Gilles,
> > 
> > hdf5 has been failing to build from source on s390x.  In Ubuntu we have a
> > patch to fix this build failure.  Please consider including it in Debian as
> > well.

> Thanks for this patch. However I can't reproduce the FTBFS on the s390x
> porterbox zelenka.debian.org.

> Would you mind sharing build logs?

Oops, I think you can ignore this.  When I looked, hdf5 had failed to build
in Debian unstable on s390x, but apparently it succeeded on a rebuild - and
I never looked at the Debian logs to confirm the build failure was the same
as the one we saw in Ubuntu.  Sorry about that!

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to