Control: retitle -1 sslsplit FTBFS when only loopback interface is configured
Control: forwarded -1 https://github.com/droe/sslsplit/issues/310
Contorl: tags -1 patch

Hello Hilko,

Here's a patch to at least make the package build by disabling tests that currently require network. I've forwarded the issue to upstream in case they have some comments on the issue.

I hope it is ok to NMU this to get sslsplit back to Debian. If not, please let me know! I'll wait wait for 10 days in case there are comments from you, others in Debian or upstream. I also hope it is ok to push these patches to salsa after the package has been uploaded.

There's another bug with a patch available (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958137). I can include that in the NMU as well if you'd like but I won't do it unless I get some feedback.

-Timo
diff -Nru sslsplit-0.5.5/debian/changelog sslsplit-0.5.5/debian/changelog
--- sslsplit-0.5.5/debian/changelog     2021-12-26 03:42:50.000000000 +0200
+++ sslsplit-0.5.5/debian/changelog     2022-07-16 12:32:07.000000000 +0300
@@ -1,3 +1,11 @@
+sslsplit (0.5.5-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTBFS: (Closes: #1007962)
+    - Disable tests that require network
+
+ -- Timo Lindfors <timo.lindf...@iki.fi>  Sat, 16 Jul 2022 12:32:07 +0300
+
 sslsplit (0.5.5-2) unstable; urgency=medium
 
   * Add OpenSSL 3 compatibility patch provided by Steve Langasek
diff -Nru 
sslsplit-0.5.5/debian/patches/disable-tests-that-require-network.patch 
sslsplit-0.5.5/debian/patches/disable-tests-that-require-network.patch
--- sslsplit-0.5.5/debian/patches/disable-tests-that-require-network.patch      
1970-01-01 02:00:00.000000000 +0200
+++ sslsplit-0.5.5/debian/patches/disable-tests-that-require-network.patch      
2022-07-16 12:29:18.000000000 +0300
@@ -0,0 +1,59 @@
+Description: Disable tests that require network
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007962
+Author: Timo Lindfors <timo.lindf...@iki.fi>
+
+Index: sslsplit/opts.t.c
+===================================================================
+--- sslsplit.orig/opts.t.c
++++ sslsplit/opts.t.c
+@@ -541,36 +541,24 @@ opts_suite(void)
+       s = suite_create("opts");
+ 
+       tc = tcase_create("proxyspec_parse");
+-      tcase_add_test(tc, proxyspec_parse_01);
+ #ifndef TRAVIS
+-      tcase_add_test(tc, proxyspec_parse_02); /* IPv6 */
+ #endif /* !TRAVIS */
+ #ifndef DOCKER
+       tcase_add_exit_test(tc, proxyspec_parse_03, EXIT_FAILURE);
+       tcase_add_exit_test(tc, proxyspec_parse_04, EXIT_FAILURE);
+ #endif /* !DOCKER */
+-      tcase_add_test(tc, proxyspec_parse_05);
+-      tcase_add_test(tc, proxyspec_parse_06);
+-      tcase_add_test(tc, proxyspec_parse_07);
+-      tcase_add_test(tc, proxyspec_parse_08);
+ #ifndef DOCKER
+       tcase_add_exit_test(tc, proxyspec_parse_09, EXIT_FAILURE);
+       tcase_add_exit_test(tc, proxyspec_parse_10, EXIT_FAILURE);
+ #endif /* !DOCKER */
+-      tcase_add_test(tc, proxyspec_parse_11);
+ #ifndef DOCKER
+       tcase_add_exit_test(tc, proxyspec_parse_12, EXIT_FAILURE);
+ #endif /* !DOCKER */
+ #ifndef TRAVIS
+-      tcase_add_test(tc, proxyspec_parse_13); /* IPv6 */
+-      tcase_add_test(tc, proxyspec_parse_14); /* IPv6 */
+ #endif /* !TRAVIS */
+-      tcase_add_test(tc, proxyspec_parse_15);
+-      tcase_add_test(tc, proxyspec_parse_16);
+ #ifndef DOCKER
+       tcase_add_exit_test(tc, proxyspec_parse_17, EXIT_FAILURE);
+ #endif /* !DOCKER */
+-      tcase_add_test(tc, proxyspec_parse_18);
+       suite_add_tcase(s, tc);
+ 
+       tc = tcase_create("opts_debug");
+Index: sslsplit/pxythrmgr.t.c
+===================================================================
+--- sslsplit.orig/pxythrmgr.t.c
++++ sslsplit/pxythrmgr.t.c
+@@ -118,9 +118,6 @@ pxythrmgr_suite(void)
+       tc = tcase_create("pxythrmgr_libevent");
+       tcase_add_test(tc, pxythrmgr_libevent_01);
+       tcase_add_test(tc, pxythrmgr_libevent_02);
+-      tcase_add_test(tc, pxythrmgr_libevent_03);
+-      tcase_add_test(tc, pxythrmgr_libevent_04);
+-      tcase_add_test(tc, pxythrmgr_libevent_05);
+       suite_add_tcase(s, tc);
+ 
+       return s;
diff -Nru sslsplit-0.5.5/debian/patches/series 
sslsplit-0.5.5/debian/patches/series
--- sslsplit-0.5.5/debian/patches/series        2021-12-26 03:40:40.000000000 
+0200
+++ sslsplit-0.5.5/debian/patches/series        2022-07-16 12:26:01.000000000 
+0300
@@ -1,2 +1,3 @@
 0001-Use-pkg-config-to-determine-linker-flags-for-test-pr.patch
 openssl3.patch
+disable-tests-that-require-network.patch

Reply via email to