Your message dated Sat, 09 Jul 2022 15:20:13 +0000
with message-id <e1oacfh-000hog...@fasolo.debian.org>
and subject line Bug#1014582: fixed in seqan3 3.2.0+ds-2
has caused the Debian Bug report #1014582,
regarding Build failure with googletest 1.12
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1014582: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014582
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: seqan3
Version: 3.2.0+ds-1
Severity: serious

The package fails to build in unstable due to a failing test.
The failure is due to a change in googletest 1.12


7451/8534 Test #7451: test/pretty_printing_test::pretty_printing.std_output 
..........................................................................................................................................................................................................................................................................................................................***Failed
    0.16 sec
Running main() from /usr/src/googletest/googletest/src/gtest_main.cc
Note: Google Test filter = pretty_printing.std_output
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from pretty_printing
[ RUN      ] pretty_printing.std_output
/tmp/autopkgtest-lxc.y_bdsw4i/downtmp/autopkgtest_tmp/unit/test/pretty_printing_test.cpp:70:
 Failure
Expected equality of these values:
  gtest_str(std::nullopt)
    Which is: "(nullopt)"
  "<VALUELESS_OPTIONAL>"s
    Which is: "<VALUELESS_OPTIONAL>"
[  FAILED  ] pretty_printing.std_output (0 ms)
[----------] 1 test from pretty_printing (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] pretty_printing.std_output

 1 FAILED TEST


The following tests FAILED:
        7451 - test/pretty_printing_test::pretty_printing.std_output (Failed)


The fix is something like this:


diff -ur seqan3-3.2.0+ds/test/unit/test/pretty_printing_test.cpp 
seqan3-3.2.0+ds.new/test/unit/test/pretty_printing_test.cpp
--- seqan3-3.2.0+ds/test/unit/test/pretty_printing_test.cpp     2022-07-08 
10:35:03.984000000 +0200
+++ seqan3-3.2.0+ds.new/test/unit/test/pretty_printing_test.cpp 2022-07-08 
10:22:40.124000000 +0200
@@ -67,7 +67,11 @@
     EXPECT_EQ(gtest_str(std::vector<std::vector<int>>{{0, 1}, {2, 3}, {1, 2}, 
{0}}), "[[0,1],[2,3],[1,2],[0]]"s);
     EXPECT_EQ(debug_str(std::vector<std::vector<int>>{{0, 1}, {2, 3}, {1, 2}, 
{0}}), "[[0,1],[2,3],[1,2],[0]]"s);
 
+#if [condition that indicates googletest version is >= 1.12]
+    EXPECT_EQ(gtest_str(std::nullopt), "(ynullopt)"s);
+#else
     EXPECT_EQ(gtest_str(std::nullopt), "<VALUELESS_OPTIONAL>"s);
+#endif
     EXPECT_EQ(debug_str(std::nullopt), "<VALUELESS_OPTIONAL>"s);
 }
 

I don't know the best way to define the [condition that indicates
googletest version is >= 1.12]

The seqan build is used as a autopkgtest for googletest, so this
failure is blocking the migration to testing for the googletest
package. (Can this be overridden somehow, if seqan is not fixed?)

        Mattias


Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message ---
Source: seqan3
Source-Version: 3.2.0+ds-2
Done: Étienne Mollier <emoll...@debian.org>

We believe that the bug you reported is fixed in the latest version of
seqan3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1014...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Étienne Mollier <emoll...@debian.org> (supplier of updated seqan3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 09 Jul 2022 14:48:54 +0200
Source: seqan3
Architecture: source
Version: 3.2.0+ds-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team 
<debian-med-packag...@lists.alioth.debian.org>
Changed-By: Étienne Mollier <emoll...@debian.org>
Closes: 1014582
Changes:
 seqan3 (3.2.0+ds-2) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Mattias Ellert ]
   * Add nullopt.patch: fix ftbfs with googletest 1.12 (Closes: #1014582)
 .
   [ Étienne Mollier ]
   * d/README.Debian: fix typo caught by lintian.
Checksums-Sha1:
 ac22102dff2195d85b61a48f290bf20747406635 2626 seqan3_3.2.0+ds-2.dsc
 18e0fde8e80a9437274920adac9147d2c9541f7b 10788 seqan3_3.2.0+ds-2.debian.tar.xz
Checksums-Sha256:
 aee2ed3d1c8abf0eb8f1667e84cddcb545d2118fbf691a875dbddbf85d7733d7 2626 
seqan3_3.2.0+ds-2.dsc
 149d7c0c38b31092b5fdd0a335fb97b50f8efc40eb656c6d5f6cbee2d972d8b2 10788 
seqan3_3.2.0+ds-2.debian.tar.xz
Files:
 a08a79c6763564b0edb99725e0222140 2626 science optional seqan3_3.2.0+ds-2.dsc
 bc494d909e47b932d94cf6b809222916 10788 science optional 
seqan3_3.2.0+ds-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEj5GyJ8fW8rGUjII2eTz2fo8NEdoFAmLJltwUHGVtb2xsaWVy
QGRlYmlhbi5vcmcACgkQeTz2fo8NEdrfqw//cBr/wPGmlyCI6k3GRptq17wqRl0c
sJSL/WnpjZ4JL40nyi48vzvhpxEGVVayjYfESfveueqpD2RA01JPbF7nQtow0W9I
rv5zh0IXjCyK60iz3u081lTG124Ho0XsA3RHckzPBLJb8KQejOTgyOy8BlpM6KIV
e/LilD7mJi0P6GAsuq+i2QSdiqXBO5X5EuFhe6+OxblAm+dy+eTl4jn9qlwjwWum
SYr/CUVQ23aygvQP6GjJwl04cETFlyFv43cbtL6lLYhg6kD1ga8TKWFFeCuX3L/1
FZwFmLeQO8EG3VhFukEtXX1V7yTbiTMzwhik2hxucnf1U0SqCfUNqITjfMMKal/m
nTlBzPykSjaDWIvAUCoWGprVqAEtBCX/BdGO847WSr8Xkw/FFVhwbD3loPuzDcPA
+7njxbpEvy9K8kGDez7SZnVB+FIxEWQh+2+4nqXUFRFtqv7SVzX1864kLpQWB4zt
jEBAojQzgzZ9Dj1Gq9E31Cv++HWCmUWTqGvyJjyKajvL1eGHJFxu9G431jLHBb4s
aTEjLGPQUWTFhzN1AoprZ38lDOTZSq0MmVdIAm179xG/k06GvemSH7ufuiF0mHyg
1O8KNkwOpLTKI6EW6B9M7FHbppMgRAZCOgD0FiAoNYOUo5bkOsHSJOphWgRs38J/
R8VvzGIxOG7tY7A=
=iDeY
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to