Your message dated Tue, 14 Jun 2022 22:14:16 +0000
with message-id <e1o1eng-000ijd...@fasolo.debian.org>
and subject line Bug#1007134: fixed in nzbget 21.0+dfsg-2.1
has caused the Debian Bug report #1007134,
regarding nzbget: wrong architecture target for source files on armhf
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1007134: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007134
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: nzbget
Version: 21.0+dfsg-2
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jammy ubuntu-patch
Hi Andreas,
The nzbget package is failing to build from source in Ubuntu on armhf,
because Ubuntu's compiler is currently stricter with compiler options than
Debian's:
[...]
g++ -DHAVE_CONFIG_H -I. -I./daemon/connect -I./daemon/extension
-I./daemon/feed -I./daemon/frontend -I./daemon/main -I./daemon/nntp
-I./daemon/postprocess -I./daemon/queue -I./daemon/remote -I./daemon/util
-I./daemon/nserv -I./lib/par2 -I./lib/yencode -Wdate-time -D_FORTIFY_SOURCE=2
-I/usr/include/libxml2 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -fpermissive -march=armv8-a+crc -fpermissive -c -o
lib/yencode/AcleCrc.o lib/yencode/AcleCrc.cpp
cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
make[2]: *** [Makefile:1774: lib/yencode/AcleCrc.o] Error 1
[...]
(https://launchpad.net/ubuntu/+source/nzbget/21.0+dfsg-2ubuntu1/+build/22597345)
The compiler doesn't like the use of -march=armv8-a+crc as a target because
this override of a default target doesn't specify the presence of an FPU,
which is required for hard-float (the 'hf' in armhf).
However, the correct fix here is NOT to pass -march=armv8-a+crc+fp, because
armv8 code is not guaranteed to run on the armhf architecture! The baseline
for armhf in Debian is armv6 and in Ubuntu is armv7, so having code that
doesn't do CPU detection but is built for armv8 (or neon/simd, as appears
elsewhere in the build scripts) will generate SIGILL on various hardware
that is supposed to be supported.
I therefore think the simplest correct fix is to disable these optimizations
for armhf - if someone wants better performance on the hardware in question
they can use the arm64 build instead.
Attached is the patch I've uploaded to Ubuntu to solve this there. Please
consider applying it in Debian as well.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru nzbget-21.0+dfsg/debian/patches/armv7-only.patch
nzbget-21.0+dfsg/debian/patches/armv7-only.patch
--- nzbget-21.0+dfsg/debian/patches/armv7-only.patch 1969-12-31
16:00:00.000000000 -0800
+++ nzbget-21.0+dfsg/debian/patches/armv7-only.patch 2022-03-11
10:19:23.000000000 -0800
@@ -0,0 +1,24 @@
+Description: don't use NEON, armv8 instructions on armhf
+ The guaranteed ISA for armhf is armv7+fpu and does not include SIMD or
+ armv8. Do not try to optimize the armhf binary with these extensions;
+ users who want this should run the arm64 port.
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Last-Update: 2022-03-11
+Forwarded: no
+
+Index: nzbget-21.0+dfsg/configure.ac
+===================================================================
+--- nzbget-21.0+dfsg.orig/configure.ac
++++ nzbget-21.0+dfsg/configure.ac
+@@ -572,11 +572,6 @@
+ PCLMUL_CXXFLAGS="-msse4.1 -mpclmul"
+ USE_SIMD=yes
+ ;;
+- arm*)
+- NEON_CXXFLAGS="-mfpu=neon"
+- ACLECRC_CXXFLAGS="-march=armv8-a+crc -fpermissive"
+- USE_SIMD=yes
+- ;;
+ aarch64)
+ ACLECRC_CXXFLAGS="-march=armv8-a+crc -fpermissive"
+ USE_SIMD=yes
diff -Nru nzbget-21.0+dfsg/debian/patches/series
nzbget-21.0+dfsg/debian/patches/series
--- nzbget-21.0+dfsg/debian/patches/series 2021-12-07 04:28:18.000000000
-0800
+++ nzbget-21.0+dfsg/debian/patches/series 2022-03-11 10:17:49.000000000
-0800
@@ -1,2 +1,3 @@
0001-dont-embed-libraries.patch
fips_mode.patch
+armv7-only.patch
--- End Message ---
--- Begin Message ---
Source: nzbget
Source-Version: 21.0+dfsg-2.1
Done: Håvard F. Aasen <havard.f.aa...@pfft.no>
We believe that the bug you reported is fixed in the latest version of
nzbget, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1007...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Håvard F. Aasen <havard.f.aa...@pfft.no> (supplier of updated nzbget package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 07 Jun 2022 15:16:11 +0200
Source: nzbget
Architecture: source
Version: 21.0+dfsg-2.1
Distribution: unstable
Urgency: medium
Maintainer: Andreas Moog <andreas.m...@warperbbs.de>
Changed-By: Håvard F. Aasen <havard.f.aa...@pfft.no>
Closes: 974451 1005717 1007134
Changes:
nzbget (21.0+dfsg-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* d/p/fips_mode.patch: Fix build against OpenSSL 3.0 Closes: #1005717
Thanks to Ubuntu developers for patch.
* Mark autopkgtest as superficial. Closes: #974451
* d/p/armv7-only.patch: Don't use NEON, armv8 instructions on armhf.
Closes: #1007134
Thanks to Ubuntu developers for patch.
Checksums-Sha1:
37ab3887332fea87e91fd2a3a02bf5d9544bd1f0 1939 nzbget_21.0+dfsg-2.1.dsc
646ca4809fbc9bd4e1a3e599f9aafbfc95c8d993 28444
nzbget_21.0+dfsg-2.1.debian.tar.xz
98e61890364c0d27d386717cb77e85064f2cc290 7042
nzbget_21.0+dfsg-2.1_source.buildinfo
Checksums-Sha256:
3aa09f7cdf52789731cde614f5d466c25aac51b8d3bb968dbc57d2700022d802 1939
nzbget_21.0+dfsg-2.1.dsc
4aa940ca5058cf7b3f02cf98679829268ba16ec880f92448a7ce401da175998e 28444
nzbget_21.0+dfsg-2.1.debian.tar.xz
07942a62e429b3bafb1942a0546a086a81e88846a8617f327ac730529a5d7178 7042
nzbget_21.0+dfsg-2.1_source.buildinfo
Files:
0991ca7e0d4e03c063bd443a89683360 1939 net optional nzbget_21.0+dfsg-2.1.dsc
fd8b8529266de477816d91b108b4f168 28444 net optional
nzbget_21.0+dfsg-2.1.debian.tar.xz
83d7eec661fa6970312a76cd9a8bc6ca 7042 net optional
nzbget_21.0+dfsg-2.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmKfdPcACgkQQoMEoXSN
zHpnxxAA3va5jrk9FsjXvMQ/25GtkAxgrvfp5lG50z0zqyjmG+K9KaFQc3gRom5o
NKWTUXjrpODlDfSzggRzrOE8tqkZT10UopNPEyDHIVrVu2v9NBN/UpsZM7NtSn3v
xsmD+3laD+3O7bpYvt2zEBgoWN2DxGo8zeeHYzkh3oqJxJe9Lr1jis5xIQEU3evT
oYTJX2g/RoH87C3SdMnrPN5p57xdeOKMMN8C/il+hcMuU93Sz+B9sNaOFttFZD2a
dUVBmjsNsc0uBM3fNXgGSAG06Pylf0o1xTwKl49N8HOY8ySPosNqcf9XQn1xOaH2
W+wEF4nMVmo4QBd/iUoffQ+oVmm4uHf5rlMfESx1TAYkDLICAojrcdB9UPQC25Bo
X+B+WQmQyjWWNswqmKjfrVN+MTPr73+VkWjUsxY3JjVReWVGklNOrCNgxf3Q9UlA
ECFy2r00ddaqpaIHUNDU6XzyQIPkKoB0YFjmPcPoH9bVM/nXwLV2zcQwanZ3ZFoW
oaIqER1FgcnN/otFmaTuB4zhMq6nEK20B5ZIuM4OetkVeUsChNODhHUoJh4gaBSk
axMKMwpIFBxV6EQG5GTdfCQaOOge1VyfKqwp7peESPnVaoqChp9ZRYZsMqDD9myJ
4FSK6LRayGC/cRGmATgXUCj1x8QTwbVwm+OabiI8ND1SDpIQ/Fc=
=ZeVZ
-----END PGP SIGNATURE-----
--- End Message ---
