Your message dated Fri, 06 May 2022 12:03:55 +0000
with message-id <e1nmwgd-0002ut...@fasolo.debian.org>
and subject line Bug#1008052: fixed in python-pecan 1.4.1-1
has caused the Debian Bug report #1008052,
regarding python-pecan FTBFS: build tests fail with python3.10
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1008052: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1008052
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: python-pecan
Version: 1.3.3-4
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jammy ubuntu-patch
Dear Maintainer,
In Ubuntu, the attached patch was applied to fix the build tests when
using python3.10:
* debian/patches/fix-tests-on-python-3.10.patch: Pull in upstream patch to
fix build tests on python3.10 (LP: #1965132).
Thanks,
Nick
diff -Nru python-pecan-1.3.3/debian/patches/fix-tests-on-python-3.10.patch
python-pecan-1.3.3/debian/patches/fix-tests-on-python-3.10.patch
--- python-pecan-1.3.3/debian/patches/fix-tests-on-python-3.10.patch
1969-12-31 19:00:00.000000000 -0500
+++ python-pecan-1.3.3/debian/patches/fix-tests-on-python-3.10.patch
2022-03-18 15:41:48.000000000 -0400
@@ -0,0 +1,87 @@
+Description: Fix tests to work on Python 3.10
+Origin: upstream,
https://github.com/pecan/pecan/pull/131/commits/f189d0eafbaacc5b5093bb8854cd2068e22b6c08
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/python-pecan/+bug/1965132
+---
+From f189d0eafbaacc5b5093bb8854cd2068e22b6c08 Mon Sep 17 00:00:00 2001
+From: Evangelos Foutras <evange...@foutrelis.com>
+Date: Wed, 8 Dec 2021 07:01:16 +0200
+Subject: [PATCH] Fix tests to work on Python 3.10
+
+Python 3.10 adds the class name to the exception; adjust four tests
+affected by this change.
+
+Fixes: https://github.com/pecan/pecan/issues/130
+---
+ pecan/tests/test_base.py | 18 +++++++++++++-----
+ pecan/tests/test_no_thread_locals.py | 20 ++++++++++++++------
+ 2 files changed, 27 insertions(+), 11 deletions(-)
+--- a/pecan/tests/test_base.py
++++ b/pecan/tests/test_base.py
+@@ -456,8 +456,12 @@
+ assert type(ex) == TypeError
+ assert ex.args[0] in (
+ "index() takes exactly 2 arguments (1 given)",
+- "index() missing 1 required positional argument: 'id'"
+- ) # this messaging changed in Python 3.3
++ "index() missing 1 required positional argument: 'id'",
++ (
++ "TestControllerArguments.app_.<locals>.RootController."
++ "index() missing 1 required positional argument: 'id'"
++ ),
++ ) # this messaging changed in Python 3.3 and again in Python 3.10
+
+ def test_single_argument(self):
+ r = self.app_.get('/1')
+@@ -994,9 +998,13 @@
+ except Exception as ex:
+ assert type(ex) == TypeError
+ assert ex.args[0] in (
+- "eater() takes at least 2 arguments (1 given)",
+- "eater() missing 1 required positional argument: 'id'"
+- ) # this messaging changed in Python 3.3
++ "eater() takes exactly 2 arguments (1 given)",
++ "eater() missing 1 required positional argument: 'id'",
++ (
++ "TestControllerArguments.app_.<locals>.RootController."
++ "eater() missing 1 required positional argument: 'id'"
++ ),
++ ) # this messaging changed in Python 3.3 and again in Python 3.10
+
+ def test_one_remainder(self):
+ r = self.app_.get('/eater/1')
+--- a/pecan/tests/test_no_thread_locals.py
++++ b/pecan/tests/test_no_thread_locals.py
+@@ -361,9 +361,13 @@
+ except Exception as ex:
+ assert type(ex) == TypeError
+ assert ex.args[0] in (
+- "index() takes exactly 4 arguments (3 given)",
+- "index() missing 1 required positional argument: 'id'"
+- ) # this messaging changed in Python 3.3
++ "index() takes exactly 2 arguments (1 given)",
++ "index() missing 1 required positional argument: 'id'",
++ (
++ "TestControllerArguments.app_.<locals>.RootController."
++ "index() missing 1 required positional argument: 'id'"
++ ),
++ ) # this messaging changed in Python 3.3 and again in Python 3.10
+
+ def test_single_argument(self):
+ r = self.app_.get('/1')
+@@ -763,9 +767,13 @@
+ except Exception as ex:
+ assert type(ex) == TypeError
+ assert ex.args[0] in (
+- "eater() takes at least 4 arguments (3 given)",
+- "eater() missing 1 required positional argument: 'id'"
+- ) # this messaging changed in Python 3.3
++ "eater() takes exactly 2 arguments (1 given)",
++ "eater() missing 1 required positional argument: 'id'",
++ (
++ "TestControllerArguments.app_.<locals>.RootController."
++ "eater() missing 1 required positional argument: 'id'"
++ ),
++ ) # this messaging changed in Python 3.3 and again in Python 3.10
+
+ def test_one_remainder(self):
+ r = self.app_.get('/eater/1')
diff -Nru python-pecan-1.3.3/debian/patches/series
python-pecan-1.3.3/debian/patches/series
--- python-pecan-1.3.3/debian/patches/series 2021-11-12 10:15:53.000000000
-0500
+++ python-pecan-1.3.3/debian/patches/series 2022-03-15 17:32:59.000000000
-0400
@@ -1,3 +1,4 @@
disable-failing-tests.patch
fix-setup.cfg-for-pytest.patch
Support_SQLAlchemy_1.4.x.patch
+fix-tests-on-python-3.10.patch
--- End Message ---
--- Begin Message ---
Source: python-pecan
Source-Version: 1.4.1-1
Done: Thomas Goirand <z...@debian.org>
We believe that the bug you reported is fixed in the latest version of
python-pecan, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1008...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Goirand <z...@debian.org> (supplier of updated python-pecan package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 06 May 2022 13:41:21 +0200
Source: python-pecan
Architecture: source
Version: 1.4.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <team+openst...@tracker.debian.org>
Changed-By: Thomas Goirand <z...@debian.org>
Closes: 1008052
Changes:
python-pecan (1.4.1-1) unstable; urgency=medium
.
* New upstream release:
- Fixes FTBFS with Python 3.10 (Closes: #1008052).
* Removed patches applied upstream:
- Support_SQLAlchemy_1.4.x.patch
- fix-setup.cfg-for-pytest.patch
* Refreshed patches:
- disable-failing-tests.patch
- remove-broken-test.patch
Checksums-Sha1:
f5bbd4db70cd0d650300006016b4d5f2b069e1f3 2470 python-pecan_1.4.1-1.dsc
90a30d5b1af93c0cba54dceb3a6926eae33acbc9 138984 python-pecan_1.4.1.orig.tar.xz
ccb0a547ab9b506afcf03a63800d3451a951f1ab 6028
python-pecan_1.4.1-1.debian.tar.xz
57221ad2021df22830401a5bb8592e553ced3411 9467
python-pecan_1.4.1-1_amd64.buildinfo
Checksums-Sha256:
9d15674abb1e471fef2b3e7349becf06dd7404e2ea18565ffbe7968b5022f124 2470
python-pecan_1.4.1-1.dsc
1889ab06b9b4bd10598359529181c23327744c2139f0d2f386dabdbffc196903 138984
python-pecan_1.4.1.orig.tar.xz
4f5b0078926dbd7a55860d99e42e3ad575ac2d618641b7c492a8b6e8d1b9e988 6028
python-pecan_1.4.1-1.debian.tar.xz
99afe886171a8fef23fc72f9e0394ecfe1505fdf3daafe2a7a62cc1c201affd1 9467
python-pecan_1.4.1-1_amd64.buildinfo
Files:
6b52fab118b3aed76051aef8af2c439b 2470 python optional python-pecan_1.4.1-1.dsc
a690cd64a0f40b4d4d17cefbb083382e 138984 python optional
python-pecan_1.4.1.orig.tar.xz
e00ae44d6d17aef1b5fea5afb93ba83b 6028 python optional
python-pecan_1.4.1-1.debian.tar.xz
42ac7fc67470f61e8cff0b86c9fbc95a 9467 python optional
python-pecan_1.4.1-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmJ1Co0ACgkQ1BatFaxr
Q/4FqA//cc9/+u2RoaivDZHFLAWZucv0GL8QHnJn0PpcfAReffzp+5+WyCfnfeQw
HDBwYPyBNPILIKBVA7c8D/JINW27XNqOb8BZXctZ27RX4586aJk/my3dtDlZGRdz
bnCoqgLSL8qJh43JgnrFMiyCmqwDw3fvuEkvFyUVD41qSesj/4u7qTnLMRmZTsrw
wihEpA5OLmhzgrAEzXEzSiFZPuWm1qcU5c8SS0ul743M4MQCqpBRgTxGolqco68g
gEliaLxKSyykNexHzFoeXbNtUYrNYt9LPcpSKF9I4FHpTl4Xouxh0NpI8xJaFdZD
SqXgs5GZtFXtV+V9b0OlgbhRYzZ6lsbgMsK3Wfu6+JrqIGdzS0D582ZlO35b9EzE
PBlmAMbhT1+QFIh1UFp2RRhr/zyC8U3K7NynpsfbzIpiuvOhQo5Ka6Nz6zQkVaX/
74xW357ysC7MSf2hRCxWjGoBZtiw5RA8C0D8QLlJcKnGLRRzy4OMb6zIu/y8buhG
tisDbsn0gAiDkALHzPaYUCjWVUO1UR+Ykn5Se9r9pNm9dIBrWbm+xMsKCwSWwRzs
KdizYZmLt9ducBV8Cdtqs3vosM/l5JB7hB13Wwe6oYNkPqEnA4i28PqzrgskXexI
xI2+depmsdPd6HuBGmzooLn64XT6aB47OngpwKKDOSrt+vXIzh8=
=QbaE
-----END PGP SIGNATURE-----
--- End Message ---
