Your message dated Thu, 21 Apr 2022 00:03:45 +0000
with message-id <e1nhkit-000aei...@fasolo.debian.org>
and subject line Bug#979462: fixed in aplus-fsf 4.22.1-10.2
has caused the Debian Bug report #979462,
regarding aplus-fsf: FTBFS against glibc 2.32
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
979462: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979462
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: aplus-fsf
Version: 4.22.1-10.1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch
X-Debbugs-Cc: lo...@ubuntu.com

Hi,

aplus-fsf currently FTBFS against glibc 2.32, which is used in the
development release of Ubuntu (and should be in Debian soon).

This is because it has some improperly guarded usage of sys_errlist
instead of strerror().

In Ubuntu, the attached patch was applied to achieve the following:

  * Fix FTBFS against glibc 2.32 by using strerror() instead of sys_errlist.

Thanks for considering the patch.

Logan
only in patch2:
unchanged:
--- aplus-fsf-4.22.1.orig/src/MSIPC/MSProtocolConnection.C
+++ aplus-fsf-4.22.1/src/MSIPC/MSProtocolConnection.C
@@ -129,8 +129,13 @@
   if (getpeername(fd(),(struct sockaddr *)&sockname,&socklen)) 
 #endif
    {
+#if defined (HAVE_STRERROR)
+     char *errstr = strerror(errno);
+#else
+     char *errstr = (errno<sys_nerr)?sys_errlist[errno]:"unknown error";
+#endif
      MSMessageLog::warningMessage("MSProtocolConnection: getpeername failed: 
%s\n",
-                                  (errno<sys_nerr)?sys_errlist[errno]:"unknown 
error");
+                                  errstr);
      close();
      return MSFalse;
    }
only in patch2:
unchanged:
--- aplus-fsf-4.22.1.orig/src/dap/error.c
+++ aplus-fsf-4.22.1/src/dap/error.c
@@ -71,12 +71,12 @@
 
        /* error string a la syslog(3) */
       case 'm':
-       if (errnum < 1 || errnum > sys_nerr)
-         str = "unknown error";
-       else
 #ifdef HAVE_STRERROR
-          str = strerror(errnum);
+        str = strerror(errnum);
 #else
+        if (errnum < 1 || errnum > sys_nerr)
+          str = "unknown error";
+        else
          str = sys_errlist[errnum];
 #endif
        for (z = str; *z != (char) NULL &&

--- End Message ---
--- Begin Message ---
Source: aplus-fsf
Source-Version: 4.22.1-10.2
Done: Marcos Talau <mar...@talau.info>

We believe that the bug you reported is fixed in the latest version of
aplus-fsf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 979...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marcos Talau <mar...@talau.info> (supplier of updated aplus-fsf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 13 Apr 2022 12:10:56 -0300
Source: aplus-fsf
Architecture: source
Version: 4.22.1-10.2
Distribution: unstable
Urgency: medium
Maintainer: Neil Roeth <n...@debian.org>
Changed-By: Marcos Talau <mar...@talau.info>
Closes: 979462 983970
Changes:
 aplus-fsf (4.22.1-10.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Fix FTBFS against glibc 2.32 by using strerror() instead of sys_errlist.
     Thanks to Logan Rosen <lo...@ubuntu.com>. (Closes: #979462)
   * Fix FTBFS on GCC-11, avoiding ordered pointer comparisons with integer.
     Thanks to Lukas Märdian <sl...@ubuntu.com>. (Closes: #983970)
Checksums-Sha1:
 fcd14dcf76a5406bb182ce93f20efe559e2af6bc 1958 aplus-fsf_4.22.1-10.2.dsc
 205b05dd98f3a09b583cc7f7af166d72215d1e14 611045 aplus-fsf_4.22.1-10.2.diff.gz
 12ac1c6460e986c7730b88ed32c3e2781a0ee7fc 6259 
aplus-fsf_4.22.1-10.2_source.buildinfo
Checksums-Sha256:
 90a862d0583555eef86a9bfad603b56881e4d73eb30bf57b1f36d3603dd5eb4c 1958 
aplus-fsf_4.22.1-10.2.dsc
 a839979aa45cda2aafdaa587db98db1609a9c561d823147c49e9eb7b3c918a36 611045 
aplus-fsf_4.22.1-10.2.diff.gz
 d64ee8c9e0b6a3dd827f49d7bdfe5339b11bdfe1352971db5947873e67d6ae0b 6259 
aplus-fsf_4.22.1-10.2_source.buildinfo
Files:
 5e5145a2c4be160a783650f770ed5925 1958 interpreters optional 
aplus-fsf_4.22.1-10.2.dsc
 444edd2f7d5f26646f9b6ebdf477dc79 611045 interpreters optional 
aplus-fsf_4.22.1-10.2.diff.gz
 8846e47434b76776dda472957f2e6db6 6259 interpreters optional 
aplus-fsf_4.22.1-10.2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmJZ/e4ACgkQ3mO5xwTr
6e+0Vw//Swebgeub1QYp3Cu9CworV5P0ZAvQkohp5cWkzkRTYuf79AHjk07PFl6q
dLOzOcYjSV5XUCfdryJ7d92l/LaDKBs6MyBwp5Pn0FYJvP9aZAedMz2y49YZNuuc
3+3Ke18f5qS4rxFB4u73Gfbk7OC5rI+9HYnxKLzgyYM9r1nX98HjdyOO24IXrazZ
+EX+Zp7CvPFxzxyteXiwK+ILZZwBp/+KVxDNELIkcbQCA+K062MMIfcZxP5es86b
cqb2UMqwLYG0KSqgsNhsGfU+uUW+hAv9JpCvHLAjodIiOXkHtL3Riu+LhC9VnLvl
9oLo3oe5N3/iqgbj1slBomnRq43pEwQhUmc812AILSZMlzz0CGHt7j0jxB0lW6AL
eb3XC65EphnUBC4weZpKs/wMAd5tD6q6PFVyKapc5o9jSZ+sma9bEml+aC0S6G3c
MhThRcG/+4Wl2I1HqjjAbXJ9UUvOpQd1KUKLUD2klnv4PBqCQzyrOSXms9meWpZU
scSg1mM5erWDw75a96XT5wXVfxSIavkhOh45IOfdIyIlq8IC1C2nTN0zDGVT3lAQ
fQqyav9nSb0yeD7JRo+MK4g4IkxWQzGLg5B9l9KgkzscC5J4prnAQifHUFAkQAYi
b13SOtYeFdWXLkZymp/fqZJ3JuESigKLOSRNB+q/zdNVgFwywv0=
=GOo7
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to