Your message dated Thu, 24 Mar 2022 10:48:43 +0000
with message-id <e1nxl1h-0002mh...@fasolo.debian.org>
and subject line Bug#1005390: fixed in dahdi-linux 1:2.11.1.0.20170917~dfsg-7.5
has caused the Debian Bug report #1005390,
regarding Fails to build with Linux 5.16 onward
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1005390: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005390
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: dahdi-linux
Version: 1:2.11.1.0.20170917~dfsg-7.4
Severity: grave
Tags: patch
The dahdi modules fail to build, with thqis error:
/var/lib/dkms/dahdi/2.11.1.0.20170917~dfsg-7.4/build/drivers/dahdi/wct4xxp/base.c:45:10:
fatal error: stdbool.h: No such file or directory
45 | #include <stdbool.h>
| ^~~~~~~~~~~
This is due to an intentional change in Linux 5.16 removing user-space
headers from the kernel include path:
<https://git.kernel.org/linus/04e85bbf71c9072dcf0ad9a7150495d72461105c>.
Kernel code must use <linux/types.h> instead of <stdbool.h>.
The attached patch fixes this and allows the build to complete, but
there are still a lot of compiler warnings.
Ben.
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'oldstable-updates'), (500,
'unstable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.15.0-3-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
From: Ben Hutchings <b...@debian.org>
Date: Sat, 12 Feb 2022 19:32:52 +0100
Subject: dahdi: Do not use <stdbool.h> in kernel modules
There was an intentional change in Linux 5.16 removing user-space
headers from the kernel include path:
<https://git.kernel.org/linus/04e85bbf71c9072dcf0ad9a7150495d72461105c>.
Kernel code must use <linux/types.h> instead of <stdbool.h>.
---
--- a/drivers/dahdi/dahdi-base.c
+++ b/drivers/dahdi/dahdi-base.c
@@ -86,7 +86,7 @@
#include "hpec/hpec_user.h"
-#include <stdbool.h>
+#include <linux/types.h>
#if defined(EMPULSE) && defined(EMFLASH)
#error "You cannot define both EMPULSE and EMFLASH"
--- a/drivers/dahdi/wcaxx-base.c
+++ b/drivers/dahdi/wcaxx-base.c
@@ -34,7 +34,7 @@
#include <linux/firmware.h>
#include <linux/crc32.h>
-#include <stdbool.h>
+#include <linux/types.h>
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30)
--- a/drivers/dahdi/wct4xxp/base.c
+++ b/drivers/dahdi/wct4xxp/base.c
@@ -42,7 +42,7 @@
#include <linux/crc32.h>
#include <linux/slab.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include <dahdi/kernel.h>
#include "wct4xxp.h"
--- a/drivers/dahdi/wctc4xxp/base.c
+++ b/drivers/dahdi/wctc4xxp/base.c
@@ -39,7 +39,7 @@
#include <linux/etherdevice.h>
#include <linux/timer.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include <dahdi/kernel.h>
--- a/drivers/dahdi/wctdm24xxp/base.c
+++ b/drivers/dahdi/wctdm24xxp/base.c
@@ -58,7 +58,7 @@ Tx Gain - W/Pre-Emphasis: -23.99 to 0.00
#include <linux/crc32.h>
#include <linux/slab.h>
-#include <stdbool.h>
+#include <linux/types.h>
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30)
/* Define this if you would like to load the modules in parallel. While this
--- a/drivers/dahdi/wcte12xp/base.c
+++ b/drivers/dahdi/wcte12xp/base.c
@@ -43,7 +43,7 @@
#include <linux/slab.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include <dahdi/kernel.h>
#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
--- a/drivers/dahdi/wcte13xp-base.c
+++ b/drivers/dahdi/wcte13xp-base.c
@@ -35,7 +35,7 @@
#include <linux/sched.h>
#include <linux/crc32.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include <dahdi/kernel.h>
#include "wct4xxp/wct4xxp.h" /* For certain definitions */
--- a/drivers/dahdi/wcte43x-base.c
+++ b/drivers/dahdi/wcte43x-base.c
@@ -43,7 +43,7 @@
#include <linux/firmware.h>
#include <oct612x.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include <dahdi/kernel.h>
#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
--- a/drivers/dahdi/wcxb.c
+++ b/drivers/dahdi/wcxb.c
@@ -38,7 +38,7 @@
#include <dahdi/kernel.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include "wcxb.h"
#include "wcxb_spi.h"
--- a/drivers/dahdi/wct4xxp/vpm450m.c
+++ b/drivers/dahdi/wct4xxp/vpm450m.c
@@ -28,7 +28,7 @@
#include <linux/version.h>
#include <dahdi/kernel.h>
-#include <stdbool.h>
+#include <linux/types.h>
#include "vpm450m.h"
#include <oct612x.h>
--- a/drivers/dahdi/voicebus/vpmoct.h
+++ b/drivers/dahdi/voicebus/vpmoct.h
@@ -30,7 +30,7 @@
#include <linux/timer.h>
#include "dahdi/kernel.h"
-#include <stdbool.h>
+#include <linux/kernel.h>
#define VPMOCT_FIRM_HEADER_LEN 32
#define VPMOCT_BOOT_RAM_LEN 128
--- a/drivers/dahdi/wcxb_spi.h
+++ b/drivers/dahdi/wcxb_spi.h
@@ -24,7 +24,7 @@
#define __WCXB_SPI_H
#include <linux/spi/spi.h>
-#include <stdbool.h>
+#include <linux/types.h>
struct wcxb_spi_transfer {
const void *tx_buf;
--- End Message ---
--- Begin Message ---
Source: dahdi-linux
Source-Version: 1:2.11.1.0.20170917~dfsg-7.5
Done: Thorsten Alteholz <deb...@alteholz.de>
We believe that the bug you reported is fixed in the latest version of
dahdi-linux, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1005...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thorsten Alteholz <deb...@alteholz.de> (supplier of updated dahdi-linux package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 23 Mar 2022 19:03:02 +0100
Source: dahdi-linux
Architecture: source
Version: 1:2.11.1.0.20170917~dfsg-7.5
Distribution: unstable
Urgency: medium
Maintainer: Debian VoIP Team <pkg-voip-maintain...@lists.alioth.debian.org>
Changed-By: Thorsten Alteholz <deb...@alteholz.de>
Closes: 1005390 1005715
Changes:
dahdi-linux (1:2.11.1.0.20170917~dfsg-7.5) unstable; urgency=medium
.
* Non-maintainer upload.
* add patch for: Do not use <stdbool.h> in kernel modules
There was an intentional change in Linux 5.16 removing user-space
headers from the kernel include path:
<https://git.kernel.org/linus/04e85bbf71c9072dcf0ad9a7150495d72461105c>.
Kernel code must use <linux/types.h> instead of <stdbool.h>.
Thanks a lot to Ben Hutchings for providing the patch.
Tzafrir Cohen provided a similar patch upstream.
(Closes: #1005715, #1005390)
Checksums-Sha1:
aaeb1323e2d0f1e8a16e2fcb1d66a85eeb695b45 2616
dahdi-linux_2.11.1.0.20170917~dfsg-7.5.dsc
cd74db4d6c8704fa94621b4573ee91e50abc152a 95220
dahdi-linux_2.11.1.0.20170917~dfsg-7.5.debian.tar.xz
1f037238462f5ba5027ed70e8368306e75185ce6 7698
dahdi-linux_2.11.1.0.20170917~dfsg-7.5_amd64.buildinfo
Checksums-Sha256:
9c74967c7cfede32aa70ad7543bafd7d46596781b9e98435fc64899edaa74d05 2616
dahdi-linux_2.11.1.0.20170917~dfsg-7.5.dsc
686fa81afcdc94c60a0df58f1b134840933df525537ae1f64ed87620ab51e893 95220
dahdi-linux_2.11.1.0.20170917~dfsg-7.5.debian.tar.xz
d4f63f9efefc60eb4ae728e30337640f254489482abcbd7d21e2768d6a82445d 7698
dahdi-linux_2.11.1.0.20170917~dfsg-7.5_amd64.buildinfo
Files:
5956a4e6bfbe9c8f1d344544e5699735 2616 comm optional
dahdi-linux_2.11.1.0.20170917~dfsg-7.5.dsc
8e3819ead463ca2fe3823eec4a54306b 95220 comm optional
dahdi-linux_2.11.1.0.20170917~dfsg-7.5.debian.tar.xz
2a499347540922fbf05550acbc28a0f6 7698 comm optional
dahdi-linux_2.11.1.0.20170917~dfsg-7.5_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKnBAEBCgCRFiEEYgH7/9u94Hgi6ruWlvysDTh7WEcFAmI8RkhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYy
MDFGQkZGREJCREUwNzgyMkVBQkI5Njk2RkNBQzBEMzg3QjU4NDcTHGRlYmlhbkBh
bHRlaG9sei5kZQAKCRCW/KwNOHtYR9BHEACipYfBojtmVrloF/KO23HNVtHc1qz3
0NrZQZn0DBNt035nRCyZNZXnA07hcfeSFrWhtEgI2VX7RPW7qYMt7goLibqm2C24
+57pNIZH4+65hPW8UbVzAack2aikfdkz6P4IrJQXoY8dp136e10Z7dbHUmHOjzd3
lCGl2u91KWl4uj51M8n16yMwhX+vySo9wOKj59pwDeMus40t1e6aFHuK/0BWFEfS
4F+fxmVy8Jlnr05wc1yUTDhs5LMOqVQNL7vS+d0FI/s18juLK4x+VZOUE1WOmebe
8bfvbBuIbGq2ma2BkEBNP/nbtrPsi3lDLZ9RSbWktXpc7HPLsvZdgMxsR8fPJAq+
NR8BWm/rFA6FVC8luQSuvxxHWs5FCjlCNsKu1K+FFHclPD8A5SwiliIOit/U6Lon
nrlGq+06J2zrda/eKY4vHA94szwXk59OJodBKZrB6rCzdwA3OsXmT3Sw4IyiJj1M
zEDbTyaGQz0Efk2WouHXdbY3qKDlKp3/eVFeAiZlP6GIJx6HlJNe9ac3rW5GCzDu
Ct5FLwFdtj3R4WOYrIigVsV0CjjgiVfWAnno24lnmXHAwFsGR4+jPYValCP9sh9y
dIRYCL5XS6jxzOcu5oG0ehH0n+OL/qWKnxoZE1yZwBySU1sK0s1gU486RWpQutac
/mKh3iSZxtF1Cw==
=qTOU
-----END PGP SIGNATURE-----
--- End Message ---
