On 11/02/2022 11:42, Yadd wrote:
On 11/02/2022 11:10, Yadd wrote:
On 11/02/2022 09:18, Julien Puydt wrote:
Le jeudi 10 février 2022 à 16:20 +0100, Yadd a écrit :
On 10/02/2022 15:38, Yadd wrote:
Package: node-csstype
Version: 3.0.10-1
Severity: grave
Justification: renders package unusable
debian/rules launches `ts-node --files build.ts --start` which
(only)
modifies indes.d.ts and index.js.flow. The result is unusable with
tsc:
/usr/share/nodejs/csstype/index.d.ts:18305:8 - error TS1005: ';'
expected.
All final ";" are dropped.
Removing override_dh_auto_build fixes the problem (using upstream
index.d.ts and index.js.flow which are readable)
@Julien, could you take a look ?
I think the problem is that in index.d.ts we have:
export type SvgAttributes = <empty>
export type Globals = <stuff>
while upstream has:
export type SvgAttributes = <stuff>
export type Globals = <stuff>
so the missing ';' is a red herring: we don't get the SvgAttributes
like we should, and that's the real problem.
I see that debian/nodejs/extlinks does have mdn-browser-compat-data,
but it creates node_modules/@mdn/browser-compat-data -- I don't know
why it does that, but it's what's breaking things as far a I can tell.
Do you know how to fix it?
You can push @mdn/browser-compat-data from debian/nodejs/extlinks to
debian/nodejs/extcopies but problem existed before this change.
Tested: same problem
I used my tools to find the problem. It is in our
mdn-browser-compat-data (hacked from @mdn/browser-compat-data) which
differs from upstream. Build works fine with mdn-browser-compat-data
downloaded with npm. Upstream wants this:
"mdn-browser-compat-data":
"git+https://github.com/mdn/browser-compat-data.git#a9a17ff717b73cb9bb7072357a080509b73e22bb";
Found: /usr/share/nodejs/mdn-browser-compat-data is a link to
/usr/share/nodejs/@mdn/browser-compat-data, so package.json "name" has
bad value. This should be a directory with its package.json and links to
@mdn/browser-compat-data files
This needs a mainscript (symlink_to_dir)
