Your message dated Sun, 23 Jan 2022 11:03:45 +0000
with message-id <e1nbaev-000btb...@fasolo.debian.org>
and subject line Bug#993620: fixed in vip-manager 1.0.1-5
has caused the Debian Bug report #993620,
regarding vip-manager: test failure with some network configurations
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
993620: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=993620
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: vip-manager
Version: 1.0.1-4
Severity: normal
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu impish
Dear Maintainer,
vip-manager behavior_test can fail, depending on the device network
configuration. If the test device has a network device of type ether
and a zero hardware address, and it selects this network device as the
one to use, the tests will fail.
Example failure:
https://autopkgtest.ubuntu.com/results/autopkgtest-impish/impish/armhf/v/vip-manager/20210901_213607_5779b@/log.gz
2021/09/01 21:35:37 Problems with generating the virtual ip manager: Cannot run
vip-manager on the loopback device
as its hardware address is the local address (00:00:00:00:00:00),
which prohibits sending of gratuitous ARP messages
Here is abbreviated output of 'ip link show' for one such test device:
3: gretap0@NONE: <BROADCAST,MULTICAST> mtu 1476 qdisc noop state DOWN mode
DEFAULT group default qlen 1000
link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
44262: eth0@if44263: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1458 qdisc noqueue
state UP mode DEFAULT group default qlen 1000
link/ether 00:16:3e:0f:a3:f7 brd ff:ff:ff:ff:ff:ff link-netnsid 0
In this example, gretap0 will be the chosen network device, but will
fail at runtime of vip-manager due to the all-zeros mac address.
Instead, eth0 should be chosen.
Please see the attached patch, which I will be looking to get integrated
to Ubuntu, which seems to address the above problem for Ubuntu armhf
autopkgtest.
This bug report was also filed in Ubuntu and can be found at
https://launchpad.net/bugs/1942375
-Dan
Description: Improved test device selection
Author: Dan Bungert <daniel.bung...@canonical.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/1942375
Last-Update: 2021-09-03
--- a/test/behaviour_test.sh
+++ b/test/behaviour_test.sh
@@ -7,9 +7,29 @@
NC='\033[0m' # No Color
# testing parameters
-dev=`ip link show | grep -B1 ether | cut -d ":" -f2 | head -n1 | cut -d " " -f2 | sed s/@.*//`
vip=10.0.2.123
+function get_dev {
+ # select a suitable device for testing purposes
+ # * a device that is an "ether"
+ # * and isn't a nil hardware address
+
+ # https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net
+ ARPHRD_ETHER=1
+
+ for dev in /sys/class/net/* ; do
+ test ! -e "$dev/address" && continue
+ test "$(cat $dev/address)" = "00:00:00:00:00:00" && continue
+ test "$(cat $dev/type)" != "$ARPHRD_ETHER" && continue
+ basename "$dev"
+ break
+ done
+}
+
+dev="$(get_dev)"
+# prerequisite test - do we have a suitable device?
+test -n "$dev"
+
#cleanup
function cleanup {
if test -f .ncatPid
@@ -35,7 +55,7 @@
}
trap cleanup EXIT
-# prerequisite test 0: vip should not yet be registered
+# prerequisite test: vip should not yet be registered
! ip address show dev $dev | grep $vip
# run etcd with podman/docker maybe?
--- End Message ---
--- Begin Message ---
Source: vip-manager
Source-Version: 1.0.1-5
Done: Michael Banck <michael.ba...@credativ.de>
We believe that the bug you reported is fixed in the latest version of
vip-manager, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 993...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Banck <michael.ba...@credativ.de> (supplier of updated vip-manager
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 23 Jan 2022 11:35:21 +0100
Source: vip-manager
Architecture: source
Version: 1.0.1-5
Distribution: unstable
Urgency: medium
Maintainer: Debian PostgreSQL Maintainers <team+postgre...@tracker.debian.org>
Changed-By: Michael Banck <michael.ba...@credativ.de>
Closes: 993620
Changes:
vip-manager (1.0.1-5) unstable; urgency=medium
.
* debian/patches/select_valid_net_device.patch: New patch, makes the
behaviour test try harder to select a valid network device, taken from
upstream commit cd9ab29 (Closes: #993620).
* debian/copyright: Removed no longer present vendor/ sections.
Checksums-Sha1:
c5fe2450b4975e63f19f066582756bf51f8f2fc9 2481 vip-manager_1.0.1-5.dsc
fca16b073bf372a471e60782cbc19c2a24b097ef 7528 vip-manager_1.0.1-5.debian.tar.xz
a1560985b913c2efaec727784d59d00ffacdab20 6017
vip-manager_1.0.1-5_source.buildinfo
Checksums-Sha256:
e04c801a4e74c9ea5e0f57f36d9af1df7e946232c86ee5d3f316b95f483e8ef8 2481
vip-manager_1.0.1-5.dsc
ff1f989e2272e99650f39cdfe0f74a7c4fd15dba55f8b7aaa6cf0b8bf9f71082 7528
vip-manager_1.0.1-5.debian.tar.xz
8add4b5de44c30f409e58107dfb2ad1db901374b11fc85b4c9c12a3e06be5d05 6017
vip-manager_1.0.1-5_source.buildinfo
Files:
8a7ef7aef414ba92458d9d85a185fac9 2481 net optional vip-manager_1.0.1-5.dsc
a37db6ada12f9c1866922a46ae8cc9b7 7528 net optional
vip-manager_1.0.1-5.debian.tar.xz
fa84e296cc3ab01b5f30a6142fa1f2f2 6017 net optional
vip-manager_1.0.1-5_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEnKh3dJ+rLk+paGLs3GhqJ7Q0gbAFAmHtL3kACgkQ3GhqJ7Q0
gbCPmQ//ULD2ybiLLoCdVKDknH+43N/qqGR7ol2QYhPb5BvS7rIYJkpiQBJJL0p4
0L+a1SbSWhx5mSJNr1+ciVGbDB+dprQDmNNUdSIerEskJWeGOtqulhOsQu5Xf2W1
Lgzwx2YSYSsb3ZmsrazW3xKrWtt3FZbGFo3Bn41YvOVLsBjpy8QR5xwYwXeTRWYE
F5lGbbMzmiioaBrNtmK4T9IqN4MCqaN8pxPkp81ZIe6dTQGJR8CvEd1xvyTFncFq
36DhyYRCoOi7Vq9jLjoe3v4xwflS7Eg0B74jPkQivPFpV0wUfcG6XUfDDdBrrsaW
3o7bq7C3vQ161INbD6Gy97ofvBP2i1+cyd+vqr1gK7OS3Cy/HKGSEqe+DyyDYlJA
CqmNR5zRCNF5Hqbf57xiGayFYK86KLZ4uxB9i6UiYt3QWhfQwGbpGXK4w7jpamS8
PbzmSL54FzWORs0Tj8dXLCscMmEbgx+u4HulCWmJjIFuyll9tjzHHH9RhiqTdG/o
Uyjam1jSYj9lDX68QR+YRJWDMl/2vYxw7arBswArdOVmho9SuvgJRKaIkKwHzieC
xXcfCuV9ZkgZ6hs1IPUX8AoOuR8OuZj+r460smu/IEayMlpH4Q/NFPFMHlc/9oNb
9ooeLp8P+XPVHsLTknWmR8YxuberZ7x07zEBrTLSls4n8aN0734=
=M3GS
-----END PGP SIGNATURE-----
--- End Message ---
