Your message dated Fri, 21 Jan 2022 14:37:55 +0000 with message-id <e1nav35-0006yn...@fasolo.debian.org> and subject line Bug#1003345: fixed in ruby-sqlite3 1.4.2-4 has caused the Debian Bug report #1003345, regarding ruby-sqlite3: FTBFS with SQLite3 3.37.0+ to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1003345: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003345 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: ruby-sqlite3 Version: 1.4.2-3 Severity: serious Tags: patch Hi, SQLite3 3.37.0 and onwards changed its inner working. Now table column data types are stored as a value and always returned as uppercase text. This breaks your package as it relies on the old behavior, when this was stored as text and returned in a case it was defined. As I broke it, I've created a fix for you, patch is attached. Sorry for the inconvenience, Laszlo/GCSDescription: SQLite3 3.37.0+ use uppercase column tupe names Starting with SQLite3 3.37.0 it stores column type names as a value and always displayed in uppercase letters. Previously it stored type names as text with the same case as it was given. This breaks testing where the column type is defined in lowercase and expects it to be given back as-is. Fix this with using type names in uppercase. Author: Laszlo Boszormenyi (GCS) <g...@debian.org> Forwarded: no Last-Update: 2022-01-08 --- --- ruby-sqlite3-1.4.2.orig/test/test_database.rb +++ ruby-sqlite3-1.4.2/test/test_database.rb @@ -268,12 +268,12 @@ module SQLite3 def test_table_info db = SQLite3::Database.new(':memory:', :results_as_hash => true) - db.execute("create table foo ( a integer primary key, b text )") + db.execute("create table foo ( a INTEGER primary key, b TEXT )") info = [{ "name" => "a", "pk" => 1, "notnull" => 0, - "type" => "integer", + "type" => "INTEGER", "dflt_value" => nil, "cid" => 0 }, @@ -281,7 +281,7 @@ module SQLite3 "name" => "b", "pk" => 0, "notnull" => 0, - "type" => "text", + "type" => "TEXT", "dflt_value" => nil, "cid" => 1 }] --- ruby-sqlite3-1.4.2.orig/test/test_integration.rb +++ ruby-sqlite3-1.4.2/test/test_integration.rb @@ -34,11 +34,11 @@ class TC_Database_Integration < SQLite3: def test_table_info_without_defaults_for_version_3_3_8_and_higher @db.transaction do - @db.execute "create table no_defaults_test ( a integer default 1, b integer )" + @db.execute "create table no_defaults_test ( a INTEGER default 1, b INTEGER )" data = @db.table_info( "no_defaults_test" ) - assert_equal({"name" => "a", "type" => "integer", "dflt_value" => "1", "notnull" => 0, "cid" => 0, "pk" => 0}, + assert_equal({"name" => "a", "type" => "INTEGER", "dflt_value" => "1", "notnull" => 0, "cid" => 0, "pk" => 0}, data[0]) - assert_equal({"name" => "b", "type" => "integer", "dflt_value" => nil, "notnull" => 0, "cid" => 1, "pk" => 0}, + assert_equal({"name" => "b", "type" => "INTEGER", "dflt_value" => nil, "notnull" => 0, "cid" => 1, "pk" => 0}, data[1]) end end --- ruby-sqlite3-1.4.2.orig/test/test_integration_resultset.rb +++ ruby-sqlite3-1.4.2/test/test_integration_resultset.rb @@ -4,7 +4,7 @@ class TC_ResultSet < SQLite3::TestCase def setup @db = SQLite3::Database.new(":memory:") @db.transaction do - @db.execute "create table foo ( a integer primary key, b text )" + @db.execute "create table foo ( a INTEGER primary key, b TEXT )" @db.execute "insert into foo ( b ) values ( 'foo' )" @db.execute "insert into foo ( b ) values ( 'bar' )" @db.execute "insert into foo ( b ) values ( 'baz' )" @@ -118,7 +118,7 @@ class TC_ResultSet < SQLite3::TestCase end def test_types - assert_equal [ "integer", "text" ], @result.types + assert_equal [ "INTEGER", "TEXT" ], @result.types end def test_columns
--- End Message ---
--- Begin Message ---Source: ruby-sqlite3 Source-Version: 1.4.2-4 Done: Cédric Boutillier <bou...@debian.org> We believe that the bug you reported is fixed in the latest version of ruby-sqlite3, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1003...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Cédric Boutillier <bou...@debian.org> (supplier of updated ruby-sqlite3 package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 21 Jan 2022 14:59:51 +0100 Source: ruby-sqlite3 Architecture: source Version: 1.4.2-4 Distribution: unstable Urgency: medium Maintainer: Debian Ruby Team <pkg-ruby-extras-maintain...@lists.alioth.debian.org> Changed-By: Cédric Boutillier <bou...@debian.org> Closes: 1003345 Changes: ruby-sqlite3 (1.4.2-4) unstable; urgency=medium . * Team upload. * Add patch by László Böszörményi to fix tests with sqlite3 3.37 and onwards (Closes: #1003345). Thanks! * Bump Standards-Version to 4.6.0 (no changes needed) Checksums-Sha1: bd350a3a3f30c38135270a72ddef24f3d2d7fd50 1491 ruby-sqlite3_1.4.2-4.dsc 55ecb0ed77c3c1ac8739a16822b5510fab085831 7184 ruby-sqlite3_1.4.2-4.debian.tar.xz 5ac846ad69f1a82d11ce2bedf27cd5552dd9782e 9087 ruby-sqlite3_1.4.2-4_amd64.buildinfo Checksums-Sha256: 9c64eb14bb76fee418c9378be5d96b35ae9b5eb815d22b25a6360b4fa6ccb1c2 1491 ruby-sqlite3_1.4.2-4.dsc 82a1c7ed3328c57a4d88a435c55fd56f165596f598bf330ff0144b34f692036e 7184 ruby-sqlite3_1.4.2-4.debian.tar.xz 3cbe7e37053b90f3c6d709f9eceb96f21f0f1d7e54de827a2aefaae7e5d2908a 9087 ruby-sqlite3_1.4.2-4_amd64.buildinfo Files: 1cdc2bf006545d220c94914761506e94 1491 ruby optional ruby-sqlite3_1.4.2-4.dsc e6524976f9d522a5690216010077180a 7184 ruby optional ruby-sqlite3_1.4.2-4.debian.tar.xz 41b5b1e242415355fd25ad8fe5dcd352 9087 ruby optional ruby-sqlite3_1.4.2-4_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSEz/3CFSD4gwbsKdFSaZq2P58rwwUCYerAdAAKCRBSaZq2P58r w+4pAQCGJGq+fsoxM/eb01QA6bK9XIUUhO1PkhRyZ8n98/23wwEAxad8VXETAxmu 5DnNEYvXqxdhWF+49AuXl1s8GELx2gI= =3f7F -----END PGP SIGNATURE-----
--- End Message ---
