Your message dated Thu, 18 Nov 2021 22:03:38 +0000
with message-id <e1mnpvk-00079y...@fasolo.debian.org>
and subject line Bug#995980: fixed in assimp 5.0.1~ds0-4
has caused the Debian Bug report #995980,
regarding assimp FTCBFS: very wrong python dependency and more issues
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
995980: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995980
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: assimp
Version: 5.0.1~ds0-3
Tags: patch
Control: clone -1 -2
Control: retitle -2 rules-require-build-prerequisite gives bogus advice
Control: reassign -2 lintian
Control: severity -2 important
Control: tags -2 - patch
Control: affects -2 src:assimp
User: debian-cr...@lists.debian.org
Usertags: ftcbfs
X-Debbugs-Cc: debhel...@packages.debian.org
X-Debbugs-Cc: debian-cr...@lists.debian.org
assimp fails to cross build from source. It attempts to build a python
module, but it ultimately fails doing so. While inspecting this, I
discovered that assimp "Build-Depends: python3:any | python3-all:any |
python3-dev:any | python3-all-dev:any | dh-sequence-python3". This is
wrong on so many levels.
For starters, sbuild ignores any alternative in unstable, so in
practice, this happens to become "python3:any". Any other alternative is
simply ignored and shouldn't be there.
Then, issuing a dependency on python3-dev:any without libpython3-dev is
practically never correct. That could be a separate lintian tag, but
that's not too bad here as python3-dev isn't needed. Either you go
python3-dev or you go python3-dev:any, libpython3-dev or you have a very
special and unusual use case that I have never encountered anywhere.
Also listing dh-sequence-python3 there is bogus. You already added
"--with python3" in debian/rules. This is duplicate at best. Either
should be dropped, but enabling a dh-addon in an alternative is clearly
not right, and debhelper should likely fail hard when encountering that.
Niels, do you agree?
I wondered how one would come up with such a strange dependency and
asked #debian-mentors for help. Kindly, a user named "itd" pointed me at
the lintian tag rules-require-build-prerequisite, which very likely is
the cause for this. Please disable the tag right now as it does more
harm than good. While the tag isn't bad per-se, the advice it gives
misleads users and produces broken packages. I request hiding or
disabling it now and then figuring out what it really should say.
Back to assimp. I looked into this to make it cross buildable, right?
And it was failing in Python-ish stuff. So why do we actually build the
Python module? Did I say module? It's not an extension? No, it isn't.
And we really don't have to build it in an arch-only build. So the key
to making assimp cross buildable is to make an arch-only build fully
skip the Python stuff. And once you do that, you don't care about :any
annotations anymore as those are practically irrelevant in
Build-Depends-Indep.
So I've attached a patch for assimp to fix the cross build and the
strange build dependency. Please consider applying it.
Helmut
diff --minimal -Nru assimp-5.0.1~ds0/debian/changelog
assimp-5.0.1~ds0/debian/changelog
--- assimp-5.0.1~ds0/debian/changelog 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/changelog 2021-10-08 20:49:28.000000000 +0200
@@ -1,3 +1,15 @@
+assimp (5.0.1~ds0-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix python build dependency. (Closes: #-1)
+ + Alternatives in Build-Depends are ignored.
+ + Enable the python3 dh addon once only.
+ + Build python module in indep build only.
+ + Move python Build-Depends to B-D-I.
+ + Drop the :any nonsense.
+
+ -- Helmut Grohne <hel...@subdivi.de> Fri, 08 Oct 2021 20:49:28 +0200
+
assimp (5.0.1~ds0-3) unstable; urgency=medium
[ Debian Janitor ]
diff --minimal -Nru assimp-5.0.1~ds0/debian/control
assimp-5.0.1~ds0/debian/control
--- assimp-5.0.1~ds0/debian/control 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/control 2021-10-08 20:49:28.000000000 +0200
@@ -15,8 +15,10 @@
libstb-dev,
libutfcpp-dev,
zlib1g-dev | libz-dev,
- python3:any | python3-all:any | python3-dev:any | python3-all-dev:any |
dh-sequence-python3,
doxygen,
+Build-Depends-Indep:
+ dh-sequence-python3,
+ python3,
Rules-Requires-Root: no
Vcs-Git: https://salsa.debian.org/debian/assimp.git
Vcs-Browser: https://salsa.debian.org/debian/assimp
diff --minimal -Nru assimp-5.0.1~ds0/debian/rules assimp-5.0.1~ds0/debian/rules
--- assimp-5.0.1~ds0/debian/rules 2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/rules 2021-10-08 20:49:28.000000000 +0200
@@ -33,7 +33,7 @@
export PYBUILD_NAME=pyassimp
%:
- dh $@ --with python3 --buildsystem=cmake
+ dh $@ --buildsystem=cmake
override_dh_auto_configure:
dh_auto_configure -- \
@@ -50,8 +50,10 @@
override_dh_auto_build:
dh_auto_build
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
dh_auto_build --buildsystem=pybuild -- \
-d port/PyAssimp/
+endif
cd obj-$(DEB_HOST_GNU_TYPE)/doc && doxygen Doxyfile
cd doc && doxygen Doxyfile_Cmd
@@ -61,8 +63,10 @@
override_dh_auto_install:
dh_auto_install
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
dh_auto_install --buildsystem=pybuild -- \
-d port/PyAssimp/
+endif
# IrrXML is not packaged for Debian, so drop the wrapper
find debian/*/usr -name irrXMLWrapper.h -delete
--- End Message ---
--- Begin Message ---
Source: assimp
Source-Version: 5.0.1~ds0-4
Done: IOhannes m zmölnig (Debian/GNU) <umlae...@debian.org>
We believe that the bug you reported is fixed in the latest version of
assimp, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 995...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlae...@debian.org> (supplier of updated
assimp package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 18 Nov 2021 22:13:52 +0100
Source: assimp
Architecture: source
Version: 5.0.1~ds0-4
Distribution: unstable
Urgency: medium
Maintainer: IOhannes m zmölnig (Debian/GNU) <umlae...@debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlae...@debian.org>
Closes: 995980
Changes:
assimp (5.0.1~ds0-4) unstable; urgency=medium
.
* Drop CDBS leftovers
* Split dh invocations into arch & indep parts
* Mark patches as forwarded
* Fix arch/indep rules
* Simplified doxygen invocation
* Test whether the cmake snippet works
* Fix python build dependency.
Thanks to Helmut Grohne <hel...@subdivi.de> (Closes: #995980)
+ Alternatives in Build-Depends are ignored.
+ Enable the python3 dh addon once only.
+ Move python Build-Depends to B-D-I.
+ Drop the :any nonsense.
* Prefer "execute_after_dh_..." over "override_dh_..."
* Apply 'wrapand-sort -ast'
Checksums-Sha1:
29331de877c2ffd5dc0539495cece81f5483fbba 2573 assimp_5.0.1~ds0-4.dsc
4ebc82005aec1007c9e0bbafbe8e5bdbbc9d0cdb 31532 assimp_5.0.1~ds0-4.debian.tar.xz
Checksums-Sha256:
ca3421317a5b913e1f4e94d58cfc6508d37fa66d79ec6cb7fc7a3e99cdc72daf 2573
assimp_5.0.1~ds0-4.dsc
30e265777d6f4f67fd472a25837e6fb5a2be345100c19b14c36c4f2ed9a053e8 31532
assimp_5.0.1~ds0-4.debian.tar.xz
Files:
8c46edce6d0a7b3cf8f66c72ef874d6c 2573 graphics optional assimp_5.0.1~ds0-4.dsc
77e486b6bd0f78797afc09b15308b6e8 31532 graphics optional
assimp_5.0.1~ds0-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQJKBAEBCAA0FiEEdAXnRVdICXNIABVttlAZxH96NvgFAmGWye4WHGZvcnVtQHVt
bGFldXRlLm11ci5hdAAKCRC2UBnEf3o2+FpPD/4+dUaUVnecnTkbLauZdVwOa2yS
b+niCbn2kgF/odTk9y0QOBz1dro55nDuEuZrvEnNMQYUPk7LsY9ffuFFBD+5xrrh
5GHGXguUIqajhsLDTq86kmBxoemiGk5QBLuM6xRnbyWhgCwNUsGdpLM0JWvi2bri
YTU8xxdggmdZ2OFvF5iT4sLzV0tHuqGgUICHrgyfAEQBSvuGTsOMMiKc4/pW84fV
FIFt+JweRdYxSegO3VPMrGMmdJsGGPQC+qSYA40Fqi6VGV4QmXKF7HpNlZpk2HsD
RxbAPNP0tESAhQv2L+6d5haOMUbHF1NBfh3lUftYgPLGqlNLy8RDWqcDsW1Lyrob
oj4cCkBgi2V+xR7wFvGDpB5e/5NiXcRdwN03MZivH9w+9Xc0Lx806JcgIA7WVccR
BBeenQMktjsyRmRHr72z3lROrt4dCA9bAUbJWH1rfwXLTg7MOXsvbzXB9ueThfKB
wRlQaADOHTeHh1qe50xvTZywUQTM56iUK7Lo6OMTdC5kiGN+TKRjPoAI5jaKUgIQ
i3G08CnZRl2PdRg5pHbFc2hjXH0WHHkMQVfa1UEKSyUnkYejYsWMp+Yqk6+GHQRO
ttJbFRhcdWpIwOPHACOrbm+vOpO6bNFh0qOMqDzS1GvTTZ5uHhEyjCUgYpuS9wdo
GkYpSDuBSBuMjPGvug==
=yA8e
-----END PGP SIGNATURE-----
--- End Message ---
