Your message dated Thu, 18 Nov 2021 09:39:04 +0100
with message-id <3ddfe29c-54ba-72a3-e895-0048538a5...@nerdrug.org>
and subject line Re: Bug#997159: burp: FTBFS: 
src/client/monitor/status_client_ncurses.c:350:9: error: format not a string 
literal and no format arguments [-Werror=format-security]
has caused the Debian Bug report #997159,
regarding burp: FTBFS: src/client/monitor/status_client_ncurses.c:350:9: error: 
format not a string literal and no format arguments [-Werror=format-security]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
997159: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=997159
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: burp
Version: 2.2.18-8
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing 
> -DSYSCONFDIR=\"/etc/burp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 
> -DHAVE_NCURSES_H=1 -c -o src/client/protocol2/main-backup_phase2.o `test -f 
> 'src/client/protocol2/backup_phase2.c' || echo 
> './'`src/client/protocol2/backup_phase2.c
> src/client/monitor/status_client_ncurses.c: In function 
> ‘screen_header_ncurses’:
> src/client/monitor/status_client_ncurses.c:350:9: error: format not a string 
> literal and no format arguments [-Werror=format-security]
>   350 |         mvprintw(0, col-l-1, date);
>       |         ^~~~~~~~
> src/client/monitor/status_client_ncurses.c: In function 
> ‘update_screen_view_log’:
> src/client/monitor/status_client_ncurses.c:752:24: warning: ISO C forbids 
> ‘return’ with expression, in function returning void [-Wpedantic]
>   752 |                 return update_screen_live_counters_w(sel, x, col);
>       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/client/monitor/status_client_ncurses.c:738:13: note: declared here
>   738 | static void update_screen_view_log(struct sel *sel, int *x, int col,
>       |             ^~~~~~~~~~~~~~~~~~~~~~
> gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing 
> -DSYSCONFDIR=\"/etc/burp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 
> -DHAVE_NCURSES_H=1 -c -o src/client/protocol2/main-rabin_read.o `test -f 
> 'src/client/protocol2/rabin_read.c' || echo 
> './'`src/client/protocol2/rabin_read.c
> gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing 
> -DSYSCONFDIR=\"/etc/burp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 
> -DHAVE_NCURSES_H=1 -c -o src/client/protocol2/main-restore.o `test -f 
> 'src/client/protocol2/restore.c' || echo './'`src/client/protocol2/restore.c
> gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing 
> -DSYSCONFDIR=\"/etc/burp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 
> -DHAVE_NCURSES_H=1 -c -o src/protocol1/main-handy.o `test -f 
> 'src/protocol1/handy.c' || echo './'`src/protocol1/handy.c
> gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing 
> -DSYSCONFDIR=\"/etc/burp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 
> -DHAVE_NCURSES_H=1 -c -o src/protocol1/main-msg.o `test -f 
> 'src/protocol1/msg.c' || echo './'`src/protocol1/msg.c
> gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing 
> -DSYSCONFDIR=\"/etc/burp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 
> -DHAVE_NCURSES_H=1 -c -o src/protocol1/main-rs_buf.o `test -f 
> 'src/protocol1/rs_buf.c' || echo './'`src/protocol1/rs_buf.c
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:4162: src/client/monitor/main-status_client_ncurses.o] 
> Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/burp_2.2.18-8_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

--- End Message ---
--- Begin Message ---
Version: 2.4.0-3


Hi


In version 2.4.0-3[1] I've re-enable compiler check and fix the warning/error (thanks to upstream developer).


I kindly ask Christoph Martin to check the package and upload it.


Thanks!



1: https://salsa.debian.org/debian/burp/-/commit/e04cec1042be1826da182df844b3896d5a431d59



On 02/11/21 16:46, Calogero Lo Leggio wrote:
I've temporarily disabled the format-security error:
https://salsa.debian.org/debian/burp/-/commit/625692bd42884fbb97f132967e3c4e70430aaddf


I will contact the developer to raise the issue.



Thanks!


On 23/10/21 21:05, Lucas Nussbaum wrote:
Source: burp
Version: 2.2.18-8
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing -DSYSCONFDIR=\"/etc/burp\"  
-Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE 
-D_XOPEN_SOURCE=600 -DHAVE_NCURSES_H=1 -c -o src/client/protocol2/main-backup_phase2.o `test -f 
'src/client/protocol2/backup_phase2.c' || echo './'`src/client/protocol2/backup_phase2.c
src/client/monitor/status_client_ncurses.c: In function ‘screen_header_ncurses’:
src/client/monitor/status_client_ncurses.c:350:9: error: format not a string 
literal and no format arguments [-Werror=format-security]
   350 |         mvprintw(0, col-l-1, date);
       |         ^~~~~~~~
src/client/monitor/status_client_ncurses.c: In function 
‘update_screen_view_log’:
src/client/monitor/status_client_ncurses.c:752:24: warning: ISO C forbids 
‘return’ with expression, in function returning void [-Wpedantic]
   752 |                 return update_screen_live_counters_w(sel, x, col);
       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/client/monitor/status_client_ncurses.c:738:13: note: declared here
   738 | static void update_screen_view_log(struct sel *sel, int *x, int col,
       |             ^~~~~~~~~~~~~~~~~~~~~~
gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing -DSYSCONFDIR=\"/etc/burp\"  
-Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE 
-D_XOPEN_SOURCE=600 -DHAVE_NCURSES_H=1 -c -o src/client/protocol2/main-rabin_read.o `test -f 
'src/client/protocol2/rabin_read.c' || echo './'`src/client/protocol2/rabin_read.c
gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing -DSYSCONFDIR=\"/etc/burp\"  
-Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE 
-D_XOPEN_SOURCE=600 -DHAVE_NCURSES_H=1 -c -o src/client/protocol2/main-restore.o `test -f 
'src/client/protocol2/restore.c' || echo './'`src/client/protocol2/restore.c
gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing -DSYSCONFDIR=\"/etc/burp\"  
-Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE 
-D_XOPEN_SOURCE=600 -DHAVE_NCURSES_H=1 -c -o src/protocol1/main-handy.o `test -f 
'src/protocol1/handy.c' || echo './'`src/protocol1/handy.c
gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing -DSYSCONFDIR=\"/etc/burp\"  
-Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE 
-D_XOPEN_SOURCE=600 -DHAVE_NCURSES_H=1 -c -o src/protocol1/main-msg.o `test -f 'src/protocol1/msg.c' 
|| echo './'`src/protocol1/msg.c
gcc -DHAVE_CONFIG_H -I. -I./src  -fno-strict-aliasing -DSYSCONFDIR=\"/etc/burp\"  
-Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_DEFAULT_SOURCE 
-D_XOPEN_SOURCE=600 -DHAVE_NCURSES_H=1 -c -o src/protocol1/main-rs_buf.o `test -f 
'src/protocol1/rs_buf.c' || echo './'`src/protocol1/rs_buf.c
cc1: some warnings being treated as errors
make[1]: *** [Makefile:4162: src/client/monitor/main-status_client_ncurses.o] 
Error 1
The full build log is available from:
http://qa-logs.debian.net/2021/10/23/burp_2.2.18-8_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS  . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. Seehttps://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.


--- End Message ---

Reply via email to