Your message dated Sun, 27 Jun 2021 14:48:46 +0000
with message-id <e1lxw5w-0009tw...@fasolo.debian.org>
and subject line Bug#990355: fixed in donkey 1.2.0-6
has caused the Debian Bug report #990355,
regarding [src:donkey] FTBFS with the tmux test runner
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
990355: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990355
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: donkey
Version: 1.2.0-1
Severity: serious
Tags: patch

The donkey upstraem source has two modes of running its tests:
using a pseudo-tty driver, and using tmux in control mode.
However, tmux 3.x has a regression (that is probably worth reporting
a separate bug for) that, among other things such as my need for
an actual tmux control mode library, led to me writing up the (still
raw and quite unfinished) https://gitlab.com/ppentchev/tmux-ctlmode
project. That part is not really pertinent to the Debian package of
donkey though, since I have not yet finished or packaged tmux-ctlmode
for Debian so donkey can use it to build.

A quick workaround for e.g.

  https://ci.debian.net/data/autopkgtest/testing/i386/d/donkey/13206643/log.gz

...would be to use the donkey source build system's "pty" test runner:

diff --git a/debian/rules b/debian/rules
index 8fe8f13..d16747a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -20,7 +20,7 @@ override_dh_auto_build:
        dh_auto_build -D src
 
 override_dh_auto_test:
-       dh_auto_test -D src
+       dh_auto_test -D src -- TEST_PROCESS_DRIVER=pty
 
 override_dh_auto_clean:
        dh_auto_clean -D src
diff --git a/debian/tests/control b/debian/tests/control
index d544f0c..3650d6e 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,4 +1,4 @@
-Test-Command: env TEST_PROG=/usr/bin/donkey python3 src/test-donkey.py
+Test-Command: env TEST_PROCESS_DRIVER=pty TEST_PROG=/usr/bin/donkey python3 
src/test-donkey.py
 Depends: @, python3, python3-ddt, python3-six, tmux
 Restrictions: allow-stderr
 Features: test-name=upstream

This should be enough to get the donkey package up and building again.

G'luck,
Peter


-- System Information:
Debian Release: 11.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-7-amd64 (SMP w/8 CPU threads)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: donkey
Source-Version: 1.2.0-6
Done: Peter Pentchev <r...@debian.org>

We believe that the bug you reported is fixed in the latest version of
donkey, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 990...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Peter Pentchev <r...@debian.org> (supplier of updated donkey package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 27 Jun 2021 01:00:00 +0300
Source: donkey
Architecture: source
Version: 1.2.0-6
Distribution: unstable
Urgency: medium
Maintainer: Peter Pentchev <r...@debian.org>
Changed-By: Peter Pentchev <r...@debian.org>
Closes: 990355
Changes:
 donkey (1.2.0-6) unstable; urgency=medium
 .
   * Use the "pty" test driver to avoid problems with tmux not always
     sending us the full output of the command that was run.
     Closes: #990355
Checksums-Sha1:
 ba931b2f7005e5ba93c888df795dc1d55f8df0a2 2370 donkey_1.2.0-6.dsc
 1b924f6535c8ac920396f50a1f27e895cdf2468a 10696 donkey_1.2.0-6.debian.tar.xz
Checksums-Sha256:
 80834ec28b1308204c14da3ac08ce3b8bc8133a7a90ed3a65e84107c3618904e 2370 
donkey_1.2.0-6.dsc
 dd9276d5bc825454bf85e185487b41959a7cc48276a0a2264ca166998b418fc4 10696 
donkey_1.2.0-6.debian.tar.xz
Files:
 62943da503f11d5e993fc82e327b69c7 2370 net optional donkey_1.2.0-6.dsc
 873b5f881af83e8ca99f0a7d2bcff964 10696 net optional 
donkey_1.2.0-6.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEELuenpRf8EkzxFcNUZR7vsCUn3xMFAmDYiqYQHHJvYW1AZGVi
aWFuLm9yZwAKCRBlHu+wJSffE7ZnD/9ZtFmANQPTDtTcXIg0PVzxGEdbu7BsO+ZD
9DkUfbhyaKSvSDZPvnZZsqv5L1SIF4zT0VAOxXNlnkD3t7PlkskPwZRVYmguXX1R
MOFO9wQFSs852j+qs7SY6a0x6es8iBUvp35bojSrVSVVzHoOe7D34E5Om2XAsOKo
U8xrWLVTsvQGKRCTbS4qc1IPZUq/a71KlAVGie5Oq91F85+XgXFZfGuuGm9EEdUt
q2hMcfP7V+0U1yYUKX8+r6Nw+Y5Hi5kKBmc2XG9aAAW1b0YQsZXK49U9KyrNn2Q9
LgfwqH/clv5nmfienA/xYsVfN9uxfW1tYiVHwOrLqn0B+S92p1PTt4kNBHTcotGr
BdoUKeC2Va5SLc8nLC0CN1fGkbu7hKSKPB2bpunYAsYt53D2DfFDC7hnE4IK0RJW
Fh422DQXKroIFs+nHMR8zR2jLvjalt6ieO4ToRuMTluVfCxTK2eMUDn1V5Exj+wX
LDoRfGbFtWNxernz7HZU0zBCHI2QBjwAxvrihsv1O1A4U/Cns+W66XEkScKxV/2f
H81L4aeTzX80EU0idyRzNGmmpI4+Tlr+puh5K7IPuubjd3PfCUMcivYzunqKqNJC
9NvM9xtHib9L7VP7DsFL1Kp3KGcxtQwrtr+iVa6HCuvfFOPvekmgBvzNUhxMF0fn
PMDtENb4Vw==
=Rgga
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to