Control: tags -1 + patch
On Thu, Jun 03, 2021 at 03:49:02PM +0200, Salvatore Bonaccorso wrote:
> Source: policykit-1
> Version: 0.105-30
> Severity: grave
> Tags: security upstream
> Justification: user security hole
> Forwarded: https://gitlab.freedesktop.org/polkit/polkit/-/issues/140
> X-Debbugs-Cc: car...@debian.org, Debian Security Team
> <t...@security.debian.org>
> Control: found -1 0.105-26
>
> Hi,
>
> The following vulnerability was published for policykit-1.
>
> CVE-2021-3560[0]:
> | local privilege escalation using
> | polkit_system_bus_name_get_creds_sync()
>
> The issue was introduced upstream with [2] in 0.113 but the
> introducing change is in Debian as well (and Ubuntu[3]).
>
> If you fix the vulnerability please also make sure to include the
> CVE (Common Vulnerabilities & Exposures) id in your changelog entry.
>
> For further information see:
>
> [0] https://security-tracker.debian.org/tracker/CVE-2021-3560
> https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-3560
> [1] https://gitlab.freedesktop.org/polkit/polkit/-/issues/140
> [2]
> https://gitlab.freedesktop.org/polkit/polkit/-/commit/bfa5036bfb93582c5a87c44b847957479d911e38
> [3] https://ubuntu.com/security/notices/USN-4980-1
> [4] https://bugzilla.redhat.com/show_bug.cgi?id=1961710
>
> Can you fix this targetted please for bullseye and ask the release
> team for an unblock?
Attached the patch.
Regards,
Salvatore
--- a/src/polkit/polkitsystembusname.c
+++ b/src/polkit/polkitsystembusname.c
@@ -435,6 +435,9 @@ polkit_system_bus_name_get_creds_sync (PolkitSystemBusName *system_bus
while (!((data.retrieved_uid && data.retrieved_pid) || data.caught_error))
g_main_context_iteration (tmp_context, TRUE);
+ if (data.caught_error)
+ goto out;
+
if (out_uid)
*out_uid = data.uid;
if (out_pid)
