Your message dated Sun, 16 May 2021 21:33:30 +0000
with message-id <e1liooa-0009nh...@fasolo.debian.org>
and subject line Bug#983533: fixed in vinagre 3.22.0-8.1
has caused the Debian Bug report #983533,
regarding [vinagre] black screen when launching RDP session
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
983533: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983533
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:vinagre
Severity: grave
Version: 3.22.0-8
For a while now, vinagre when running against FreeRDP >= 2.0.0 has
been broken in Debian. When launching an RDP session, the user sees a
GTK window with a black rectangle in the middle.
A fix proposed by FreeRDP upstream is
https://gitlab.gnome.org/GNOME/vinagre/-/commit/404a56a11469ef24a1df632847465030d81db091.patch
See:
https://gitlab.gnome.org/GNOME/vinagre/-/merge_requests/12
However, the vinagre version in Debian will not be fixed after the
referenced patch (an adapted version of it for vinagre 3.22.0) has
been applied (I just tested that).
Let me know, if I can give any more input on this. I saw from other
open bugs that vinagre upstream is scarcely maintained. Does it make
sense to ship vinagre in Debian 11? If yes, let me know how I can help
fixing this issue.
Greets,
Mike
--
DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de
>From 404a56a11469ef24a1df632847465030d81db091 Mon Sep 17 00:00:00 2001
From: Ondrej Holy <oh...@redhat.com>
Date: Fri, 15 May 2020 15:43:37 +0200
Subject: [PATCH] plugins/rdp: Fix hangs with recent FreeRDP versions
Connection to all my testing servers fails with "SERVER BUG: The support
for this feature was not announced! Use /relax-order-checks to ignore"
currently. This happens always with current FreeRDP versions after
https://github.com/FreeRDP/FreeRDP/pull/4926 has been merged. This can be
fixed by the usage of /relax-order-checks option, however, this option
should be used only if necessary needed and it should not be needed in
most of the cases. This currenlty happens always as it interfere with our
custom OrderSupports settings. Let's use the default OrderSupports
settings to fix this issue, which is possible thanks to
https://github.com/FreeRDP/FreeRDP/pull/5057.
See: https://gitlab.gnome.org/GNOME/gtk-frdp/-/issues/27
---
configure.ac | 2 +-
plugins/rdp/vinagre-rdp-tab.c | 27 ---------------------------
2 files changed, 1 insertion(+), 28 deletions(-)
--- a/configure.ac
+++ b/configure.ac
@@ -58,7 +58,7 @@
AM_CONDITIONAL([VINAGRE_ENABLE_SSH], [test "x$have_ssh" = "xyes"])
# Whether to enable support for RDP.
-RDP_DEPS="freerdp2 x11"
+RDP_DEPS="freerdp2 >= 2.0.0 x11"
AC_ARG_ENABLE([rdp],
[AS_HELP_STRING([--disable-rdp],
[Disable Remote Desktop Protocol (RDP) support])])
--- a/plugins/rdp/vinagre-rdp-tab.c
+++ b/plugins/rdp/vinagre-rdp-tab.c
@@ -522,9 +522,9 @@
static BOOL
frdp_pre_connect (freerdp *instance)
{
+#if HAVE_FREERDP_1_1
rdpSettings *settings = instance->settings;
-#if HAVE_FREERDP_1_1
settings->OrderSupport[NEG_DSTBLT_INDEX] = TRUE;
settings->OrderSupport[NEG_PATBLT_INDEX] = TRUE;
settings->OrderSupport[NEG_SCRBLT_INDEX] = TRUE;
@@ -549,31 +549,6 @@
settings->OrderSupport[NEG_POLYGON_CB_INDEX] = FALSE;
settings->OrderSupport[NEG_ELLIPSE_SC_INDEX] = FALSE;
settings->OrderSupport[NEG_ELLIPSE_CB_INDEX] = FALSE;
-#else
- settings->order_support[NEG_DSTBLT_INDEX] = true;
- settings->order_support[NEG_PATBLT_INDEX] = true;
- settings->order_support[NEG_SCRBLT_INDEX] = true;
- settings->order_support[NEG_OPAQUE_RECT_INDEX] = true;
- settings->order_support[NEG_DRAWNINEGRID_INDEX] = false;
- settings->order_support[NEG_MULTIDSTBLT_INDEX] = false;
- settings->order_support[NEG_MULTIPATBLT_INDEX] = false;
- settings->order_support[NEG_MULTISCRBLT_INDEX] = false;
- settings->order_support[NEG_MULTIOPAQUERECT_INDEX] = true;
- settings->order_support[NEG_MULTI_DRAWNINEGRID_INDEX] = false;
- settings->order_support[NEG_LINETO_INDEX] = true;
- settings->order_support[NEG_POLYLINE_INDEX] = true;
- settings->order_support[NEG_MEMBLT_INDEX] = true;
- settings->order_support[NEG_MEM3BLT_INDEX] = false;
- settings->order_support[NEG_MEMBLT_V2_INDEX] = true;
- settings->order_support[NEG_MEM3BLT_V2_INDEX] = false;
- settings->order_support[NEG_SAVEBITMAP_INDEX] = false;
- settings->order_support[NEG_GLYPH_INDEX_INDEX] = true;
- settings->order_support[NEG_FAST_INDEX_INDEX] = true;
- settings->order_support[NEG_FAST_GLYPH_INDEX] = false;
- settings->order_support[NEG_POLYGON_SC_INDEX] = false;
- settings->order_support[NEG_POLYGON_CB_INDEX] = false;
- settings->order_support[NEG_ELLIPSE_SC_INDEX] = false;
- settings->order_support[NEG_ELLIPSE_CB_INDEX] = false;
#endif
return TRUE;
pgpF7zMg8FxNr.pgp
Description: Digitale PGP-Signatur
--- End Message ---
--- Begin Message ---
Source: vinagre
Source-Version: 3.22.0-8.1
Done: Mike Gabriel <sunwea...@debian.org>
We believe that the bug you reported is fixed in the latest version of
vinagre, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 983...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Gabriel <sunwea...@debian.org> (supplier of updated vinagre package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 16 May 2021 23:11:19 +0200
Source: vinagre
Architecture: source
Version: 3.22.0-8.1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<pkg-gnome-maintain...@lists.alioth.debian.org>
Changed-By: Mike Gabriel <sunwea...@debian.org>
Closes: 983533
Changes:
vinagre (3.22.0-8.1) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/patches:
+ Add 0003-fix-hangs-with-recent-FreeRDP-version.patch and
0004-fix-FreeRDP-API-usage.patch. This resolves vinagre hanging endlessly
with a black screen when connecting to a remote RDP server (Closes:
#983533).
Checksums-Sha1:
1e02231dbbae201428b73fd9e7124df67ca59f1b 2461 vinagre_3.22.0-8.1.dsc
9c94d42265274f66e13a748c06c10b449380be0e 15680 vinagre_3.22.0-8.1.debian.tar.xz
ff54703b0e2e9879e462131cce83bc7b882bef4e 17041
vinagre_3.22.0-8.1_source.buildinfo
Checksums-Sha256:
40eeb8f2c8a98257047cf8bfbd2f7dfcb1cc6e266498555a32aec55b538e9ff1 2461
vinagre_3.22.0-8.1.dsc
2c7c66a53fd8f96ca4c79026b4e5cca7ddcc97b30b5163826b30ba3b39a0af09 15680
vinagre_3.22.0-8.1.debian.tar.xz
8547fbaf5999f13e3560d48adb3cf6427169bc9215b9dc41ad47cdd12cd43472 17041
vinagre_3.22.0-8.1_source.buildinfo
Files:
78cb56973f4eeaf6eddaf8565e86f927 2461 gnome optional vinagre_3.22.0-8.1.dsc
e5963c4f53a30a1513771dea83b5cfc2 15680 gnome optional
vinagre_3.22.0-8.1.debian.tar.xz
cedacf874a73b40167e5943fa4a90995 17041 gnome optional
vinagre_3.22.0-8.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmChioIVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxAToP/1GKoau5J92jZHiTpD+tssHi8nt2
2HD9Q0CKMDUhUlf+k7GiCLpupzjyEv48L/57vjjYfwtYwv1s7ebnCrgdVvCOP/OA
nPUT1HrJkTHaHOTMAKmcygyRWYgQFEqyhVRmP8OzE0kEbplAijlYeRu+EGPtRTFZ
F6SQdzWvvqw2sqxyWEWf80vAVer/IOugafjFLasXZ+EvJqr3MxLO9oV/1HWkBVWV
CZOFG5zUV/AVlC3fO6AqNsnBh38bxRPtc5nN55QuHMdixoJgXctFUbe4uq2CFuAT
KLHd3vdXB2rKwNogD+bARgSnWJ2xJN/7niRISaP0xFdVKR/U5ku1V+eDGnJvWjgF
MuFSl9hMvjdXMd5DF1R868AnF1K6HiJlhmV996iGn6ZapzA+reJ8s/eusvLf64WD
9/qtR5oN4MUDksNKVQeVi/5d7H0cfuilDFU7Y42B7FnO87wqe0BWjVaZ7K6vx/Em
yE69oNkLY3B8w0enNXQ0awi21Y1MJ3FuUNI3iMP1rpSw4gSiPu+UI1bGCwmLtUfj
WI2Xe9yCpdYh5n5YIS8fQNTEBa0/l7RbHSWSftDcZBUUfvDMkwzSOhA2L+bjbVDE
CCXeXzz0or4/UWaNyNhxVsDO/F7+XkaetUytmeXlhlHLBhvN/1Kko8Q3o6yNhXqn
//tWXVKI5TKDSHqt
=xvtp
-----END PGP SIGNATURE-----
--- End Message ---
