Control: affects -1 mender-client

Hi,

On Sat, Apr 03, 2021 at 02:52:34PM +0200, Bastian Germann wrote:
> Control: tags -1 patch
> 
> A patch is enclosed.
[...]
>  CMAKE_FLAGS = \
>       -DCMAKE_VERBOSE_MAKEFILE=ON \
> -     -DCMAKE_C_FLAGS_RELEASE="$(CFLAGS)" \
> +     -DCMAKE_C_FLAGS_RELEASE="$(CFLAGS) NDEBUG=" \
>       -DCMAKE_EXE_LINKER_FLAGS_RELEASE="$(LDFLAGS)" \
>       -DBUILD_DOCS=ON \
>       -DCMAKE_INSTALL_INCLUDEDIR="include/$(DEB_HOST_MULTIARCH)"

Your patch seems to have been applied in the last upload and this
bug report was closed.

I've reopened the bug report, as the bug seems to still exist:

$ dpkg -l libubootenv0.1 | grep ^ii
libubootenv0.1:armhf 0.3-2        armhf        Library to access U-Boot 
environment - runtime

$ strings /usr/lib/arm-linux-gnueabihf/libubootenv.so.0.3 |
grep Environment
Environment %s, copy %d
Environment FLAGS %s

$ sudo fw_printenv | head -n1i
Environment OK, copy 1

FYI This extra debug output also breaks mender-client.

Could we please just add a patch that either just rips out the NDEBUG
lines (or inverts the login to #ifdef DEBUG ) ?! Such a patch could/should
be forwarded upstream as well.... A library should not print to stdout
like this!

Regards,
Andreas Henriksson

Reply via email to