On Fri, 26 Feb 2021 03:21:36 +0200
Faidon Liambotis <parav...@debian.org> wrote:
[...]
>
> pa_cpu_init_orc() returns true only if cpu_info.cpu_type ==
> PA_CPU_X86. This should not be the case here, but cpu_info is being
> passed to the function uninitialized, and... as luck would have it,
> cpu_info.cpu_type's "random" contents are set to PA_CPU_X86.
>
> So at minimum, the test is broken; initializing cpu_info as is done on
> other tests is enough to fix this:
>
> --- pulseaudio-14.2.orig/src/tests/cpu-volume-test.c
> +++ pulseaudio-14.2/src/tests/cpu-volume-test.c
> @@ -187,7 +187,7 @@ END_TEST
>
> START_TEST (svolume_orc_test) {
> pa_do_volume_func_t orig_func, orc_func;
> - pa_cpu_info cpu_info;
> + pa_cpu_info cpu_info = { PA_CPU_UNDEFINED, {}, false };
> int i, j;
>
> #if defined (__i386__) || defined (__amd64__)
>
> I've tested this fix on plummer, and it seems to work as expected.
Thank you! Your explanation and patch looks correct, this is most
certainly the correct fix.
