control: tag -1 patch

On 2/5/21 3:22 AM, Gianfranco Costamagna wrote:
> control: reopen -1
> control: notfixed -1 3.0.9+dfsg1-1.1
> 
> Hello, I reuse this bug, to point out that now the package has an autopkgtest 
> failure on armhf, probably due to an incomplete patch or a missing xvfb 
> dependency on debian/tests/control


Thanks---digging into this more, I think I understand what's going on:

xpra/scripts/config.py:detect_xvfb_command specifically wants Xvfb
In particular:

    if platform.uname()[4].startswith("arm"):
        #arm struggles to launch Xdummy, so use Xvfb:

(But, why this _is_ working on arm64, I do _not_ understand---presumably,
some other case-handling causes xpra to change its mind elsewhere.)

It would, then, seem that all we need is to depend on Xvfb on the failure
architecture:

diff --git a/debian/control b/debian/control
index 6befbb9..77ef63c 100644
--- a/debian/control
+++ b/debian/control
@@ -42,6 +42,7 @@ Depends: ${misc:Depends}, ${python3:Depends}, 
${shlibs:Depends}
     ,python3-gi-cairo
     ,x11-xserver-utils
     ,xserver-xorg-video-dummy
+    ,xvfb [armhf]
 # Packet Encoding (http://xpra.org/trac/wiki/PacketEncoding):
     ,python3-rencode
 Recommends: ${misc:Recommends}

Attachment: OpenPGP_0xB01C53D5DED4A4EE.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to