Control: tag -1 + confirmed
Hi Pabs,
Paul Wise wrote:
> With the release of Debian bullseye and later, security updates are
> provided in the bullseye-security suite instead of bullseye/updates.
Indeed, thanks for making me aware that this needs also to change at
that point.
> The above hook script references ${dist}/updates but when bullseye is
> released that should be replaced by ${dist}-security so it looks
> like the script would generate an incorrect sources.list using /updates
> instead of -security which would cause the new Xen guest to not get
> security updates from bullseye in a timely manner.
Ack. Just have to think how I make that separation properly. Either by
listing all supported previous release names (or maybe just those not
yet archived) and defaulting to the new scheme to be comaptible with
all future releases.
> I suggest that this hook check the version of the Debian release in
> question using distro-info and then if the release is 11 or higher,
> then use ${dist}-security otherwise use ${dist}/updates as before.
I'd rather avoid this seemingly debian-specific dependency (c.f.
https://salsa.debian.org/debian/distro-info/-/blob/master/debian/copyright
and the native package version number) as xen-tools should also be
usable on other distributions.
But using an integer comparison on the release version is a good idea.
Unfortunately xen-tools as of now only handles code names, not release
numbers.
Will have to see.
> It is much better to use distro-info than to hard-code the release
> version numbers.
I disagree since distro-info is debian-only and that's a clear no-go.
Also these numbers won't change in the future once they're released,
so hardcoding won't do any harm.
> It might even be a good idea to include the security
> suite information in distro-info itself and look it up there.
I'd rather add it to xen-tools' etc/distribution.conf which basically
tracks the needed setting changes per release:
https://github.com/xen-tools/xen-tools/blob/master/etc/distributions.conf
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
