Your message dated Thu, 08 Oct 2020 17:49:27 +0000 with message-id <e1kqa2h-0004hq...@fasolo.debian.org> and subject line Bug#971794: fixed in fakeroot 1.25.3-1 has caused the Debian Bug report #971794, regarding fakeroot: testsuite fails on mipsel to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 971794: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971794 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: fakeroot Version: 1.25.2-1 Severity: serious Tags: patch ftbfs Justification: fails to build from source (but built successfully in the past) Hi, The latest upload of fakeroot got support for statx added, thanks for that. Unfortunately it doesn't work on mipsel, as spotted by the testsuite: | make[5]: Entering directory '/<<PKGBUILDDIR>>/obj-sysv/test' | FAIL: t.chmod_dev | PASS: t.cp-a | PASS: t.echoarg | PASS: t.falsereturn | FAIL: t.mknod | PASS: t.no_ld_preload | PASS: t.no_ld_preload_link | PASS: t.option | PASS: t.tar | PASS: t.touchinstall | PASS: t.truereturn | PASS: t.xattr | ============================================================================ | Testsuite summary for fakeroot 1.25.2 | ============================================================================ | # TOTAL: 12 | # PASS: 10 | # SKIP: 0 | # XFAIL: 0 | # FAIL: 2 | # XPASS: 0 | # ERROR: 0 | ============================================================================ | See test/test-suite.log | Please report to cl...@debian.org | ============================================================================ The full build log is available there: https://buildd.debian.org/status/fetch.php?pkg=fakeroot&arch=mipsel&ver=1.25.2-1&stamp=1601883875&raw=0 The issue is due to mixes between struct stat and INT_STRUCT_STAT as spotted by this warning: | ../libfakeroot.c: In function ‘statx’: | ../libfakeroot.c:2466:17: warning: passing argument 1 of ‘send_get_stat’ from incompatible pointer type [-Wincompatible-pointer-types] | 2466 | SEND_GET_STAT(&st,ver); | | ^~~ | | | | | struct stat64 * | ../libfakeroot.c:88:42: note: in definition of macro ‘SEND_GET_STAT’ | 88 | #define SEND_GET_STAT(a,b) send_get_stat(a) | | ^ | In file included from ../libfakeroot.c:60: | ../communicate.h:174:40: note: expected ‘struct stat *’ but argument is of type ‘struct stat64 *’ | 174 | extern void send_get_stat(struct stat *buf); | | ~~~~~~~~~~~~~^~~ The attached patch fixes the issue. With it the warning is gone, the testsuite passes and the package builds successfully on mipsel. Regards, Aurelien--- fakeroot-1.25.2.orig/libfakeroot.c +++ fakeroot-1.25.2/libfakeroot.c @@ -102,6 +102,7 @@ #define INT_NEXT_FSTATAT(a,b,c,d) NEXT_FSTATAT64(_STAT_VER,a,b,c,d) #define INT_SEND_STAT(a,b) SEND_STAT64(a,b,_STAT_VER) #define INT_SEND_GET_XATTR(a,b) SEND_GET_XATTR64(a,b,_STAT_VER) +#define INT_SEND_GET_STAT(a,b) SEND_GET_STAT64(a,b) #else #define INT_STRUCT_STAT struct stat #define INT_NEXT_STAT(a,b) NEXT_STAT(_STAT_VER,a,b) @@ -110,6 +111,7 @@ #define INT_NEXT_FSTATAT(a,b,c,d) NEXT_FSTATAT(_STAT_VER,a,b,c,d) #define INT_SEND_STAT(a,b) SEND_STAT(a,b,_STAT_VER) #define INT_SEND_GET_XATTR(a,b) SEND_GET_XATTR(a,b,_STAT_VER) +#define INT_SEND_GET_STAT(a,b) SEND_GET_STAT(a,b) #endif #include <stdlib.h> @@ -2463,7 +2465,7 @@ int statx (int dirfd, const char *path, r=INT_NEXT_FSTATAT(dirfd, path, &st, flags); if(r) return -1; - SEND_GET_STAT(&st,ver); + INT_SEND_GET_STAT(&st,ver); r=next_statx(dirfd, path, flags, mask, buf); if(r)
--- End Message ---
--- Begin Message ---Source: fakeroot Source-Version: 1.25.3-1 Done: Clint Adams <cl...@debian.org> We believe that the bug you reported is fixed in the latest version of fakeroot, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 971...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Clint Adams <cl...@debian.org> (supplier of updated fakeroot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 08 Oct 2020 13:13:45 -0400 Source: fakeroot Architecture: source Version: 1.25.3-1 Distribution: unstable Urgency: medium Maintainer: Clint Adams <cl...@debian.org> Changed-By: Clint Adams <cl...@debian.org> Closes: 971794 Changes: fakeroot (1.25.3-1) unstable; urgency=medium . * Patch from Aurelien Jarno to fix statx wrapper on mipsel. closes: #971794. Checksums-Sha1: 8b8e8877ee7de88d53208ff26244942e7a0bd4db 1978 fakeroot_1.25.3-1.dsc b6cb435df8d83ed2d8335b949e52b834122e4994 126884 fakeroot_1.25.3.orig.tar.gz 2ec35b3c539a7c044399c28254a0cba50fac42f4 22696 fakeroot_1.25.3-1.debian.tar.xz 4695c85f4b9fb61a45145e11f72b8b84997f2399 5680 fakeroot_1.25.3-1_source.buildinfo Checksums-Sha256: 80d508d3513c6dc6bf53f1524b26262322d0243a0c1ee6d6cbe156b4f4b75a20 1978 fakeroot_1.25.3-1.dsc 8e903683357f7f5bcc31b879fd743391ad47691d4be33d24a76be3b6c21e956c 126884 fakeroot_1.25.3.orig.tar.gz e711f36ca8dc0221fae842df568d97f9d45a1910441383c3eed121b70a052a9c 22696 fakeroot_1.25.3-1.debian.tar.xz 0edd2b61652f245b63a6f68245930e7035a439ee328a832adb7c2773ae424c09 5680 fakeroot_1.25.3-1_source.buildinfo Files: 4c27b489861ae7e2878703ca1a8b356f 1978 utils optional fakeroot_1.25.3-1.dsc f6104ef6960c962377ef062bf222a1d2 126884 utils optional fakeroot_1.25.3.orig.tar.gz 9614da773ab2d68883d25c90d728a080 22696 utils optional fakeroot_1.25.3-1.debian.tar.xz accba74d592a9ef573f9af87e9ed8208 5680 utils optional fakeroot_1.25.3-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJFBAEBCgAvFiEEdYHsh0BT5sgHeRubVZIzHhmdOKgFAl9/TJQRHGNsaW50QGRl Ymlhbi5vcmcACgkQVZIzHhmdOKgeRhAAjDafocAbg8W/2ZjWZetBJHU+sbBPJJfP EGd0ExuADXrkv71OfefYo9Ifh+Jmib5pPFshYFpGul7cZC2IYabyLh1os1xXHlga gsVk3MN9y5Q+6juboXI3uQ/hJSFIfhSN6EKtzD7IBRzDl/d73GEFUCeGLTIjG3Ut SusDz1N2bl3KR2jgiV8m3PHW6WC8M6dHmfTDJBvtDAD3PWzVlBvd09Hs8kvMyjp6 Pu2qMjGua4HTsauCjWku5sgJcTKrMN+LkAuwbdSCdGuBiTgwbF9mF933sHW8Rkzm /MAaf5gB9iHv/MrNbhbKvAv22yg+KndgQsajpi+YSUNUUFtoV9tfS4A4HXXOrwV9 zlAjqPMhnX7nMNRLUG2M4sQtQxV3feaY2BBKA2cyFCdPt1ah20Z9CQdegA7shLWL 4cA369iZJH9OpTS6gRV0mv57XT5K7qFcgC7zjYWAlhg3G9ZBsjP9JWXYfTHCNQZR o7U3hXOQ7MA1+ZSZRiD5dvBxI2QV+6Muf8qqod01FcAJnGySvkHUIqk1zP6RqYG1 7Phcfi51QI6cTjy00qLH/w4Y7f11bMrVmSltf4j+ApMbrJ4vQk8mr8IbMuP+fE7H o0JZMWjpNCDzj0SKTqpyNQ2/z8JVmW2zPJZIhMf35GJXCkhgWLa1v3h11lPEzngh 4KJiKRjpweQ= =nv51 -----END PGP SIGNATURE-----
--- End Message ---
