Hi Stefan, Сб 29 авг 2020 @ 07:52 Stefan Kangas <stefankan...@gmail.com>:
> Stefan Kangas <stefankan...@gmail.com> writes: > >> I have bumped the version of seq.el to 2.22 on the Emacs master branch. >> >> IIUC, the new version will be automatically picked up by the GNU ELPA >> scripts and available for installation within 24-48 hours. > > It turns out that seq.el is a special case where we have some > compatibility code for Emacs 24, so it needs manual intervention. > > The attached patch compiles without warnings on Emacs 26 and 27. > Unfortunately, I don't have Emacs 25 or 24 available for testing. > Could someone please help check that it's okay before I install it? Sorry for delay and thanks for your patch. I've applied your patch to seq from the ELPA git repository and tested it both in GNU Emacs 24 and GNU Emacs 25 from the Debian archive (stretch release). Here is the output: - GNU Emacs 24 $ emacs --version GNU Emacs 24.5.1 Copyright (C) 2015 Free Software Foundation, Inc. GNU Emacs comes with ABSOLUTELY NO WARRANTY. You may redistribute copies of Emacs under the terms of the GNU General Public License. For more information about these matters, see the file named COPYING. $ LANG=C.UTF-8 emacs -batch -L . -l tests/seq-tests.el --eval "(ert-run-tests-batch-and-exit)" Loading 00debian-vars... Running 34 tests (2020-09-04 10:36:18+0000) passed 1/34 test-seq-concatenate passed 2/34 test-seq-contains passed 3/34 test-seq-count passed 4/34 test-seq-difference passed 5/34 test-seq-drop passed 6/34 test-seq-drop-while passed 7/34 test-seq-empty-p passed 8/34 test-seq-every-p passed 9/34 test-seq-filter passed 10/34 test-seq-find passed 11/34 test-seq-group-by passed 12/34 test-seq-intersection passed 13/34 test-seq-into passed 14/34 test-seq-into-and-identity passed 15/34 test-seq-let passed 16/34 test-seq-map-indexed passed 17/34 test-seq-mapcat passed 18/34 test-seq-mapn passed 19/34 test-seq-mapn-circular-lists passed 20/34 test-seq-min-max passed 21/34 test-seq-partition passed 22/34 test-seq-position passed 23/34 test-seq-random-elt-signal-on-empty passed 24/34 test-seq-random-elt-take-all passed 25/34 test-seq-reduce passed 26/34 test-seq-remove passed 27/34 test-seq-reverse passed 28/34 test-seq-some passed 29/34 test-seq-sort passed 30/34 test-seq-sort-by passed 31/34 test-seq-subseq passed 32/34 test-seq-take passed 33/34 test-seq-take-while passed 34/34 test-seq-uniq Ran 34 tests, 34 results as expected (2020-09-04 10:36:18+0000) - GNU Emacs 25 $ emacs --version GNU Emacs 25.1.1 Copyright (C) 2016 Free Software Foundation, Inc. GNU Emacs comes with ABSOLUTELY NO WARRANTY. You may redistribute copies of GNU Emacs under the terms of the GNU General Public License. For more information about these matters, see the file named COPYING. $ LANG=C.UTF-8 emacs -batch -L . -l tests/seq-tests.el --eval "(ert-run-tests-batch-and-exit)" Loading 00debian-vars... seq-25.el: ‘seq-contains’ is an obsolete generic function (as of 27.1); use ‘seq-contains-p’ instead. Running 34 tests (2020-09-04 10:41:15+0000) passed 1/34 test-seq-concatenate passed 2/34 test-seq-contains passed 3/34 test-seq-count passed 4/34 test-seq-difference passed 5/34 test-seq-drop passed 6/34 test-seq-drop-while passed 7/34 test-seq-empty-p passed 8/34 test-seq-every-p passed 9/34 test-seq-filter passed 10/34 test-seq-find passed 11/34 test-seq-group-by passed 12/34 test-seq-intersection passed 13/34 test-seq-into passed 14/34 test-seq-into-and-identity passed 15/34 test-seq-let passed 16/34 test-seq-map-indexed passed 17/34 test-seq-mapcat passed 18/34 test-seq-mapn passed 19/34 test-seq-mapn-circular-lists passed 20/34 test-seq-min-max passed 21/34 test-seq-partition passed 22/34 test-seq-position passed 23/34 test-seq-random-elt-signal-on-empty passed 24/34 test-seq-random-elt-take-all passed 25/34 test-seq-reduce passed 26/34 test-seq-remove passed 27/34 test-seq-reverse passed 28/34 test-seq-some passed 29/34 test-seq-sort passed 30/34 test-seq-sort-by passed 31/34 test-seq-subseq passed 32/34 test-seq-take passed 33/34 test-seq-take-while passed 34/34 test-seq-uniq Ran 34 tests, 34 results as expected (2020-09-04 10:41:15+0000) Cheers! Lev
