* Steve Langasek [Thu, 01 Jun 2006 14:55:31 -0700]:
Hi Steve,
> Either way, there is still a bug in gnupg-agent here; at most, the
> x11-common workaround affects the severity of the gnupg-agent bug, but it's
> still a gnupg-agent bug. And it's still a bug that would manifest when
> installing gnupg-agent on a sarge system (partial upgrades), so it should
> still be fixed.
I understand this reasoning. However, this is my take on the matter: the
current script is well written, and makes reasonably sure that if the
final exit status is unsuccessful, it's not due to something under its
control, but outside (e.g., a badly-written gpg-agent.conf). When this
occurs, the script just ends with a non-zero status, as it should.
Since it's a Xsession script, the author may think of what should happen
if an error occurs:
(1) just leave the caller decide (current situation)
(2) ensure an error won't cause the X11 startup process to abort, by
adding "|| true" to the `gpg-agent --daemon` invocation
(3) ensure an error will cause the X11 startup process to abort, by
adding "|| exit 1" to the `gpg-agent --daemon` invocation
And, in my opinion, no Xsession script should get away from (1), so in
my opinion the script is fine as it is, and if I were the gnupg-agent
maintainer, this'd be wishlist+wontfix, since I can't think of (2) nor
(3) as the fix you ask for above.
I merged because I took this bug not as particular to gpg-agent, but to
any X11 init script: I saw here an user saying that user errors that pop
up in such scripts should not finish the session, and since this was
resolved elsewhere in the distribution, I pointed him there.
> Well, I don't agree that the change to x11-common was a correct fix; we have
> every reason to demand the same high quality of error handling for Xsession
> scripts as we do for other scripts in Debian, which is undermined by this
> casual use of set +e as a workaround. Isn't it reasonable to expect that I
> may *want* a failed Xsession script to cause the session to abort?
Yeah, we may, though as a distribution default, I think not aborting the
session is a better default. And then, is a non-zero exit status from
gpg-agent a failed Xsession script or not? I think it is, and the script
already ends with the appropriate exit status, letting the parent decide
what to do.
But alas, perhaps there's a number (4) option I did not see. For the
moment, I can't think how this bug can remain to be RC.
Cheers,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
When all is summed up, a man never speaks of himself without loss; his
accusations of himself are always believed; his praises never.
-- Michel de Montaigne
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
