Source: ndcube
Version: 1.3.2-1
Severity: serious
Tags: patch
Hi Vincent,
I just uploaded the new sunpy version, and this unfortunately breaks the
ndcube testing due to a missing dependency:
Sunpy no longer strongly depends on parfive, only recommends it. The
tests however require them (even when they actually can't download
data), so it must be explicitly added as build+test dependency.
I created a patch which is attached, and I also for convenience created
a merge request for it
<https://salsa.debian.org/debian-astro-team/ndcube/-/merge_requests/2>
Additionally, the patch fixes the CI command line: use the AUTOPKGTEST
instead of ADTMP environment variable, and directly invoke pytest
instead of using a sommand line Python script.
Severity is set to "serious", since ndcube now FTBFS.
Best
Ole
>From e80151a13ed14e48110c0b9ed1510a0df8429545 Mon Sep 17 00:00:00 2001
From: Ole Streicher <oleb...@debian.org>
Date: Mon, 29 Jun 2020 09:34:50 +0200
Subject: [PATCH] Add parfive to the test dependencies
Sunpy no longer strongly depends on parfive, only recommends it. The
tests however require them (even when they actually can't download
data), so it must be explicitly added as build+test dependency.
Additionally, the patch fixes the CI command line: use the AUTOPKGTEST
instead of ADTMP environment variable, and directly invoke pytest
instead of using a sommand line Python script.
---
debian/control | 1 +
debian/tests/control | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 8687225..07531eb 100644
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@ Build-Depends: debhelper (>= 12),
python3-all,
python3-astropy,
python3-astropy-helpers,
+ python3-parfive,
python3-pytest,
python3-setuptools,
python3-setuptools-scm,
diff --git a/debian/tests/control b/debian/tests/control
index 6a2e1da..dbecc28 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,4 +1,6 @@
-Test-Command: cd $ADTTMP && python3 -c "import ndcube; import pytest; exit(pytest.main(ndcube.__path__))"
+Test-Command: cd $AUTOPKGTEST_TMP && python3 -m pytest --pyargs ndcube
Depends: python3-ndcube,
+ python3-parfive,
+ python3-pytest,
python3-tk
Restrictions: allow-stderr
--
2.27.0
