Pkg_resources doesn't exist outside Debian (upstream it's part of setuptools), so an upstream change would not be appropriate.
Scott K On June 18, 2020 7:32:06 AM UTC, Raphael Hertzog <hert...@debian.org> wrote: >On Wed, 17 Jun 2020, Emmanuel Arias wrote: >> I've just pushed to salsa the fix, could anyone review it and sponsor >> it, please? > >Actually your fix does not work because pkg_resources is not documented >in >setup.py or requirements.txt and thus it will not magically appear in >${python3:Depends} just by adding it in Build-Depends. > >I opened https://github.com/SecureAuthCorp/impacket/issues/885 upstream >to >get this fixed but in the meantime we have to hardcode the dependency >in >Depends. I'll do that for now. > >Cheers, >> El mié., 17 de jun. de 2020 a la(s) 19:18, Emmanuel Arias >> (emmanuelaria...@gmail.com) escribió: >> > >> > Hi, >> > >> > I will fix it today >> > >> > Cheers, >> > Arias Emmanuel >> > @eamanu >> > http://eamanu.com >> > >> > El mié., 17 de jun. de 2020 a la(s) 19:18, Scott Kitterman >> > (deb...@kitterman.com) escribió: >> > > >> > > On Wed, 17 Jun 2020 21:12:40 +0200 Paul Gevers ><elb...@debian.org> wrote: >> > > > Source: impacket, smbmap >> > > > Control: found -1 impacket/0.9.21-1 >> > > > Control: found -1 smbmap/1.8.2-1 >> > > > Severity: serious >> > > > Tags: sid bullseye >> > > > X-Debbugs-CC: debian...@lists.debian.org >> > > > User: debian...@lists.debian.org >> > > > Usertags: breaks needs-update >> > > > >> > > > Dear maintainer(s), >> > > > >> > > > With a recent upload of impacket the autopkgtest of smbmap >fails in >> > > > testing when that autopkgtest is run with the binary packages >of >> > > > impacket from unstable. It passes when run with only packages >from >> > > > testing. In tabular form: >> > > > >> > > > pass fail >> > > > impacket from testing 0.9.21-1 >> > > > smbmap from testing 1.8.2-1 >> > > > all others from testing from testing >> > > > >> > > > I copied some of the output at the bottom of this report. Is >the latest >> > > > impacket missing a dependency or is the version function not >supported >> > > > anymore? >> > > > >> > > > Currently this regression is blocking the migration of impacket >to >> > > > testing [1]. Due to the nature of this issue, I filed this bug >report >> > > > against both packages. Can you please investigate the situation >and >> > > > reassign the bug to the right package? >> > > > >> > > > More information about this bug and the reason for filing it >can be found on >> > > > >https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation >> > > > >> > > > Paul >> > > > >> > > > [1] https://qa.debian.org/excuses.php?package=impacket >> > > > >> > > > >https://ci.debian.net/data/autopkgtest/testing/amd64/s/smbmap/5914948/log.gz >> > > > >> > > > autopkgtest [07:08:34]: test command1: smbmap -h >> > > > autopkgtest [07:08:34]: test command1: [----------------------- >> > > > Traceback (most recent call last): >> > > > File "/usr/bin/smbmap", line 19, in <module> >> > > > from impacket import version, smbserver >> > > > File "/usr/lib/python3/dist-packages/impacket/version.py", >line 7, in >> > > > <module> >> > > > import pkg_resources >> > > > ModuleNotFoundError: No module named 'pkg_resources' >> > > > autopkgtest [07:08:35]: test command1: -----------------------] >> > > > >> > > Looks like a missing depends on python3-pkg-resources for >impacket since >> > > that's where it's imported. >> > > >> > > Scott K >>