Your message dated Sun, 14 Jun 2020 02:48:29 +0000
with message-id <e1jkihb-000gfr...@fasolo.debian.org>
and subject line Bug#949664: fixed in libassuan 2.5.3-7.1
has caused the Debian Bug report #949664,
regarding libassuan: testsuite failure due to wrong flags being injected
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
949664: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949664
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: libassuan
Version: 2.5.3-7
Severity: serious
tags: patch
Hello, looks like we have 2 problems:
arm64 test failure because the compiler is not meant to run there (but the
package is installable)
amd64 -> w32 test failure because of wrong flags injected (the libgpg-error has
this fix, not sure why it hasn't been copied on this package).
The following patch fixes both, and "syncs" the build-windows file with the
correspondent libgpg-error one (so melding is easier to do)
(amd64 flags were used for w32 builds due to wrong pkg-config call)
diff -Nru libassuan-2.5.3/debian/changelog libassuan-2.5.3/debian/changelog
--- libassuan-2.5.3/debian/changelog 2019-07-17 17:09:10.000000000 +0200
+++ libassuan-2.5.3/debian/changelog 2019-07-19 10:24:16.000000000 +0200
@@ -1,3 +1,12 @@
+libassuan (2.5.3-7.1) unstable; urgency=medium
+
+ * Fix testsuite flags being incorrectly passed
+ (patch taken from libgpg-error). (LP: #1856056
+ Closes: #-1)
+ * Do not fail new test on arm64
+
+ -- Gianfranco Costamagna <locutusofb...@debian.org> Fri, 19 Jul 2019
10:24:16 +0200
+
libassuan (2.5.3-7) unstable; urgency=medium
* export CPPFLAGS_FOR_BUILD as well
diff -Nru libassuan-2.5.3/debian/tests/build-windows
libassuan-2.5.3/debian/tests/build-windows
--- libassuan-2.5.3/debian/tests/build-windows 2019-07-16 19:49:54.000000000
+0200
+++ libassuan-2.5.3/debian/tests/build-windows 2019-07-19 10:24:16.000000000
+0200
@@ -2,35 +2,35 @@
set -e
-ARCH=$1
+ARCH="$1"
if [ "$ARCH" = x86_64 ]; then
- GCC=x86_64-w64-mingw32-gcc
WINE=/usr/lib/wine/wine64
export WINESERVER=/usr/lib/wine/wineserver64
elif [ "$ARCH" = i686 ]; then
- GCC=i686-w64-mingw32-gcc
WINE=/usr/lib/wine/wine
export WINESERVER=/usr/lib/wine/wineserver32
else
printf >&2 'Unknown Architecture: %s\n' "$ARCH"
exit 1
fi
+GCC="${ARCH}-w64-mingw32-gcc"
# get wine initialized, which normally spews logs to stderr
# (autopkgtest doesn't want stderr)
"$WINE" hostname 2>&1
-export PKG_CONFIG_PATH=/usr/x86_64-w64-mingw32/lib/pkgconfig
+if [ `dpkg --print-architecture` = 'arm64' ] ; then
+ echo "Don't fail testsuite on arm64, this test always failed there"
+ exit 0
+fi
-# see https://dev.gnupg.org/T4624 for why this is needed
-extralibs=(-lws2_32)
+export PKG_CONFIG_PATH="/usr/${ARCH}-w64-mingw32/lib/pkgconfig"
-"$GCC" -pedantic -Wall -Werror -o test-run.exe \
- -static \
- -Wl,--no-as-needed \
- debian/tests/simple-build.c \
- $(pkg-config --static --cflags --libs libassuan) "${extralibs[@]}"
+# see https://dev.gnupg.org/T4624 for why this is needed
+extra_libs=(-lws2_32)
+# build a static windows binary around libassuan and run it:
+"$GCC" -pedantic -Wall -Werror -static -o test-run.exe
debian/tests/simple-build.c $(pkg-config --cflags --static --libs libassuan)
"${extra_libs[@]}"
"$WINE" ./test-run.exe
-rm -f test-run.exe
+rm -f ./test-run.exe
diff -Nru libassuan-2.5.3/debian/changelog libassuan-2.5.3/debian/changelog
--- libassuan-2.5.3/debian/changelog 2019-07-17 17:09:10.000000000 +0200
+++ libassuan-2.5.3/debian/changelog 2019-07-19 10:24:16.000000000 +0200
@@ -1,3 +1,12 @@
+libassuan (2.5.3-7.1) unstable; urgency=medium
+
+ * Fix testsuite flags being incorrectly passed
+ (patch taken from libgpg-error). (LP: #1856056
+ Closes: #-1)
+ * Do not fail new test on arm64
+
+ -- Gianfranco Costamagna <locutusofb...@debian.org> Fri, 19 Jul 2019
10:24:16 +0200
+
libassuan (2.5.3-7) unstable; urgency=medium
* export CPPFLAGS_FOR_BUILD as well
diff -Nru libassuan-2.5.3/debian/tests/build-windows
libassuan-2.5.3/debian/tests/build-windows
--- libassuan-2.5.3/debian/tests/build-windows 2019-07-16 19:49:54.000000000
+0200
+++ libassuan-2.5.3/debian/tests/build-windows 2019-07-19 10:24:16.000000000
+0200
@@ -2,35 +2,35 @@
set -e
-ARCH=$1
+ARCH="$1"
if [ "$ARCH" = x86_64 ]; then
- GCC=x86_64-w64-mingw32-gcc
WINE=/usr/lib/wine/wine64
export WINESERVER=/usr/lib/wine/wineserver64
elif [ "$ARCH" = i686 ]; then
- GCC=i686-w64-mingw32-gcc
WINE=/usr/lib/wine/wine
export WINESERVER=/usr/lib/wine/wineserver32
else
printf >&2 'Unknown Architecture: %s\n' "$ARCH"
exit 1
fi
+GCC="${ARCH}-w64-mingw32-gcc"
# get wine initialized, which normally spews logs to stderr
# (autopkgtest doesn't want stderr)
"$WINE" hostname 2>&1
-export PKG_CONFIG_PATH=/usr/x86_64-w64-mingw32/lib/pkgconfig
+if [ `dpkg --print-architecture` = 'arm64' ] ; then
+ echo "Don't fail testsuite on arm64, this test always failed there"
+ exit 0
+fi
-# see https://dev.gnupg.org/T4624 for why this is needed
-extralibs=(-lws2_32)
+export PKG_CONFIG_PATH="/usr/${ARCH}-w64-mingw32/lib/pkgconfig"
-"$GCC" -pedantic -Wall -Werror -o test-run.exe \
- -static \
- -Wl,--no-as-needed \
- debian/tests/simple-build.c \
- $(pkg-config --static --cflags --libs libassuan) "${extralibs[@]}"
+# see https://dev.gnupg.org/T4624 for why this is needed
+extra_libs=(-lws2_32)
+# build a static windows binary around libassuan and run it:
+"$GCC" -pedantic -Wall -Werror -static -o test-run.exe
debian/tests/simple-build.c $(pkg-config --cflags --static --libs libassuan)
"${extra_libs[@]}"
"$WINE" ./test-run.exe
-rm -f test-run.exe
+rm -f ./test-run.exe
--- End Message ---
--- Begin Message ---
Source: libassuan
Source-Version: 2.5.3-7.1
Done: Filipi Souza <filipi.s...@gmail.com>
We believe that the bug you reported is fixed in the latest version of
libassuan, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 949...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Filipi Souza <filipi.s...@gmail.com> (supplier of updated libassuan package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 10 Jun 2020 06:57:10 -0300
Source: libassuan
Architecture: source
Version: 2.5.3-7.1
Distribution: unstable
Urgency: medium
Maintainer: Debian GnuPG-Maintainers <pkg-gnupg-ma...@lists.alioth.debian.org>
Changed-By: Filipi Souza <filipi.s...@gmail.com>
Closes: 949664
Changes:
libassuan (2.5.3-7.1) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/tests/build-windows: updated to fix testsuite flags being
incorrectly passed and to skip a test fail on arch arm64. Thanks
Gianfranco Costamagna. (Closes: #949664)
Checksums-Sha1:
7e6a8e098e41893d47c72a774890eed5070ba14d 2627 libassuan_2.5.3-7.1.dsc
6f8afa64a2a4db572a77d6c0b4ead3f6b03783f2 13952
libassuan_2.5.3-7.1.debian.tar.xz
c2122ecc35ef1b0b797e30190688a13f9c6296c7 5338
libassuan_2.5.3-7.1_source.buildinfo
Checksums-Sha256:
9e4cfaef54fee1b6c1fd32fdfe6fc90b2dde78755517ee0ff56859e69251fb07 2627
libassuan_2.5.3-7.1.dsc
c6783e12dc1fb65681c083274f52cb3286da18dcf8a5b38a6de10143003e0681 13952
libassuan_2.5.3-7.1.debian.tar.xz
d1875dc5b1813aade3d83c6c7fff5c0c03390845d1222292b8d4c81824af3555 5338
libassuan_2.5.3-7.1_source.buildinfo
Files:
ab8728b8462170313ab8c907ed633600 2627 libs optional libassuan_2.5.3-7.1.dsc
02c1721882c8dab5760ebf67e1557f8d 13952 libs optional
libassuan_2.5.3-7.1.debian.tar.xz
452c674400abf428b25fac2f756980ee 5338 libs optional
libassuan_2.5.3-7.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAl7i4sQACgkQ3mO5xwTr
6e9ffw/+MoW+ICOFy7MEbCBG0JXIXt6B1RKhG16W6tCaXXXp/jvwpb+fka2C/rPR
qqy46RVQpAR0Eh1jS+FTep5uHOztKUwIIb3HdkminkbtUMa0MyFM5T1GDQgRxb9b
Qxbzk2ds2HToJ+ASLZIzTLDH6Q0wsWefU8Y6o+aRf9NkumueggJcqoVlZ95MSzLC
qLe4Bd1aRkMc6bjr0ahiJlJYcQfdj9vUC/vLLk9HUpTD778d4XQ6Zo98t2CRLmHt
MOCfcvjhdg4BL2nvUnj/BKEy7K7YdzdNW3Q5bxtPg8J0e7M3RByiDA+Lyr95Jhqt
9TEbrOx0sORmAgTcrgO+xJ5U7muGRQpvnHcxX4z8I2AZHCaaCdh18GyVLGbb+m86
+fokkEeMTNAhZvypD3uO4EXyrwAWJcf5wJ7kMPAqRDBMGrwJQePdxCzxcVvpGQPR
NWOqb6OGA5fC2arnq1YaS30cje0aERVBnq6omFnH3hvnNOx0f2++FXSJSaHbJ7Gd
R9Ii9QI6qGdaWayYp6R+uht3stv/yoT9BBBW8NlczhVOl6Id+vOEAHh4z4C5xK+7
McdoEDkhTXJU+Xv6VNSQNXSkM/hVR4jxLkjxVGpm4m/I24oRNNg/QE/2ZiM44dmf
Ruwxyhd6KKx0jV1UzkHTMgaAb8YlWdTHoPuMh1R+dJ5iPsZL2cc=
=7sx1
-----END PGP SIGNATURE-----
--- End Message ---
