Your message dated Sat, 23 May 2020 02:07:52 -0500
with message-id <1654791.LboCmOBNxM@rgb>
and subject line Re: freecad: autopkgtest regression with opencascade 7.4
has caused the Debian Bug report #961131,
regarding freecad: autopkgtest regression with opencascade 7.4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
961131: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961131
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: freecad
Version: 0.18.4+dfsg2-2
Tags: patch
X-Debbugs-CC: debian...@lists.debian.org
Severity: serious
User: debian...@lists.debian.org
Usertags: regression

Hi Maintainer

Freecad fails its autopkgtests with opencascade 7.4 [1]:

testTaperedHole (PartDesignTests.TestHole.TestHole) ... FAIL

The attached patch is applied in Ubuntu.

Regards
Graham


[1] https://ci.debian.net/packages/f/freecad/
Description: partdesign: fix failing tapered hole test
 The given parameters return an invalid shape. This fails with occt7.4 but
 doesn't with occt7.3. If the angle is 45 degree the cone is
 self-intersecting as Hole.Depth > Hole.Diameter/2. Changing the 
 Hole.TaperedAngle to 60 degree solves this issue.
Author: lorenz <loo...@users.noreply.github.com>
Last-Update: 2020-05-03

--- a/src/Mod/PartDesign/PartDesignTests/TestHole.py
+++ b/src/Mod/PartDesign/PartDesignTests/TestHole.py
@@ -67,7 +67,7 @@
     def testTaperedHole(self):
         self.Hole.Diameter = 6
         self.Hole.Depth = 5
-        self.Hole.TaperedAngle = 45
+        self.Hole.TaperedAngle = 60
         self.Hole.ThreadType = 0
         self.Hole.HoleCutType = 0
         self.Hole.DepthType = 0

--- End Message ---
--- Begin Message ---
Package: freecad
Version: 0.18.4+dfsg2-3

This was fixed in an upload done slightly before the bug was filed, though with 
a different patch; I'll probably replace it with this one in a subsequent 
upload.

--- End Message ---

Reply via email to