Control: tags -1 + patch On Monday, May 11 2020, Paul Gevers wrote:
> Dear maintainer(s), > > With a recent upload of squid the autopkgtest of squid fails in testing > when that autopkgtest is run with the binary packages of squid from > unstable. It passes when run with only packages from testing. In tabular > form: > > pass fail > squid from testing 4.11-4 > all others from testing from testing > > I copied some of the output at the bottom of this report. > > Currently this regression is blocking the migration to testing [1]. Can > you please investigate the situation and fix it? > > More information about this bug and the reason for filing it can be found on > https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation > > Paul > > [1] https://qa.debian.org/excuses.php?package=squid > > https://ci.debian.net/data/autopkgtest/testing/amd64/s/squid/5424910/log.gz > autopkgtest [00:09:42]: test squid: [----------------------- > Considering dependency setenvif for ssl: > Module setenvif already enabled > Considering dependency mime for ssl: > Module mime already enabled > Considering dependency socache_shmcb for ssl: > Enabling module socache_shmcb. > Enabling module ssl. > See /usr/share/doc/apache2/README.Debian.gz on how to configure SSL and > create self-signed certificates. > To activate the new configuration, you need to run: > systemctl restart apache2 > Enabling site default-ssl. > To activate the new configuration, you need to run: > systemctl reload apache2 > test_daemons (__main__.BasicTest) > Test daemon ... FAIL > test_ftp_proxy (__main__.BasicTest) > Test ftp ... ok > test_http_proxy (__main__.BasicTest) > Test http ... ok > test_https_proxy (__main__.BasicTest) > Test https ... ok > test_squidclient (__main__.BasicTest) > Test squidclient ... ok > test_zz_apparmor (__main__.BasicTest) > Test apparmor ... ok > > ====================================================================== > FAIL: test_daemons (__main__.BasicTest) > Test daemon > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/tmp/autopkgtest-lxc.lb13ubw0/downtmp/build.JEa/src/debian/tests/test-squid.py", > line 120, in test_daemons > self.assertTrue(check_pidfile(exe, pidfile)) > AssertionError: False is not true > > ---------------------------------------------------------------------- > Ran 6 tests in 236.530s > > FAILED (failures=1) > autopkgtest [00:13:40]: test squid: -----------------------] Here's a patch that fixes the issue above. Please note that even after fixing this specific issue, I still see another failure with test_zz_apparmor. I've posted a merge request to also fix this problem here: https://salsa.debian.org/squid-team/squid/-/merge_requests/12 Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/ diff --git a/debian/changelog b/debian/changelog index a504329d..7b501b4d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +squid (4.11-5) UNRELEASED; urgency=medium + + * Fix 'pidfile' on d/t/tests-squid.py. + The pidfile lives under '/run/squid/', not '/run/'. (Closes: #960327) + + -- Sergio Durigan Junior <sergi...@debian.org> Wed, 13 May 2020 21:22:29 -0400 + squid (4.11-4) unstable; urgency=medium [ Amos Jeffries <amosjeffr...@squid-cache.org> ] diff --git a/debian/tests/test-squid.py b/debian/tests/test-squid.py index 53a5af9a..c5de7b95 100644 --- a/debian/tests/test-squid.py +++ b/debian/tests/test-squid.py @@ -114,7 +114,7 @@ class BasicTest(HttpdCommon): def test_daemons(self): '''Test daemon''' - pidfile = "/run/squid.pid" + pidfile = "/run/squid/squid.pid" exe = "squid" self.assertTrue(check_pidfile(exe, pidfile))
signature.asc
Description: PGP signature
