control: tag -1 + patch

On 2020-03-25 09:51, Aurelien Jarno wrote:
> Hi,
> 
> On 2020-03-12 13:55, Emilio Pozuelo Monfort wrote:
> > Control: severity -1 serious
> > 
> > On Wed, 4 Mar 2020 01:53:25 +0100 Nicolas Boulenguez <nico...@debian.org> 
> > wrote:
> > > Source: libgnatcoll-db
> > > Version: 19.2-2
> > > Severity: normal
> > > 
> > > The relevant lines are:
> > > 
> > > xref/gnatcoll-xref.adb: In function ‘GNATCOLL.XREF’:
> > > xref/gnatcoll-xref.adb:40:1: note: variable tracking size limit exceeded 
> > > with ‘-fvar-tracking-assignments’, retrying without
> > > Assembler messages:
> > > 678119: Error: branch out of range
> > 
> > This package has old binaries in mipsel, so this failure is RC as it 
> > prevents
> > the package from migrating to testing.
>  
> I have just got aware of this bug as it indirectly prevents gcc-8
> removal and makes the GCC maintainer angry. In the future don't hesitate
> to Cc: the debian-m...@lists.debian.org mailing list so that porters can
> be aware of the issue.
> 
> My knowledge of ADA is very limited, so I am not sure I fully understood
> the problem. However please find below a first workaround using the
> -mxgot option to increase the size of the GOT and allow bigger jumps.

Hmm I didn't test the latest version of my patch. It happens that the
DEB_CFLAGS_MAINT_APPEND variable has to be set before the include
/usr/share/dpkg/buildflags.mk. Please find below an updated patch:

--- libgnatcoll-db-19.2/debian/rules    2019-12-17 11:41:57.000000000 +0000
+++ libgnatcoll-db-19.2/debian/rules    2020-03-25 08:41:05.000000000 +0000
@@ -23,6 +23,13 @@
 DEB_BUILD_MAINT_OPTIONS := hardening=+all
 DEB_LDFLAGS_MAINT_APPEND := -Wl,--no-undefined \
   -Wl,--no-copy-dt-needed-entries -Wl,--no-allow-shlib-undefined
+
+# On mipsel gnatcoll-xref.adb generates long jump that do not fit in
+# standard branch instructions. Use the mxgot option to workaround that.
+ifeq ($(DEB_HOST_ARCH),mipsel)
+DEB_CFLAGS_MAINT_APPEND := -mxgot
+endif
+
 include /usr/share/dpkg/buildflags.mk
 include /usr/share/ada/debian_packaging-$(GNAT_VERSION).mk

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurel...@aurel32.net                 http://www.aurel32.net

Attachment: signature.asc
Description: PGP signature

Reply via email to