Your message dated Tue, 07 Jan 2020 10:34:18 +0000
with message-id <e1iombm-0000a5...@fasolo.debian.org>
and subject line Bug#947828: fixed in freedv 1.4-1.1
has caused the Debian Bug report #947828,
regarding freedv FTBFS on most architectures, unconditionally uses x86 asm for
avx detection.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
947828: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947828
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: freedv
Version: 1.4-1
Severity: serious
Tags: patch
Freedv 1.4 added support for the 2020 codec. This feature is only enabled if
avx support is detected. Comments in the source code claim that this is because
without avx support it will not be processed fast enough for realtime
operation. I have not dug into the question of if the 2020 code benefits from
avx specifically or if avx is just being used as a proxy for general CPU
performance.
Unfortunately the avx detection code is i386/amd64 specific inline assembler,
so it causes a compile failure on everything else.
The attached debdiff puts the asm behind architecture ifdefs and uses a stub
that always returns false on other architectures.
I may or may not NMU this later.
diff -Nru freedv-1.4/debian/changelog freedv-1.4/debian/changelog
--- freedv-1.4/debian/changelog 2019-11-18 03:32:07.000000000 +0000
+++ freedv-1.4/debian/changelog 2019-12-31 10:20:26.000000000 +0000
@@ -1,3 +1,10 @@
+freedv (1.4-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Put x86 specific code behind ifdefs.
+
+ -- Peter Michael Green <plugw...@debian.org> Tue, 31 Dec 2019 10:20:26 +0000
+
freedv (1.4-1) unstable; urgency=medium
* New upstream release
diff -Nru freedv-1.4/debian/patches/put-x86-specific-code-behind-ifdefs
freedv-1.4/debian/patches/put-x86-specific-code-behind-ifdefs
--- freedv-1.4/debian/patches/put-x86-specific-code-behind-ifdefs
1970-01-01 00:00:00.000000000 +0000
+++ freedv-1.4/debian/patches/put-x86-specific-code-behind-ifdefs
2019-12-31 10:20:26.000000000 +0000
@@ -0,0 +1,27 @@
+Description: Put x86 specific code behind ifdefs.
+Author: Peter Michael Green <plugw...@debian.org>
+
+--- freedv-1.4.orig/src/fdmdv2_main.cpp
++++ freedv-1.4/src/fdmdv2_main.cpp
+@@ -4496,6 +4496,8 @@ void MainFrame::CloseSerialPort(void)
+ // Tests the underlying platform for AVX support. 2020 needs AVX support to
run
+ // in real-time, and old processors do not offer AVX support
+ //
++#if defined(__x86_64__) || defined(_M_X64) || defined(__i386) ||
defined(_M_IX86)
++
+ void __cpuid(int* cpuinfo, int info)
+ {
+ __asm__ __volatile__(
+@@ -4538,6 +4540,12 @@ void MainFrame::checkAvxSupport(void)
+
+ isAvxPresent = avxSupported;
+ }
++#else
++void MainFrame::checkAvxSupport(void)
++{
++ isAvxPresent = false;
++}
++#endif
+
+ #ifdef __UDP_SUPPORT__
+
diff -Nru freedv-1.4/debian/patches/series freedv-1.4/debian/patches/series
--- freedv-1.4/debian/patches/series 2019-11-18 03:32:07.000000000 +0000
+++ freedv-1.4/debian/patches/series 2019-12-31 10:20:26.000000000 +0000
@@ -2,3 +2,4 @@
HID-PTT
debian-version
optional-lpcnetfreedv
+put-x86-specific-code-behind-ifdefs
--- End Message ---
--- Begin Message ---
Source: freedv
Source-Version: 1.4-1.1
We believe that the bug you reported is fixed in the latest version of
freedv, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 947...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Peter Michael Green <plugw...@debian.org> (supplier of updated freedv package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 07 Jan 2020 10:09:41 +0000
Source: freedv
Architecture: source
Version: 1.4-1.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-h...@lists.debian.org>
Changed-By: Peter Michael Green <plugw...@debian.org>
Closes: 947828
Changes:
freedv (1.4-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Put x86 specific code behind ifdefs (Closes: 947828).
Checksums-Sha1:
298d01844e6251748996401b9e2f9b688244d77f 2052 freedv_1.4-1.1.dsc
790466dddf2366aa327427ba3b2d1e77008c0e65 17504 freedv_1.4-1.1.debian.tar.xz
93dba0cd0710ac0c626ef353f4e0abfdeee22c80 11161 freedv_1.4-1.1_source.buildinfo
Checksums-Sha256:
84ea5ded4965b610cc5ca394da1607575ba5aa67bc3de684248ea1e190f6dc70 2052
freedv_1.4-1.1.dsc
8251328df2e252d442e1ee0cdde1f046764f01002ea9a4462b1e154caaca1086 17504
freedv_1.4-1.1.debian.tar.xz
6c805d6898beb07fc61e36e69fea67b36be31cf380c0437403375245c2aad6d3 11161
freedv_1.4-1.1_source.buildinfo
Files:
828c6529114e9264e9185b9117ce9bdb 2052 hamradio optional freedv_1.4-1.1.dsc
1bf3cd5588a261fca967344d7661336a 17504 hamradio optional
freedv_1.4-1.1.debian.tar.xz
5b14a3e518110883e304447817b1b9ce 11161 hamradio optional
freedv_1.4-1.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJIBAEBCAAyFiEEU0DQATYMplbjSX63DEjqKnqP/XsFAl4UW70UHHBsdWd3YXNo
QGRlYmlhbi5vcmcACgkQDEjqKnqP/Xv6YA/5AXZYogDjhk/AGd7MeuEzynF8VKNM
eEE90LbL3oqS5qkn6Zc26I344UXTV4M8UrW2LAnm09K1rk6E9BIuVxVsVdhriWkN
vXyKyDQ3fIRvUXTPS3I5AwPMS7lwkQ0q5kvfT0RhjSvgfYCCA4aGwYK8dFHzUeOr
/DVReNSlFckEo8tW7ILDT/hKxRVh8vKSRLIFeZYLH1s3npqGX9S3FCbQsHX8U7uj
v2FbX8ZVDqfggUOqN1CkeliojIuAKJqVQNlPqSG820LqT/DzSfesUaBrqui7Lqo5
J9haUK1qtj61OCUHr4gYUbOwVX9N38QghxepSc+o5dcdh4gVIxxdS56odCqoCxw2
LRSFYT8bTqDScMsB2Sb3hAZfWkWwAF4Nli5ZOzAvEd/dGoX3nuWOOjC+FKih8Biy
x7YrAoniU6g6vD8LzvQ3zhN9uIRlZI0Q8kTKY+rP8Xs/TuOYTQfPrra0wl+DaG6z
9sBkP1MuaM/tNjWK+FmAE5AzV8+nhNKaENxVVv8sSWjnHjtR12107qvw9jccmZq6
glgIuDXF/5xwreeP6+nQEUpbTIjdqNm9JnNSMlpQUDReYGqPJP5bTZaU/DJ3bnEz
UCwMMA58mzy6hOG6ymmuBTmhFb1uxdyirpfHrdSppK5Z5alS2OsiaNNAA0CLZxlp
MvpxvfksurNMjIU=
=TtuV
-----END PGP SIGNATURE-----
--- End Message ---
