On 1/2/20 11:58 PM, Thorsten Alteholz wrote: > CODE_OF_CONDUCT.md not accounted for in d/copyright (it's CC-BY-4.0).
You really had to dig for that one. > Copyright for docs/auth.html wrong, and the file seems to be generated > from auth.md -- can you confirm we can regenerate it with tools in the > archive? What makes you say the copyright is wrong? It falls under the "Files: *" section, which is BSD-3-Clause after the relicensing from the NetCDF license. doxygen is used to generate the HTML docs, which is part of the build process. > What reason is there to think that docs\unidata_logo_cmyk.png is > redistributible? What reason is there to think that it isn't? Unidata develops NetCDF and chose to include their logo in the source tree to use it in the (generated) documentation. > Can docs/docmap.pdf be rebuilt? Why do you care? > Are the .dmp, .hdf4 and .nc files in dap4_test/, hdf4_test/ and > h5_test/ perhaps generated files? Can they be regenerated? They are test data, they shouldn't be regenerated. > I think that it would be best to explicitly include the Unidata > copyright line from COPYRIGHT in addition to the "University > Corporation for Atmospheric Research/Unidata" line. "2018 Unidata" is already part of "1988-2019, University Corporation for Atmospheric Research/Unidata" I don't see why including the former is in any way better. > Please take care of these issues. I've added license & copyright for CODE_OF_CONDUCT.md, that is enough to fix this issue in my opinion. If you also demand that I fix the pedantic issues, I'll instead start working on removing netcdf and everything that depends on it from Debian as I don't enjoy working on these packages. I only do so because it's currently a dependency of gdal, but that can be changed. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
